Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 13:43:44 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Biju Das <biju.das.jz@bp.renesas.com>
Cc:     Randy Dunlap <rd.dunlab@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
Message-ID: <ZLZ68OUizlOqoZmn@orome>
References: <ac8d6190-06ae-b538-1293-07efedbfe94e@gmail.com>
 <OS0PR01MB5922D3163524299B94166B178638A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="D90jt/TQ2RxVcnZA"
Content-Disposition: inline
In-Reply-To: <OS0PR01MB5922D3163524299B94166B178638A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--D90jt/TQ2RxVcnZA
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 18, 2023 at 11:26:28AM +0000, Biju Das wrote:
> Hi Randy,
>=20
> > -----Original Message-----
> > From: Randy Dunlap <rd.dunlab@gmail.com>
> > Sent: Tuesday, July 18, 2023 7:41 AM
> > To: linux-kernel@vger.kernel.org; linux-pwm@vger.kernel.org
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Thierry Reding
> > <thierry.reding@gmail.com>; Uwe Kleine-K=C3=B6nig <u.kleine-
> > koenig@pengutronix.de>
> > Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
> >=20
> > From: Randy Dunlap <rd.dunlab@gmail.com>
> >=20
> > When (MFD) RZ_MTU3=3Dm and PWM_RZ_MTU3=3Dy, there are numerous build er=
rors:
> >=20
> > ld: vmlinux.o: in function `rz_mtu3_pwm_config':
> > drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
> > ld: drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to
> > `rz_mtu3_8bit_ch_write'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
> > drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to
> > `rz_mtu3_16bit_ch_write'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_config':
> > drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to
> > `rz_mtu3_8bit_ch_write'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
> > drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to
> > `rz_mtu3_16bit_ch_write'
> > ld: drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to
> > `rz_mtu3_16bit_ch_write'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_config':
> > drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_disable':
> > drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to
> > `rz_mtu3_8bit_ch_write'
> > ld: drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to
> > `rz_mtu3_disable'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_enable':
> > drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to
> > `rz_mtu3_8bit_ch_write'
> > ld: drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to
> > `rz_mtu3_8bit_ch_write'
> > ld: drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enab=
le'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':
> > drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabl=
ed'
> > ld: drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to
> > `rz_mtu3_8bit_ch_read'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':
> > drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to
> > `rz_mtu3_16bit_ch_read'
> > ld: drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to
> > `rz_mtu3_16bit_ch_read'
> > ld: drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to
> > `rz_mtu3_16bit_ch_read'
> > ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':
> > drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to
> > `rz_mtu3_8bit_ch_read'
> >=20
> > Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is still
> > allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built but also
> > allow the latter not to be built.
> >=20
> > Fixes: 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")
> > Signed-off-by: Randy Dunlap <rd.dunlab@gmail.com
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>
> > Cc: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: linux-pwm@vger.kernel.org
> > ---
> > v2: fix typo in Subject;
> >     correct my email address while infradead.org is down;
> >=20
> >  drivers/pwm/Kconfig |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >=20
> > diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > --- a/drivers/pwm/Kconfig
> > +++ b/drivers/pwm/Kconfig
> > @@ -505,7 +505,8 @@ config PWM_ROCKCHIP
> >=20
> >  config PWM_RZ_MTU3
> >  	tristate "Renesas RZ/G2L MTU3a PWM Timer support"
> > -	depends on RZ_MTU3 || COMPILE_TEST
> > +	depends on COMPILE_TEST
> > +	depends on RZ_MTU3 || RZ_MTU3=3Dn
> >  	depends on HAS_IOMEM
> >  	help
> >  	  This driver exposes the MTU3a PWM Timer controller found in
>=20
>=20
> The below patch also works fine,
>=20
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 1c8dbb064ee5..56ab2f4b91fe 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -505,7 +505,7 @@ config PWM_ROCKCHIP
> =20
>  config PWM_RZ_MTU3
>         tristate "Renesas RZ/G2L MTU3a PWM Timer support"
> -       depends on RZ_MTU3 || COMPILE_TEST
> +       depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3)

That's a bit pointless, isn't it? That effectively reduces to just:

	depends on RZ_MTU3

Thierry

--D90jt/TQ2RxVcnZA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS2evAACgkQ3SOs138+
s6EJ6BAAm/1a5iFP5YYhXGdTWZAK2fkfqxfSnZjUnPrwkMHgKFZLq+lcL+tvazAA
HFiSRhn3fak7A/itAIOXqEh9dxIisKIsJgdr6PH1wsgpl1h7Otcv0Vo/nD3cntoM
xcJfrXKzsGpGCrMqy8nSEE16i0r47Vn+hDoFBjFAvQQOzwKi6F7C645utYSFx7CB
PnuzfN5qFWGTx9RAeMxaYPAHNwqWCGsZxff+yonrVf1KPdv6eD+r6sWckIF3zmI8
KYlLOT0s6IkWVTqgzJZuzwfw5qmt7upk4+dkZRBTJrxaVaBSMi51b2z3P3eMIgqC
KhsyHIvhQVf6kFVWbbxtRhpKrZSik19hhkEAAQsEpIVad5F3KobcYEitA+zIt3tX
86Vd5AuQuAb28Y/CwfRP/68bb/sTh9Nx+f8aoXOqTl8m/dsovu/yVkkO1VD20xyv
uDrlAtUzLmFyB1ueDXaaIxGS7fEwAxXChidA8ZQiGYD/zCgLJRmsHlyKp0H4H15/
tdcWSFSLzn6xKfH7sWzweZa3TzbHHG4w+9DBMnZt1T4g46jB1CDktIvEUfYZO3rv
xfbZCnJh9PYBOGPEDQYP8DRQu3rfYGP3QiQhOAYGEfXYr4l8wEqXBWB+Gg4HFXgQ
hJhgdp0hvnE3nsBdpd9CIpWQYHBS3C/lboMxbKK74B0Aug4uzu8=
=i0DA
-----END PGP SIGNATURE-----

--D90jt/TQ2RxVcnZA--