Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230712-spi-nor-winbond-w25q128-v2-1-50c9f1d58d6c@linaro.org>
 <f00fa2ae-6d4a-90cb-3724-2bedb96cb4fb@linaro.org> <0525440a652854a2a575256cd07d3559@walle.cc>
 <d99d87e7-47ba-d6fe-735f-16de2a2ec280@linaro.org> <e642ff27fd0bc0f1f0e293972145f680@walle.cc>
 <2d71326c-023e-69af-9337-62672f50fed9@linaro.org> <62083227d40d7b631c2eeac1e40c6b56@walle.cc>
 <ef557792-144e-12ef-ce14-f98982b608dc@linaro.org>
In-Reply-To: <ef557792-144e-12ef-ce14-f98982b608dc@linaro.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 18 Jul 2023 13:58:01 +0200
Message-ID: <CACRpkdY_3Ecw06ECVx3=xB9G1zUBDqmjuhwbaS8k3+RKNErwnA@mail.gmail.com>
Subject: Re: [PATCH v2] mtd: spi-nor: Correct flags for Winbond w25q128
To:     Tudor Ambarus <tudor.ambarus@linaro.org>
Cc:     Michael Walle <michael@walle.cc>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 18, 2023 at 11:47=E2=80=AFAM Tudor Ambarus <tudor.ambarus@linar=
o.org> wrote:

> Hi, Linus,
>
> On 7/18/23 09:32, Michael Walle wrote:
> > FWIW, I'm fine with the removed no_sfdp_flags if INFO(, 0, 0, 0).
>
> We'll need a v5 where you test again the flash with mtd_utils,
> as we want to get rid of n_sectors and sectors_size and instead
> determine them from SFDP. We agreed that the flash entry should
> be defined with the following params:
>
>         { "w25q128", INFO(0xef4018, 0, 0, 0)
>                 PARSE_SFDP
>                 FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },

Roger that!

I sent a v5 which does this, tested by taking the reported
size in dmesg and divide by reported (correct) eraseblock size and
it results in the same number of sectors as well.

I put the details into the commit message.

Yours,
Linus Walleij