Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6840094rwp; Tue, 18 Jul 2023 06:40:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlGemoXU1L4B2rolPXB9r18HMA85XmiTL843MJYiuJSGCBfbOYwnIzmOreodBTXrF8TuF5eR X-Received: by 2002:a17:906:b04:b0:992:d013:1135 with SMTP id u4-20020a1709060b0400b00992d0131135mr13077782ejg.63.1689687602510; Tue, 18 Jul 2023 06:40:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689687602; cv=none; d=google.com; s=arc-20160816; b=dMoK+zf9Kkoh2QGtulzPmurjHlg8PtHAOegqSg+guHk0xyHswIKnZ6sn0S04uKD3Ca LNkbDz2wY4yEgKagh1cUtqpVb0PmgTgvLll6jk+8ZmCkxVgzPrFgk+CytU+zIxOsgpPu EbDyAweDpGq0+e/DF+CPsoVbtck/Bepp31JGaNKeZKNOfsTWTsbN+nseR1E89pVaB9m2 ID+kebP48MYK+ROFu8vrqsZJxIzAm+KMM48JJ+WVxhgeIKmaEI05AP9UfJFZu7a7PA+R 8DuCdv2GtMvm/5dx00fCDMgzluu5Lu3RgQkNHJ22OJRbk9l1C2SdPqP+G5BvCQrcAj82 Ij6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=RTDlBPpCAWMlCzygNavYra7HGcCrmsHiRs9CyAlwtlA=; fh=MJzvnywV9/WrN/ASipmGkNx/7jKFHnq83nsgXe/obdc=; b=K3BwnQVrHZINmZPddA3sg2RuexkyokxvT67VO83rj/FGEAtbvD7vk0bGNU65qC/qvZ XtxgoumXIVldKLzVFgx5R5BO5roInqb4N1iHUzJBbGnJbSpdboSkcKcn0DE3ZnOgZUpS 8Islr6O2UuEMqXGsLPPKoZZogejUSFFsZiizmuazawMMicdPRdNIB8X7MRAzGNcCB7Bv xcn8vE777hm0ctW6s2YuJqUHSFHAV89ddRfqv1dYmop1cT9PH841TIMRUpHaxLAX+8zl z+S4SRUS0W81LL1d5nWz5OJ+3TFHkLnOdD6fY8Bjh5uaCKhzpu1fRTj/2nsAziLzbVYt yMHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=xEioDoqs; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oy12-20020a170907104c00b009930a6c0b51si1232977ejb.379.2023.07.18.06.39.38; Tue, 18 Jul 2023 06:40:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=xEioDoqs; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbjGRNML (ORCPT + 99 others); Tue, 18 Jul 2023 09:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjGRNMD (ORCPT ); Tue, 18 Jul 2023 09:12:03 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D118A19B2 for ; Tue, 18 Jul 2023 06:11:47 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1689685905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RTDlBPpCAWMlCzygNavYra7HGcCrmsHiRs9CyAlwtlA=; b=xEioDoqswPzTvx1O1yVow95v4FgKlXrTYAmwoJqmnvfz/IDDKv6IAEZedGdDWTKENoi2Bh 0k6DG2hlVzIRaiOAY4X65xo9Ofnuqs1MFEZTLkEP3wULeDUfyoDGdUkMl0ewzLJJPlrud4 n19m9N8aDbliyoBlhu0kdVsr+3mR4OVp9PT8yKvFPatrkXOprSbwjeXW/Kygu4tMoMFLhK KEhqKRHhmwEJzxmsW50PWp+sgmC8eKTX7xpO4VsUrtLyA48sCLI4qX9RnmLaD68lW1BoKb C4v4ag1PUSLVQXK0JREij1DqDPN9jL4JQhUfpzag8QWAyfXf6pjYrVg8BYTktA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1689685905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RTDlBPpCAWMlCzygNavYra7HGcCrmsHiRs9CyAlwtlA=; b=UgxgYQ6yLhsWci2omoxnQEcQH0DaKLxlS5mExNKLwmuY6wj6UW3ScPN3NWyEZ9k8wGskqd sqSTFKNeX+l5PVCQ== To: LKML Cc: x86@kernel.org, Linus Torvalds , Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross Subject: Re: [patch 19/58] x86/apic: Get rid of apic_phys In-Reply-To: <20230717223224.207131427@linutronix.de> References: <20230717223049.327865981@linutronix.de> <20230717223224.207131427@linutronix.de> Date: Tue, 18 Jul 2023 15:11:44 +0200 Message-ID: <87edl5xt2n.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18 2023 at 01:15, Thomas Gleixner wrote: > @@ -1921,7 +1922,6 @@ static __init void try_to_enable_x2apic( > * be addressed must not be brought online. > */ > x2apic_set_max_apicid(apic_limit); > - x2apic_phys = 1; > } > x2apic_enable(); > } This hunk is obviously bogus. I just noticed on a VM which takes this code path...