Subject: Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)
From: Richard Purdie <rpurdie@openedhand.com>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
       akpm@linux-foundation.org, jeff@garzik.org, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <200710252335.12975.ioe-lkml@rameria.de>
References: <20071024155845.5129d6a4.kristen.c.accardi@intel.com>
	 <200710252335.12975.ioe-lkml@rameria.de>
Content-Type: text/plain
Date: Thu, 25 Oct 2007 22:47:25 +0100
Message-Id: <1193348845.5697.25.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1149
Lines: 34

On Thu, 2007-10-25 at 23:35 +0200, Ingo Oeser wrote:
> On Thursday 25 October 2007, Kristen Carlson Accardi wrote:
> > Enable enclosure management via LED
> > 
> > As described in the AHCI spec, some AHCI controllers may support 
> > Enclosure management via a variety of protocols.  This patch
> > adds support for the LED message type that is specified in 
> > AHCI 1.1 and higher.
> 
> Linux has a LED subsystem for that. May I suggest, that you just register
> these leds and let userspace handle them via that via the LED API?
> 
> The LED userspace API is described in Documentation/leds-class.txt
> and the headers for registering LEDs is linux/leds.h under include/
> 
> Since you explicitly WANT user space to control these, that should
> be the right API. 
> 
> Richard, what do YOU think?

If you're exporting LEDs to userspace, the LED API was designed to do
just that...

Cheers,

Richard


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/