Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6861231rwp; Tue, 18 Jul 2023 06:57:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlGGXr2WzDlRF9NtMc5okT1cdtJvRx8uKp7iBvS7Z9PzRc1iNHRYRk0Prp1lGVWudUGf0s9l X-Received: by 2002:a17:906:5c:b0:94a:9f9a:b3c4 with SMTP id 28-20020a170906005c00b0094a9f9ab3c4mr14784924ejg.49.1689688658736; Tue, 18 Jul 2023 06:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689688658; cv=none; d=google.com; s=arc-20160816; b=dZbE8GujX+ScpoSEM4o4VpNW493O0osYHWEMqaELq90h7cH5P2ug0kOXjEoVzchIfR mD6AX/yHUKWsTMTmBaB9k2mnoC0RR15ttzjtJLxvoKQND0w62wcdaj2FuN/d2Inax8pH iAI2v7RKhnc6p0DgsG+hep5wJn3LKq81dNHjnN+aiyPwaO7NrBlqbN3hRtd7ct/7kwdY KbXANUD8BYtPSm8aohEpZEQsMoBIVYvlTdxcocrMKIDdL6kxhVzNE0bH5t8jApCVpGMv Ht3AFv6ZTt3yHLcGf/7HVp8oMMXFRhdMYjOR2Q034rhsXOmkDZKWMn3AZGZ2cCXeKRVh QmUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5yQfNYSq0bTjYFOX+sohFvKHn3gFOyIoGdJBbX9RvyA=; fh=OWPQEfJB79UOkPyeVmLNcbMQAf5S5ug3pRAGVA0cckM=; b=M6tKzIvVMrUh2eoknljZuGA8Eh+ZUz8cfxtVhOJXRQ7AxJzaHlC2t/cfWhQOKG/jyz jQzuUns7bGit1Vw/i2WjGlE5jlqiP3Qw7f5r0b1QPS3agrNQ3wCPbZzxtGygvihloVpO VxJkoRPzs7HksyM0nEwG2TunfOtiWDRoBKYPtSzZmGKo3iBhrM3Rp9LliG4sbXKVuxu0 80ov+iLtdti8rOMNmOisMD+njtiUMFF+/HJmkRvhorF8FWyxInY1oLe4Ub4xFaL/xlmH Iy0wMaZT1pYK8yu2CL0AN7l/Y/K6I8s6xLafWanw++h2bmqG/tH40H4BxGOnD3ld3qs9 sGtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XDW55LDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i14-20020a17090671ce00b0098718777182si1286347ejk.685.2023.07.18.06.57.14; Tue, 18 Jul 2023 06:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XDW55LDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbjGRNkY (ORCPT + 99 others); Tue, 18 Jul 2023 09:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbjGRNkW (ORCPT ); Tue, 18 Jul 2023 09:40:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B6DE5; Tue, 18 Jul 2023 06:40:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDDD7615A0; Tue, 18 Jul 2023 13:40:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C34D1C433C7; Tue, 18 Jul 2023 13:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689687620; bh=/OS496YBy+5JqnR0vuyG56/C1HZH898leTrQ9TTujcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XDW55LDifwdboqgAdNyvB8cOzOLcTbOS++Cifqtau0h2pyx2VurtG8Te69sY7vlq2 hhcMhxYaoqmTWj4StS2t19EVdbUo/T57+38WxqkUqJjL1XYThAp1T9ll2P58cKeBsx vUSkX+d+DkShyNAl/0zcNNwSR6apNQuy69RiyykM= Date: Tue, 18 Jul 2023 15:40:16 +0200 From: Greg KH To: =?iso-8859-1?Q?Joaqu=EDn_Ignacio_Aramend=EDa?= Cc: linux@roeck-us.net, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] hwmon: (oxp-sensors) Move board detection to the init function Message-ID: <2023071808-power-rise-930c@gregkh> References: <20230717222526.229984-1-samsagax@gmail.com> <20230717222526.229984-3-samsagax@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230717222526.229984-3-samsagax@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 07:25:16PM -0300, Joaqu?n Ignacio Aramend?a wrote: > Move detection logic to the start of init() function so we won't > instantiate the driver if the board is not compatible. > > Signed-off-by: Joaqu?n Ignacio Aramend?a > --- > drivers/hwmon/oxp-sensors.c | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) Reviewed-by: Greg Kroah-Hartman