Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6864115rwp; Tue, 18 Jul 2023 07:00:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlFKNnSCDCbOkO+kz1aeEBpf1eiVKAhsTqZ8nhNag4SFttykLI5mjMCUROZLupOzpQXd4b1U X-Received: by 2002:a05:6a00:22c6:b0:668:69fa:f78f with SMTP id f6-20020a056a0022c600b0066869faf78fmr17461658pfj.1.1689688811198; Tue, 18 Jul 2023 07:00:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689688811; cv=none; d=google.com; s=arc-20160816; b=hf3/CxAF5k62UH4ZXo3MrvRZSbn8SX1nSDYtfRWq6MtEVf/gP/JxMDDb5eu/+PKwEv AzdhZnbPdADCRKcbfojxgiiPMozO77DVt0FOYZ+8V5nDNmtmoh16Xc2+pkbVlKFzrKal KN8zfakJTh6E4z3C2xTm46CEUw1d3NWkAYPoV28f8GoAuwrTa+mSuNrQ30TfIwLIwPOQ qHrTBeBK+zY0a5/UDoU+RcSukoZPuYecU64e1oPHhfgQYddunjP/mfZBB6dZg0qduB+O K6eBbkogvz5FbJVxVhdtO/jawJsm7nLsKbCQmA3fDdoo0xmPCogxsCn3m4dL869Q+4vX 8dMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=u67rW3CZx1RukpL4hju2ubMftSjW/WoGxi3f0+QwuI0=; fh=nUEnIrjiQi/zO4ivr0n5U25gaNklW04tJIq3uF+dz9c=; b=upJQhqfE8DBxRwNmAosKjM8+FjjFu1Q/yKXbTfZeJN59rD/nESFhaNk+BHTaEIL/+E 3YkOKc0/kqEb0VS4PIrLdPXi+AozyYQJL3487B9HO+Vwe6yuZyFJkXtD8SI2NIm4E0bt ML3gaiY//wLLIWGKAgr2kKbTzx+sO71t14SXznncTb7qmMy3ny5+5HUZsDW7nxqW6tSG YX8JQ5uXWD7GodEYd7Nc2sZPLnViAEBR87SD6HcGiKVCEjC8MFhTgEBn5QpLyb53N9E/ A6d5m7XmsfuZxfJc6KoLI973uOlLNMZm8vVfBkqZqsoY+6riVP0lPu3Z7kdvaHdbM/Rk /JPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=D9pzTJmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l129-20020a633e87000000b0053f212830aesi1578924pga.311.2023.07.18.06.59.57; Tue, 18 Jul 2023 07:00:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=D9pzTJmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232892AbjGRNvu (ORCPT + 99 others); Tue, 18 Jul 2023 09:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjGRNvt (ORCPT ); Tue, 18 Jul 2023 09:51:49 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA93E5; Tue, 18 Jul 2023 06:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689688308; x=1721224308; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/ek4HQDqASP1346ScIwRLDWKoFoS68Rokb5r5BxIupU=; b=D9pzTJmiotiBgdPXEw+LM9Hoo0YTi4nWzttl9/AS+vDDdb9jgfZpzWlx KC0A5O7oeAkDP9eptyFwDuTFh9lB+yPa8X5wRr26lF/J3tdxkuVpNMDJt lhPNJ1JsXqjH80ZULlvU0FwWQd/0i6bQQe1o82p0EMUbTlglujlXXM0w2 LBxjqx7B6HoE1Hf9QDMCoNT7VD1c4CrfHPGLPtJyX3nKfK/XzyGVFuT81 dAV/5PCmZhFGOZ5G2AHYGEtl+Rv5v7RsGQzulo9KDOAWSXPB63CSd82UM KhlpsTnFxv+Qo8PmkqGTT2DzFFdiPSUbUMRzRIdhDi5Ajc3VQpF101Zlw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="345803138" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="345803138" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 06:51:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="847707771" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="847707771" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 18 Jul 2023 06:51:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLl74-00FrDv-32; Tue, 18 Jul 2023 16:51:38 +0300 Date: Tue, 18 Jul 2023 16:51:38 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: Mika Westerberg , Linus Walleij , Balsam CHIHI , Claudiu Beznea , Geert Uytterhoeven , Wolfram Sang , Thierry Reding , Paul Cercueil , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, Andrew Lunn , Alexandre Belloni , Len Brown , "Rafael J. Wysocki" , Gregory Clement , Sean Wang , Jonathan Hunter , Ludovic Desroches , Pavel Machek , Matthias Brugger , Sebastian Hesselbarth , AngeloGioacchino Del Regno Subject: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper Message-ID: References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> <20230717172821.62827-4-andriy.shevchenko@linux.intel.com> <20230718105453.00004dc3@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718105453.00004dc3@Huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 10:54:53AM +0100, Jonathan Cameron wrote: > On Mon, 17 Jul 2023 20:28:14 +0300 > Andy Shevchenko wrote: ... > Reviewed-by: Jonathan Cameron Thanks! ... > > + static DEFINE_NOIRQ_DEV_PM_OPS(chv_pinctrl_pm_ops, chv_pinctrl_suspend_noirq, chv_pinctrl_resume_noirq); > > Very long line and readability not hurt by breaking it. Sure. -- With Best Regards, Andy Shevchenko