Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6887543rwp; Tue, 18 Jul 2023 07:13:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGVotAzRxn8pqiMIqs9QVkd32DIu2bqPMXDBKuCA3KNLbQcoAK/LZW2lzC+1b2omjzjIk6N X-Received: by 2002:a2e:8059:0:b0:2af:25cf:92ae with SMTP id p25-20020a2e8059000000b002af25cf92aemr11527158ljg.22.1689689629673; Tue, 18 Jul 2023 07:13:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689689629; cv=none; d=google.com; s=arc-20160816; b=NcTnlsgJ1WqlbxiTeINEOjufWabB3N7hsHPpo4q9KbDMpma7SZuMOUagRkRkEAqHUI 4Mn4wVOL2gYvh6zXgjKNMRfRqaLx/7wQKFKKxod5vq+gdayj4kqYJU3wkxoWB65PKMEO FEhi3cyQCdQjmzqHXTNVkB+CYd9ShxdVKCmTmDISBS2fA5FNTst05eFMWG6bZs5YPImP ZOCcWSoMarv7N4xiBQJDFzezBtGLaNqKV9CpDq6aZGkluzmDFr9Y6FCN0vFM9i+Vui8w juSw+eZcfwr8+o0Xjr+Z4BcZGLD+nuzKcaueihs1llxgPsg5TxopFrHGr2eljec9D6A4 MglQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=26kZNX589C4iel7QXWfs4d6fvzGm1fUt/wLrbSdfcEM=; fh=22sD9iy7Udn9d8wSjV6oU9uolEy9sA5ezGD+3/nUsnA=; b=OmEHDwSXzyKL/AXzvtCoYcTPVGCKb7VeXGQrgiqqSq3KAzLbUvOhU8jooy3SgPBum5 /ZMYCwoujcwBttKC0VTlNQlzBHJ0Dzzl3USNsV8glTvOXMB7Dmww8FGmB49asw81GNNR li8ZmmiuxIuCoAYa4d+h6isbmeLU5agsi9qfYcOFzJ2Yc+BiQESSTSRa6YaJAZ/6hPE1 IdkmSvc9K4TO/0wisGuK5CNRVLlATkzFujn7KC/Hqk8heraNhSbPApb+NxivSEvbFI9L 7u1sS2xscBd6VY1wzaJlpG2B8TI5xizli6PTV3fazeHiqtI5VjE5/aiQgq0p8kzTItZ6 S7uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hWHpHNHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a1709060e8b00b00988a0d78152si1290567ejf.55.2023.07.18.07.13.23; Tue, 18 Jul 2023 07:13:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hWHpHNHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232546AbjGROIi (ORCPT + 99 others); Tue, 18 Jul 2023 10:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233133AbjGROIg (ORCPT ); Tue, 18 Jul 2023 10:08:36 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F08D912F for ; Tue, 18 Jul 2023 07:08:33 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-993a37b79e2so776436766b.1 for ; Tue, 18 Jul 2023 07:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689689312; x=1692281312; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=26kZNX589C4iel7QXWfs4d6fvzGm1fUt/wLrbSdfcEM=; b=hWHpHNHOn2baysENIVLRf3Put9jo2livos4yKD1QUrzec9GAQZWc4SOIr0oRVt2g5+ KJ5iafB8yWfAsQovCftGxuIAqn3feQblOqRX/ZATiXJA4Kb6hOvg/MMcNo20SNVry1YJ dR64HQqqj6B9GXDq2cBb6XpBwaoCiloqqXVmPh6Eo21URVexP/vfvJ0qJuDabC/1FOVK 37Foib7LnsnpNlG4DHBi1MH/VwoBpyJBjm3Gv2Po7d71DM1r/9sbkhpTGSn9hrjhICZB TE3UkNn4+hMXK1So46SkCIeSTcJoeYwGXj7bY6I5l9jfMj6tLNQ1ggkncuS0hCM1rYkW mPEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689689312; x=1692281312; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=26kZNX589C4iel7QXWfs4d6fvzGm1fUt/wLrbSdfcEM=; b=UgDNjC1kMQnAxRusYK4Ndfd775R16mnJ9yy6vF8q0Gf0lGe8XenNe0KdFhB488C1y5 Q0gAe5sRgOVDRSk86G8De0CcaD43JDl8g8mwIE75F0AZB1W9uHp6u1/4wrNXLAGoVyZB CyPC3t16TXBYiDzq2ngTBL+KKU+QDpSD5dglKFcXeWow9DcYMcqeGm51I3XMTp/gVg7P J6T7gfdYzg1Qk+eLBHwZsJ6yyR/MTL+ge3SXgKcc6KNduUSiveEh6BwmEA4VKukGUUjn kv8njAanP+F8DxGsLuae8oiiuQ0Z37rvRmJLbM6M0biPom8XHj+FT08loeoTD37RPoFi OhDQ== X-Gm-Message-State: ABy/qLbP6DcujqXxOq67f/wQBT/ZMlrSJPR4R+Unq9tLWAAH6XSlTjlI VJk6aaHX/leBYunJg6zJVjDsCA== X-Received: by 2002:a17:906:5a45:b0:977:95f4:5cca with SMTP id my5-20020a1709065a4500b0097795f45ccamr13185377ejc.54.1689689312367; Tue, 18 Jul 2023 07:08:32 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id y12-20020a1709064b0c00b009929c39d5c4sm1086470eju.36.2023.07.18.07.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 07:08:31 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 16:08:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] arm64: dts: allwinner: h616: Add Mango Pi MQ-Quad DTS Content-Language: en-US To: Matthew Croughan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230718124752.1279094-1-matthew.croughan@nix.how> From: Krzysztof Kozlowski In-Reply-To: <20230718124752.1279094-1-matthew.croughan@nix.how> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/2023 14:47, Matthew Croughan wrote: > Mango Pi MQ Quad is a H616 based SBC, add basic support for the board > and its peripherals > --- Third email within few hours - no, wait a day. There are so many issues here that sending immediately won't help you. 1. Missing changelog, so did you ignore entire feedback? 2. Missing Signed-off-by > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h616-mangopi-mq-quad.dts | 183 ++++++++++++++++++ Yeah, no bindings patch, so you did ignore the feedback. Sorry, that's a no. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof