Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0bd7caa5-8f04-8787-1e72-93ecb71b8197@intel.com>
Date:   Tue, 18 Jul 2023 15:44:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] lib/bitmap: workaround const_eval test build failure
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>
CC:     Nick Desaulniers <ndesaulniers@google.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alexander Lobakin <alexandr.lobakin@intel.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Nathan Chancellor <nathan@kernel.org>,
        Tom Rix <trix@redhat.com>, <oe-kbuild-all@lists.linux.dev>,
        kernel test robot <lkp@intel.com>, <llvm@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20230717220435.57640-1-yury.norov@gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230717220435.57640-1-yury.norov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG9GSUJ3VWNBR2F4NllnWFpwSFpLUWR2c3hJNkY5U1RaT3pMc3hwZ3hjRlJ4?=
 =?utf-8?B?alhWd29sR2toaTk1aHZzNlJsK0VEZS95QjU5aGtnS1VORTJSS2JZSGpYVVFR?=
 =?utf-8?B?dEVRbjdVYjg0Z3hENXB2OTNBUVprUHY5SmtURDQvQjZLNHNFblNQZTNtdHpm?=
 =?utf-8?B?Qk5kTXZyazk3RmcwNjE5U2NlaitTNGNjaWNodWxCcDBUL29LMHJsWVpkMnJV?=
 =?utf-8?B?em44cU1YclBxZTVhNXBJbXlqbTlKTE9VTVZlNEdmUVJhVkpQa1ZwWUxrVzZ3?=
 =?utf-8?B?S0dzdGd6L3RXTkVrbDVCQ3FhZG56ajlwaEpPQWtaZ0hpVlBjY3BMTFlaTGFq?=
 =?utf-8?B?dEVvalZYSzZFRFdGVmNNNmVCbVA2UXlWV08vWDVlMWhheVBUQkdYVU9tclVn?=
 =?utf-8?B?cnlhOEV0RlRLNG1lV1ArbHdNL1B5bkREZXRWSlRnQ0xaR2oyZEJFOTRIZU1K?=
 =?utf-8?B?S2JiY2E2WGUvVHF1K0RUc2NzcXZ5SE5paksvMjlpRmRtWkZxMk00TFZwZFBj?=
 =?utf-8?B?YWFlNE5IanBLY0N3Qnp1cmhlcHl3MWRLZkJNTUlRdTMvdzdiVWtRLytEWFNZ?=
 =?utf-8?B?bm45Z0lFY1N4ejROZUhCQmUwV0NBRUlqUG03SnltWXI4Qk51SWFwelp2c3Rn?=
 =?utf-8?B?RkhucU9SRlZKQmd1ZHczUE9NRmp2ZkhHcmxXamJiWU9nNC9JQVNPUzZiSDNJ?=
 =?utf-8?B?QTduaXcyYklWYlZhN1VyK09kcGdwVFpWalJ5SFRYMlFrZlhiOUJSN09YQjlR?=
 =?utf-8?B?ZEZtQ2w3eEdONGw1T1R1L21QeGgxS0ZLOWpnM0FlM3VSNXlUclZtMnhid3Vy?=
 =?utf-8?B?WU05TTZYdXFTcDNrNWF0Tkp0dG0wOEhZaldXeGZBTC9EcVMvYjVZcktqWlhK?=
 =?utf-8?B?MHRBUExwa0tmVHhMdkptSU9VQW9XQ2tPMndRQ2ZDcWh1UTVscjBnTkdqZG9m?=
 =?utf-8?B?Y2RYc01lUUp5ZU1RYStVdUovVnh0KzlmQTNxbFhpbFFZNzFCWFlqMUVBN0Nw?=
 =?utf-8?B?VGJSWXltTlhuTittZW1OMkw2VnVmaG90Mnc4UU1ITjFpWHFsWVJhdGI0Q3Zl?=
 =?utf-8?B?L1lnaGRXNTVJZlFveG5rNWJaQmNOUFFpMDVFenVkS2pVUFdWZWFXNk5wN0Fk?=
 =?utf-8?B?Tis4eGJZSHV1Y1ZRSytOUFFKTnFaSEtTTTNTenFGVjREWUxWelFZb0U5dGoz?=
 =?utf-8?B?a3NZRzRwcjdEdERnUkxzZnNpUkkwa3JUbGVwaHR6dXZjd3VqR3hlc2drV0dN?=
 =?utf-8?B?Vy9MUUtVT0wxTS9UMW1FMG54NWxKaDZCUnNiZ0pCMTU3MEpocHdrZVpFTHRD?=
 =?utf-8?B?eWI2bUpBVzlXaXlZcGJPRWxyUVEvWklrcDdaclV6TFcrZDVPWTlLMWdta1VP?=
 =?utf-8?B?cXY0SkhKZ0o2WFRsRFo1STYwQjFNa2E5TFlLTEl3R0llS0FwcCtzQ1Avd1Nv?=
 =?utf-8?B?ZUowa0RFZ0psK3ExNWpNejkxOEMxa2dHaGZhekpNVHMwWDcvbEI1S0IzRlow?=
 =?utf-8?B?TEZ2RWp5SE9UY083aU5WaHY5UVNLRzFkWFdQN3RNMmswaWhtSXQyd3hPZkp3?=
 =?utf-8?B?eThhQ0VZK051TUp1cHE1aGpWeUE3dG1pM01QQ2RuR0lkYi9KZkYxTHNqWVFF?=
 =?utf-8?B?OUhpR0NFNTBLRzF6NVk2bzRUdy80K0duRW1wUWZmR1A4V1FTcEJaZXVoalNO?=
 =?utf-8?B?RHhBd3ozay95YjRvQTFaVDEzV1hFOWJSd1JyYkFJeE1CYmVTUkl6T3o3U1BV?=
 =?utf-8?B?NDU1NGc0TlNSWmRnTzgrNDFVVjZGa0NkSVFUSW1FY2tvd0lqSGtTNEVHMEFs?=
 =?utf-8?B?T09yTVVrKzU2Z284ZzdBS2xHcmVzVXNqWUNzdVA1eXVoUXcyV24xWExGNXBQ?=
 =?utf-8?B?Q2lSY3hhTUYzK2xkaVp0djg2UzdTbUw5S3V2TlYyQm1lSW1pVWtiMkY3bHNS?=
 =?utf-8?B?dDRsb0xRR1R6MlVnVEV4MWxNMm50a3FQbkhUSXp6UjB4dzNCQjZnc2ZMNzJW?=
 =?utf-8?B?aFcrcHppbDlBNzloSUNBWkZzR09XNk1CYzZUci9yUE1zejFUaXR1aXoxVnZO?=
 =?utf-8?B?d0VrZDhxY0VsbXdpS2FHVkRWdHR0ZTZvK2xFWFNqTGQwR00xQXhmeXNyZ29E?=
 =?utf-8?B?aVFBZUY3cnZzTUF0amd3V0lPcWhXbWNxQjhRaWtteDFkelpYTXVoU2NjN01x?=
 =?utf-8?B?c1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: acc4cae0-6387-4fc4-e14d-08db87954789
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 13:45:42.5547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XCYkiA83T3rpukOF0LWcUGHg1zRwv92y5KVaSjumE/AHjBnAPU9CL/KygVT+ywryOU539tItYgjnA2nm5P2oVE3Buhky7Gu3Qt/unqTnWJQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6976
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yury Norov <yury.norov@gmail.com>
Date: Mon, 17 Jul 2023 15:04:35 -0700

> When building with Clang, and when KASAN and GCOV_PROFILE_ALL are both
> enabled, the test fails to build [1]:
> 
>>> lib/test_bitmap.c:920:2: error: call to '__compiletime_assert_239' declared with 'error' attribute: BUILD_BUG_ON failed: !__builtin_constant_p(res)
>            BUILD_BUG_ON(!__builtin_constant_p(res));
>            ^
>    include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
>            BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
>            ^
>    include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
>    #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                        ^
>    include/linux/compiler_types.h:352:2: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>            ^
>    include/linux/compiler_types.h:340:2: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>            ^
>    include/linux/compiler_types.h:333:4: note: expanded from macro '__compiletime_assert'
>                            prefix ## suffix();                             \
>                            ^
>    <scratch space>:185:1: note: expanded from here
>    __compiletime_assert_239
> 
> Originally it was attributed to s390, which now looks seemingly wrong. The
> issue is not related to bitmap code itself, but it breaks build for a given
> configuration.
> 
> Disabling the const_eval test under that config may potentially hide other
> bugs. Instead, workaround it by disabling GCOV for the test_bitmap unless
> the compiler will get fixed.
> 
> [1] https://github.com/ClangBuiltLinux/linux/issues/1874
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307171254.yFcH97ej-lkp@intel.com/
> Fixes: dc34d5036692 ("lib: test_bitmap: add compile-time optimization/evaluations assertions")
> Co-developed-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> ---
>  lib/Makefile      | 6 ++++++
>  lib/test_bitmap.c | 8 ++++----
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 42d307ade225..1ffae65bb7ee 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -82,7 +82,13 @@ obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o
>  obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o
>  obj-$(CONFIG_TEST_PRINTF) += test_printf.o
>  obj-$(CONFIG_TEST_SCANF) += test_scanf.o
> +
>  obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o
> +ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy)
> +# FIXME: Clang breaks test_bitmap_const_eval when KASAN and GCOV are enabled
> +GCOV_PROFILE_test_bitmap.o := n
> +endif

Oh, quite elegant!

> +
>  obj-$(CONFIG_TEST_UUID) += test_uuid.o
>  obj-$(CONFIG_TEST_XARRAY) += test_xarray.o
>  obj-$(CONFIG_TEST_MAPLE_TREE) += test_maple_tree.o
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 187f5b2db4cf..4a678de9c350 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -1161,6 +1161,10 @@ static void __init test_bitmap_print_buf(void)
>  	}
>  }
>  
> +/*
> + * FIXME: Clang breaks compile-time evaluations when KASAN and GCOV are enabled.
> + * To workaround it, GCOV is force-disabled in Makefile for this configuration.
> + */
>  static void __init test_bitmap_const_eval(void)
>  {
>  	DECLARE_BITMAP(bitmap, BITS_PER_LONG);
> @@ -1186,11 +1190,7 @@ static void __init test_bitmap_const_eval(void)
>  	 * the compiler is fixed.
>  	 */
>  	bitmap_clear(bitmap, 0, BITS_PER_LONG);
> -#if defined(__s390__) && defined(__clang__)
> -	if (!const_test_bit(7, bitmap))
> -#else
>  	if (!test_bit(7, bitmap))
> -#endif

...and even allows to remove that ugly piece.

>  		bitmap_set(bitmap, 5, 2);
>  
>  	/* Equals to `unsigned long bitopvar = BIT(20)` */

I like this version the most.

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Thanks,
Olek