Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <109990fa-fb67-48e2-6424-37ce47cf68f7@amd.com>
Date:   Tue, 18 Jul 2023 15:59:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] dt-bindings: reset: Updated binding for Versal-NET
 reset driver
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Conor Dooley <conor@kernel.org>,
        Piyush Mehta <piyush.mehta@amd.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        git@amd.com
References: <20230717112348.1381367-1-piyush.mehta@amd.com>
 <20230717112348.1381367-2-piyush.mehta@amd.com>
 <20230717-explode-caucus-82c12e340e39@spud>
 <ee81e955-32be-66ea-377b-263ee60a2632@linaro.org>
 <e8f48a30-9aff-bc2f-d03f-793840a192c9@amd.com>
 <694a1314-0b25-ff5e-b19f-5a0efe07bf64@linaro.org>
 <cae162d0-843d-ca1f-80d3-5a0dfe1e3d0f@amd.com>
 <22e7dc73-2411-5cb1-6cef-daa5f2af8297@linaro.org>
 <5c45d89b-00c5-a330-2e1f-b99043736527@linaro.org>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <5c45d89b-00c5-a330-2e1f-b99043736527@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2dOWXcwSFF3ZUdkN2JLaVFvaWlZaDRJaWFsM2lpN3JnU1RTZTNYaVdaSk9F?=
 =?utf-8?B?TjZzMndMQVZ5TmZHVGlzK090Z3FuQXJhNHg3bnp6UEhLcTVoZlVzRnZ3ejgz?=
 =?utf-8?B?aXVZOEtQUWxSaE8zUktGZkNmVmNUc1FKOE9GQXRKc1BlRXRHa2ZpY09YOGNH?=
 =?utf-8?B?eGRmVWEyUnZFQWV3S0tLdWxxSmhQVVlUNTNuaXg1VTBTd2NMVHhXSHZ2U0NM?=
 =?utf-8?B?V2RFQmgzd1lMQkJ4aHFxcS9sUVRVcmh5T1hyTWdGcWhmblg0MzQ2Tkhrbmkx?=
 =?utf-8?B?Rkhqd3dvalR5Q3hHMzdSd3lvMXlvYW9pdXpkNGJuVGlwMDV3MUdyS1pVekEx?=
 =?utf-8?B?dzVVRVAyZ3hFSDJlekE5VXMzSnpoV0ZpSFRRMjVEdjhVM09pVFRmT29qL2FX?=
 =?utf-8?B?TFZsbEZBOTJTVmtzTFQwNno3TnZKTDNDdlk4eDBkWXJWdy8waXExTDdYMnVT?=
 =?utf-8?B?MXVMTXhpZWxuTWU0dGdEdFNteFlLZFY3SnkxTEFvZkN6M3QwS3prQXFoanY5?=
 =?utf-8?B?RDhlcU5EVk1CZ3AreDJhOXBjd0FiNEJucW80S2EwazlITFZIRnUrZzNESmVC?=
 =?utf-8?B?bE5aeUEwY3grR2tTZ1dHcTNzZHk0a2tkaUZvVG5iY05SZStUMERQczBBNFlQ?=
 =?utf-8?B?ZDQxejdiRjZ0MEZtR2ROZXNLckErMzQ3VmtVbGhJVU1NUkpuUXB2RGVBZE1y?=
 =?utf-8?B?MXhIYS9BRzY2ZHMvOWpXZUhrQ21YRWtTZzJndWNDOFRCM3JULzJlU0pqZ1VC?=
 =?utf-8?B?dEpoc2gxalVNckF4MWROS3lmQy8yY3BVR2duL0J6SWRJNUVEWmk1d1Y1UFE0?=
 =?utf-8?B?Sk05RVlveCt3TUdTSkZWVGt6Si9vNG16Slp5cDB4OXY2c1M2N0RTcG1pZ2xC?=
 =?utf-8?B?cjMyc2VPa1NORVFYbU5WM2RlcWN6R2lUaWs3aERDUVBqRld0alBTYnFBMFI2?=
 =?utf-8?B?dWtZZWpFYkIxTWRLY2VTVlUzQzhGUG1WcFJEbjJEWHc2Z3BqQlRtcytnemdJ?=
 =?utf-8?B?dkNQd1pSS2lObDVIZm5tUU0zK1hQSWV2aUFqZXdLQ1pMM2lOMWsvcmFDMld4?=
 =?utf-8?B?WlNwOHQ5cUREQU1vQUVRRHg0MzRyRzhyTU1JZjFJVGxNL3dFVXNOUDhrbC9K?=
 =?utf-8?B?ZGVZTlZkYU9lQk5IaWxjQ2JWdUgwMUdzdEk1TTBLSkIxY2ZqdkpZZG9CVFlj?=
 =?utf-8?B?bngzNU93RjVEZG13VDJlWjlsY1o0TitqOXdyRXdkaFFPNzEzbmwwNzB1Nkty?=
 =?utf-8?B?SzNWNW9uMXQ5TmRQWnpuRlNDZ3cxelZVMEZwc0g5MlgweXhTSlFFdXErLysx?=
 =?utf-8?B?TVdQaWdWRUN6S2ZibTBFZXp3Mk5xblpDeE4vV0x3QnZBRlJjUXBYd1o2eDc3?=
 =?utf-8?B?ZHhEemJzbm53Z3kwdEVEbUNnR01xSkZscVp6OG9xWWJCRWpMc0MwdEpJczd1?=
 =?utf-8?B?WTNXWmcxOE81c2YwV3oxRG9sUnlQL1hnS2ZEdjA3MEQvdkIzYTdPU2IxVStk?=
 =?utf-8?B?VVIraUgzNG4zS1N4K09taDNuRGRGTGVmeFdmdUFWeENrOE5hU0V2R3BaU1hx?=
 =?utf-8?B?cTh2MmRJaTkra0FXY3pjNkRJL1BvNWpydzdIb21tMGtUT1hXTHhxc2xsUG1Y?=
 =?utf-8?B?SE5ac08weXd4V0R5RmtVMU5aSEN4RXJYWm4wZFhDRndjUElSSFV6OE5XKzlT?=
 =?utf-8?B?ak1SQUkwbmYvMXBRM2JDUUhqdWUxNklVWkxzQ25xMzZ5SEJRSElXTGFPbzJO?=
 =?utf-8?B?ajZRWTFRcmhMZ05FV1lJY0VBbEdYM2Rqb0VVL3BnZHF5WHoxbDB6SWtLVDhj?=
 =?utf-8?B?K0RybC9tRmk4SXdiSTdHWUFyMHpzN3NJY3VlYmkvOFN3aXJya3pWV2x2aHd2?=
 =?utf-8?B?VnE0bXk1aG9sRVFQb05abzY0Y1dzSFhicHBtYnhVcjNQd01VcjJ4em02L1ZR?=
 =?utf-8?B?L1VTUEk0c3lYOGpENFNTNXBwNXFEeWFZVHhlckhETGZZdFFTTGtWdG1EUmEy?=
 =?utf-8?B?eFBDNHpzR05maEtCQlRabmlTbUpOWlJCS0hKN1JRV3dEUGlKVThWNTZmYW5C?=
 =?utf-8?B?bnV5YmlncStJSWhSK2lCN0J5YXptbThvSlRKWGVySVd5bUU1b1VFTld3aWpj?=
 =?utf-8?Q?c4Ab0D+4hjub4Sk39MVj10E7u?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4ed501-5d74-4e4d-5706-08db87973ffb
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 13:59:48.9520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vIHTBwpBVj6IZ1P3eKzyfJ2SmPOj8cHw2HjtqaD6rVtFzcRdDGeynx5MLyztWSse
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6057
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/18/23 15:21, Krzysztof Kozlowski wrote:
> On 18/07/2023 15:20, Krzysztof Kozlowski wrote:
>> On 18/07/2023 15:11, Michal Simek wrote:
>>>>>
>>>>> That numbers in DT are virtual no matter if you use ID from 0 to max or random
>>>>> values it is up to code to handle them. Checking nr_pins against ID is done in
>>>>> core but it is up to drivers.
>>>>
>>>> No, you confuse "virtual" and "ID". IDs are not virtual. IDs are real
>>>> and have representation in Linux driver. You do not need to define
>>>> anything virtual in the bindings.
>>>
>>> Not sure how you define ID itself. But HW doesn't know ID. HW knows only
>>> register which you can use to perform the reset. It is not really 128bit
>>> register where every bit targets to different IP.
>>>
>>> And this is SW-firmware interface like SCMI reset driver.
>>>
>>> Firmware is saying that ID 0 is QSPI, ID 1 is MMC.
>>> Their Linux driver is asking for nr_reset via firmware call which can be
>>> different for different SOC and that's fine and I have no problem with it.
>>> But only SCMI server is dictating that ID 0 is QSPI and ID 1 is MMC. Different
>>> SCMI server implementation can map it differently.
>>
>> Sure, and all this points to: no need for bindings.
>>
>>>
>>>
>>>>> In our case that IDs are coming from firmware and driver itself is just matching
>>>>> them.
>>>>
>>>> So they are the same as if coming from hardware - no need for IDs.
>>>
>>> It is hard to say what hardware here exactly is. From my perspective and I am
>>> not advocating not using IDs from 0 to max, it is just a number.
>>>
>>> If my firmware knows that QSPI reset is 0xc10402dU then I will just pass it to
>>> reach my goal which is reset QSPI IP.
>>>
>>> If you think that we should use IDs from 0 to max NR I am happy to pass this
>>> message to PM team and we should extend any SW to do translation between.
>>
>> When we talk about IDs and bindings, we mean IDs meaningful to Linux.
>> Whatever is ignored by Linux and passed to anyone else - hardware or
>> firmware - is not a ID anymore from bindings point of view. It's just
>> some value.
> 
> And just some proofs:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/reset/xlnx-versal-resets.h?h=v6.5-rc2
> $ git grep VERSAL_RST
> Results: No users.

I know this. I should likely submit one DT for Versal to start to use it.

Thanks,
Michal