Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <364507a5-ea2e-6280-cc9e-394e09d6edf7@gmail.com>
Date:   Tue, 18 Jul 2023 07:39:39 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
Content-Language: en-US
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Cc:     Biju Das <biju.das.jz@bp.renesas.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
References: <ac8d6190-06ae-b538-1293-07efedbfe94e@gmail.com>
 <TYWPR01MB877550F95CF000B63E9AD022C238A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
From:   Randy Dunlap <rd.dunlab@gmail.com>
In-Reply-To: <TYWPR01MB877550F95CF000B63E9AD022C238A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/18/23 05:13, Fabrizio Castro wrote:
> Hi Randy,
> 
>> From: Randy Dunlap <rd.dunlab@gmail.com>
>> Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
>>
>> From: Randy Dunlap <rd.dunlab@gmail.com>
>>
>> When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build
>> errors:
>>
>>
>> Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is
>> still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built
>> but also allow the latter not to be built.
>>
>>  drivers/pwm/Kconfig |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -505,7 +505,8 @@ config PWM_ROCKCHIP
>>
>>  config PWM_RZ_MTU3
>>  	tristate "Renesas RZ/G2L MTU3a PWM Timer support"
>> -	depends on RZ_MTU3 || COMPILE_TEST
>> +	depends on COMPILE_TEST
>> +	depends on RZ_MTU3 || RZ_MTU3=n
> 
> Isn't this a tautology?

Not at all. It's used in Kconfig quite a bit.
This is tristate logic.

It says that if RZ_MTU3 is y/m, PWM_RZ_MTU3 is limited by that.
But if RZ_MTU3 is n, PWM_RZ_MTU3 can be y or m.

Is that clearer?

-- 
~Randy