Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 16:42:51 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Lee Jones <lee@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Mark Gross <markgross@kernel.org>,
        Tobias Schaffner <tobias.schaffner@siemens.com>
Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver
 default on platform
Message-ID: <20230718164251.13855c47@md1za8fc.ad001.siemens.net>
In-Reply-To: <ZLafwOPrw+puH+rF@smile.fi.intel.com>
References: <20230718105213.1275-1-henning.schild@siemens.com>
        <20230718105213.1275-2-henning.schild@siemens.com>
        <ZLafwOPrw+puH+rF@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o07JvmlNdhxsshoFhe/gli77C9hnFjzRO35J+3ZzKB3vee0Ui1hLNAK7gnrt?=
 =?us-ascii?Q?gK0ruesPumHGio+EcjqeEPjogkD+YiDjQJolyggKkbsLwKhbBdXqmA4FDQLd?=
 =?us-ascii?Q?gZ3/ZZ10SYChZChY9f1/Aogj6X6wqQ8r+nLMzDOZQesW/n77+D+wF0QNwi9E?=
 =?us-ascii?Q?XD72NQ8Qvn+10IGvwbdH9uGqf8Y3A8K9M809ENiTWBkSFrRMARXMFS4ou04C?=
 =?us-ascii?Q?wI/cxxXwqv+MPtcIWHuexcNHE+ZJvexA/Ogl601Ur4tgJRQowbXWgEdrBsj2?=
 =?us-ascii?Q?AkVgmwlLnLvxDuQT+84BCnuzIk/MIrafPAccdNZ5jCDwFhhFLTsYj98lxAiZ?=
 =?us-ascii?Q?qah0Se0Fz7hHuA+u+sAEsUxrklgYfYkaYxJN9BjzfaeTRN/k+P90vKiociqy?=
 =?us-ascii?Q?HhUTafLVPsJcoHEfd5mgLjXLQTezAn7atVn/WkZhX9yzAc9HeWXLCNLQmo2J?=
 =?us-ascii?Q?Idsjvpe6DEm8c1kwVtX33gGtPlovEVclwYzvxrnrzIoJFB1VSzU8j7Z3gjbR?=
 =?us-ascii?Q?Eah6TMSaqSx1YUlYQuCH/lsiuyustut0EpahOv5s0l0RcWqJGYQ6/e3A/C2Y?=
 =?us-ascii?Q?AoVY6NdfZ3dcgTAK8ZUQr9MQWm8Mv9wNuPw7CFCbTzkyBAWatElqs4EFhztb?=
 =?us-ascii?Q?pUNqCWEFxl/glkJgWRNwTkXq9n5Nub9zPPYxB2KRWjPUXYRiQ0Zetuxy+1Vh?=
 =?us-ascii?Q?pBI1HhgUMZtKAygRC15+8r+u9+LPkNeI7xhxg55L4v11yHecK9uNulsPLx4I?=
 =?us-ascii?Q?VPTKYH9ew8uSx2v5QzcIiJi/dOgnMQrXmyb7EFgyvoFzlhiXm7Ib7VTaQHIB?=
 =?us-ascii?Q?Ixx5aHh45cS4lVeqFnV1ifKMzskMWeqGUKJrAhg7ATm7NV3Ab5HjV0XpY7w9?=
 =?us-ascii?Q?deH7SvkPpcL4yLSWutdnitSlMkfUet2WnomMe32aJ86nGqZhmus5heVEiyWs?=
 =?us-ascii?Q?3SAZVyiV4zL2hGtqB/l/+LTHUbpDuUjSIl4SHz5/tWmiMz5R6oEiN/prwXJp?=
 =?us-ascii?Q?32HAb4J7RnuPgtqTKW9AeDCx+APcz1XEXAAdDI7bJ7TgH6F6EQrKvuX7swqW?=
 =?us-ascii?Q?pY4v6zgWXaL/2BaJbn+CjNhyBXg/4j6SZ4tp49n+RWyhfD0rzGKbR3ck7shV?=
 =?us-ascii?Q?mMOjXX8q8QV+o4pkS8gV/gAE7DbfP8+nhsCLGqth8tv2aCrmumEd1Yhw3TdI?=
 =?us-ascii?Q?SLA4Aa6BK+n3o0rcJG0TuwwqhpqwxL33UTXBPfNxo9WV6zI+Llb7D0G3lIWx?=
 =?us-ascii?Q?mpYBKGl71nTQJU/0ndGw+g6awu3DVvRMalPyh4AgNvWO4CsCKBXZUE8vRXZV?=
 =?us-ascii?Q?I5KwN3ppAJLwx89Puy4dlnv3zkyc+IbKokomHSAmGsT+kCHXCM6gc+BTnOoa?=
 =?us-ascii?Q?zkbuco7Es5lGSNfKQQ+d3eTYSLT675+7QfzETs41ahLrzqX+4V+ifHlLxPcE?=
 =?us-ascii?Q?koRaxa0TtXEEbNCeuJRxXVAhThOvrHwtV6axzhanlSzNQ7dKUKBczz85l0O8?=
 =?us-ascii?Q?L+6ch9COvcJ8qz5bGn2Pa+bTFrNzpTGpeQ57YSw0bYx0Dbtx0ExVTBiCTd/D?=
 =?us-ascii?Q?JN3+curquX3nGqIek0naNSe5puGabxZShWJTMRgssgeXOCnBva5bMg+Pv4Jn?=
 =?us-ascii?Q?RD8IdhDg8X2ibQANtvbLgltynmk2sYWoeLuPMMbZahRbwgTpl+VHRZA8V8Nh?=
 =?us-ascii?Q?fB/ZBQ=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef3e3028-af24-4f67-d8b3-08db879d4698
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 14:42:56.8957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DFEXqdWCCCYNoDiXNlkL3pMxYGyA25tt9N4W4FhO6h/vsztNnKIOfwCgn2kZohDHm3AwS/rUjGLhpu0ybrd20KBNHm7ON9+CitMq3i2TUMI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB5913
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 18 Jul 2023 17:20:48 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> > If a user did choose to enable Siemens Simatic platform support they
> > likely want that driver to be enabled without having to flip more
> > config switches. So we make the watchdog driver config switch
> > default to the platform driver switches value.  
> 
> A nit-pick below.
> 
> ...
> 
> >  config SIEMENS_SIMATIC_IPC_WDT
> >  	tristate "Siemens Simatic IPC Watchdog"
> >  	depends on SIEMENS_SIMATIC_IPC  
> 
> > +	default SIEMENS_SIMATIC_IPC  
> 
> It's more natural to group tristate and default, vs. depends and
> select.

Will be ignored unless maintainer insists.

Henning

> 
> >  	select WATCHDOG_CORE
> >  	select P2SB  
>