Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa3dc82a-fe5e-a90c-6490-1661f1bb43d8@intel.com>
Date:   Tue, 18 Jul 2023 17:14:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next] net: fec: add XDP_TX feature support
Content-Language: en-US
To:     Wei Fang <wei.fang@nxp.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <hawk@kernel.org>, <john.fastabend@gmail.com>,
        <xiaoning.wang@nxp.com>, <shenwei.wang@nxp.com>,
        <netdev@vger.kernel.org>, <linux-imx@nxp.com>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
References: <20230717103709.2629372-1-wei.fang@nxp.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230717103709.2629372-1-wei.fang@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHlRV2plYzFKZWUxMm8zWC85dis5eDdZMVBFcHF0UUc5TGRlOXMzdWZJWHBB?=
 =?utf-8?B?Z0N2b0RLV2hXbjlQRHpVNmFYUjRLclBVRWIya3crOTF0bkt3WVoxM1F2K0ZR?=
 =?utf-8?B?ckpueTNacVNFWWhFUzRRbGw0cDRlK2YwSEwwN2p4clJYK1FHVmZRY2hRTEVi?=
 =?utf-8?B?UXNPa2VPMkNydHdFVElFTU9iRXRaWkVLV0llMTh4cFlPM0YzT3RyeCtDeEdV?=
 =?utf-8?B?VXBDdEsxa1pDVUdxZzZrM0xmTjFqbUFBL2NXdzFxUWQyb2dmNnY2ME1OLzV1?=
 =?utf-8?B?ZWc4WGZtRC9kT0EvNW9UMlhMdzAyKzJjWEtFSjg3SUtOYTBzM24wSUhpdXdE?=
 =?utf-8?B?Q3lCS1c3T01vRGsxVGtQNm94ZFR6Uzg1ZFhjbVd0TnNJeXZEenpNRWo1dWRN?=
 =?utf-8?B?TVJOLy9mc0dQSG1MZE9WbDd2TytXaW4zZC9EOHJWRFdwYUxldVFyK085bm9W?=
 =?utf-8?B?M0p5ajNYbXhNdHFNMnFTS05hSGtFUDNHdzE2YnRwRHB1M3hxZ2ZiYlpUK1lC?=
 =?utf-8?B?MXpvenJaK1pQTTV2T0U0bkUrQ0Job29HMTZNMXRvMklEUCtxdmZrUXlxVm10?=
 =?utf-8?B?RGh0a0o3RE1GeERFa2diQkpHaVZwcm5LaE5wbnZzRk5SYzdhYXI1cElZV3Av?=
 =?utf-8?B?UXlZUnpQR1pMTkpLNHVvS2FtWW5LR01qRHVtblJiQXJUTVJlbkdOS0pYMmpP?=
 =?utf-8?B?bkF2QUZYMSs5ZWpEK1JlaE1jVXJlTDJjM2g3TkxZZEpRNytWWEV5UkNNdWhB?=
 =?utf-8?B?NVNiWXRUQjlmSmVBdkc0bU5lVmUrU0lkNExXalAyekhmTDlFMTBwdTk5YXY4?=
 =?utf-8?B?OEVsdktsL2VSM2tGNVlXWFZ2RVVQNlljSlpFWXBqdXhVWjlWZlVTZ2x6OTB5?=
 =?utf-8?B?UktHRTBQYm9MdWN5OEV2V2labVdjdVIya2czaEY2UGs5Z3lTL2p5bDlQaFRV?=
 =?utf-8?B?UnRBMlo0VVQ4THdzNkZwVkdRZDdwRjZtNjF0QTJsQld6aER1aWJhWVk3ajFi?=
 =?utf-8?B?VWJzWWxxZ25BN0V1Q0NSNHpSanpMTk93VEdDNjlIbVZmbzFmZktGUkNxK1I0?=
 =?utf-8?B?ei9HTzZibVdXNUVzN0Z0VTYvbHNFV3hQMkR1bEVKYnMzaHEwWVRpMW9uRk9K?=
 =?utf-8?B?MGdXN3ZqdGFVY3hsQ3AyTkhYNU9mbU14TnZaTjR3eXMwL1VxaHNSTU51UGlP?=
 =?utf-8?B?UVIydWt0cWovR3B4VVY2Y0hya0FlMk1oKzk0VVoydHNsZHhKUWQwTktaR3dX?=
 =?utf-8?B?a2FzamY2djhUblBKc1VPYnA2V3gyY3VUV0YrZFdESitGazdham40RkpsQStn?=
 =?utf-8?B?Zzl6bW55Q0xac1E3Sy9DUTRPN1Y3TXhYNGN4M2pMRzB0c1B4OUZJR3A3RWF4?=
 =?utf-8?B?WFRER0ZXbG1Dd001dHhCT1RpdDF5NGM4TXVVKzZlZng1b29kVXNlbHRiS09O?=
 =?utf-8?B?blFvd0JJaFZvUWM3eUJBZHlwc3NrNHQ2Wjc4ZllaL3R5K2d4cVZDSGx5NC90?=
 =?utf-8?B?a2huRTJXV3hjQWNPU01wWnhFVW51K2Jpc0FHd2J1d2lFSlJxQ1Rta2l0M0Vu?=
 =?utf-8?B?aFh1bitXNlF1cXdjclMvcW9sdFpNczNTTkJsWERDOVY2cVJScGZFYUhRcjlQ?=
 =?utf-8?B?VTljNVdVb2sveTVlamo2bjV3dklwdkh3OTkrb0hCRlRaZUczUURtRGZTdG5H?=
 =?utf-8?B?ME05dXYyYVFPK2M3b1FobWttSGluVTRXeWgxNitlNk9BME5ocW9pcHhTL2Fi?=
 =?utf-8?B?STU1REJwTUkycnlJWDV2ZmU1TUkraTF0Q3JzbXEybk42NEtXVm1leHBCNG5L?=
 =?utf-8?B?SDR2RGUvMjR5dGJwWFhhd2U1WXZZQUFDVW54QzErWXVJdkl4eWpEVjlIRU9s?=
 =?utf-8?B?dldhdm5POWZESUJNWG12cTV0ZCswc2xkZlFCZ1RwdzFHZW5CQXZGTnNnTXly?=
 =?utf-8?B?VlZhdHZmNk5GbTNGdG1nd2tObDNZRDVBekNpMkxUNXd0QU9wbHdIN0JzTmt3?=
 =?utf-8?B?bW52azJEeE4wU0U5ZWw3aWhBTXp2eWhGeHhxQ3VNSzlZNnRFQVdqUlljWUg0?=
 =?utf-8?B?NjJQUzZXaS9LRC82YlRqRURSUDNMTnc1S1QxblJFaUllS1pCQU1TZnRta1VT?=
 =?utf-8?B?blBTUVhrTG9EVk55cVV4VW02TElPalNZM0gwUFdUVHdnOGFFWnhmTUszbmRp?=
 =?utf-8?B?cmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 801106b6-d68f-474c-eb0e-08db87a1f4d1
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 15:16:27.2126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgyN13z39qLsJ1beLQwg5nr2zd0SXDwJ5XDU9PrtuvToQJYsJXqgWxQF2NKdVS5asTfmAxBOYa+lGNOyH3PHfeh9WsbAJ480aMep8OkAEak=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6993
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>
Date: Mon, 17 Jul 2023 18:37:09 +0800

> The XDP_TX feature is not supported before, and all the frames
> which are deemed to do XDP_TX action actually do the XDP_DROP
> action. So this patch adds the XDP_TX support to FEC driver.

[...]

> @@ -3897,6 +3923,29 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
>  	return 0;
>  }
>  
> +static int fec_enet_xdp_tx_xmit(struct net_device *ndev,
> +				struct xdp_buff *xdp)
> +{
> +	struct xdp_frame *xdpf = xdp_convert_buff_to_frame(xdp);

Have you tried avoid converting buff to frame in case of XDP_TX? It
would save you a bunch of CPU cycles.

> +	struct fec_enet_private *fep = netdev_priv(ndev);
> +	struct fec_enet_priv_tx_q *txq;
> +	int cpu = smp_processor_id();
> +	struct netdev_queue *nq;
> +	int queue, ret;
> +
> +	queue = fec_enet_xdp_get_tx_queue(fep, cpu);
> +	txq = fep->tx_queue[queue];
> +	nq = netdev_get_tx_queue(fep->netdev, queue);
> +
> +	__netif_tx_lock(nq, cpu);
> +
> +	ret = fec_enet_txq_xmit_frame(fep, txq, xdpf, false);
> +
> +	__netif_tx_unlock(nq);
> +
> +	return ret;
> +}
> +
>  static int fec_enet_xdp_xmit(struct net_device *dev,
>  			     int num_frames,
>  			     struct xdp_frame **frames,
> @@ -3917,7 +3966,7 @@ static int fec_enet_xdp_xmit(struct net_device *dev,
>  	__netif_tx_lock(nq, cpu);
>  
>  	for (i = 0; i < num_frames; i++) {
> -		if (fec_enet_txq_xmit_frame(fep, txq, frames[i]) < 0)
> +		if (fec_enet_txq_xmit_frame(fep, txq, frames[i], true) < 0)
>  			break;
>  		sent_frames++;
>  	}

Thanks,
Olek