Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 17:02:33 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     sunran001@208suo.com
Cc:     davem@davemloft.net, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: kernel: add missing put_device()
Message-ID: <20230718150233.GB688726@ravnborg.org>
References: <20230718072514.16432-1-xujianghui@cdjrlc.com>
 <4125a3a7bda2d099b59e32e20f733a92@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4125a3a7bda2d099b59e32e20f733a92@208suo.com>
Precedence: bulk

Hi Ran Sun,

On Tue, Jul 18, 2023 at 03:26:31PM +0800, sunran001@208suo.com wrote:
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference.
> 
> Detected by coccinelle with the following ERRORS:
> ./arch/sparc/kernel/pci_psycho.c:308:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 290, but without a corresponding
> object release within this function.
> ./arch/sparc/kernel/pci_psycho.c:350:0-1: ERROR: missing put_device;
> call of_find_device_by_node on line 290, but without a corresponding
> object release within this function.
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  arch/sparc/kernel/pci_psycho.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/sparc/kernel/pci_psycho.c b/arch/sparc/kernel/pci_psycho.c
> index f413371da387..45f8370bbfad 100644
> --- a/arch/sparc/kernel/pci_psycho.c
> +++ b/arch/sparc/kernel/pci_psycho.c
> @@ -305,6 +305,7 @@ static void psycho_register_error_handlers(struct
> pci_pbm_info *pbm)
>       */
> 
>      if (op->archdata.num_irqs < 6)
> +        put_device(op->dev);
>          return;

Missing {}

	Sam

> 
>      /* We really mean to ignore the return result here.  Two
> @@ -347,6 +348,7 @@ static void psycho_register_error_handlers(struct
> pci_pbm_info *pbm)
>          PSYCHO_PCICTRL_EEN);
>      tmp &= ~(PSYCHO_PCICTRL_SBH_INT);
>      upa_writeq(tmp, base + PSYCHO_PCIB_CTRL);
> +    put_device(op->dev);
>  }
> 
>  /* PSYCHO boot time probing and initialization. */