Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230716184204.GFZLQ5/DJ1+q8vpuuN@fat_crate.local>
 <CAHk-=wiXp9YLB6wHOmc4rBJbd7j0gHgHZPHhUSPe-SAjJgmABQ@mail.gmail.com> <d11eea99-6e93-6af4-87aa-2e7f1c6ae83e@oracle.com>
In-Reply-To: <d11eea99-6e93-6af4-87aa-2e7f1c6ae83e@oracle.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 18 Jul 2023 08:41:29 -0700
Message-ID: <CAHk-=wg4Ajeu-Ju4TsZ+Y83ksb+Z=VMyy--gf1uZzj7Vc5D1ag@mail.gmail.com>
Subject: Re: [GIT PULL] objtool/urgent for v6.5-rc2
To:     Vegard Nossum <vegard.nossum@oracle.com>
Cc:     Borislav Petkov <bp@alien8.de>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 18 Jul 2023 at 04:02, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>
> If you are willing to add another helper function that also takes the
> label argument, you could do something like this:

Ugh. That's a bit uglier than I was hoping for.

I was hoping more like "use this special attribute to mark this asm as
being something that cannot be moved across function boundaries".

Now a "we have to make up horrible games and pass in labels that are
not used and use a completely different API".

Oh well.

I guess in the end we can just continue to work around this.

After all, in many ways this isn't about the code - the AC setting and
clearing is fine - it's about objtool not doing the analysis across
function boundaries.

I guess we could have just marked these iovec copy functions
"always_inline" too, and avoided it that way.

              Linus