Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7044446rwp; Tue, 18 Jul 2023 09:13:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlG5AwBnRbX9QCTbkNhO5kHMwlxrvCdtz79zxtGEylxy5i6DytLeDC77J/0U+CulaL7I5ySg X-Received: by 2002:a05:651c:198a:b0:2b5:ef16:d393 with SMTP id bx10-20020a05651c198a00b002b5ef16d393mr10681513ljb.3.1689696785771; Tue, 18 Jul 2023 09:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689696785; cv=none; d=google.com; s=arc-20160816; b=Iqj9NNS4/ENb06DBtCfN2wwkL1eVBNmOpbf39251mmvPVzsnxPrz0OK4dkPIQlFvh7 nizqs+PmpKtysEBR38wjXkNUlJ/G7BqCNPJVHKPSr04Dsbgj05U5zcl99mfQFjj2bzTJ GNqa3Y749GP08mNSB86ZHSlmIapCDptb49Vp5gdsiknP0uK72PhBe8lxO5iH7f8dlYDh GwVCuTKAc8ZPrNeHaMCi1ZM+nscRwlH1YOp1ee4kg0Sq3XDWrF2I7g60UlFA+4nBz5hD dkJCk+aRefMFGlO/bWqACo+bAK3I1U+gY9AS15YV015NV1uBL8Xi5cyXGJDpaDlUCfit grjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=ad66UUVO3pSvlvkox2MT7k2+8Ed+6IONyfoOpiaiMsQ=; fh=cvjl4n7DhKZBXLacaDLux300MctpSWTSm4BtvPBcrO0=; b=HvyhfqtOxR64J1Zgr2oill0F84j6b9jUZfgrwUT1AdlHKT6qAlVHti+f/hqw8YH1Hm bVvQgYh3Ts9V2ut6bM2pX26tg3TwUtkQLvOj1BlTEJAJk3xQ/FExaHS6iU9iuVtvpvxk 9MVoG2e0wv311hrbd0KCEJZ27LQVOVghG5dQOjrP3elMbXJIewVgJIVa5f7WcHyXTxM/ fD5kLK65wp/V1h7stfxcv17/ouQDDlrHABEKdCXQ6PQ3m7dtURhy95aA27RGxfb9MdKj QtlQMyqyaEzQucPGfeHmGB4a8YBazKziZn/niZz8n5uGqJ6h4U54SWA5Rc2lwf2/a93j 8+UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Rg0d5kKS; dkim=neutral (no key) header.i=@linutronix.de header.b=C2Dd1Csr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a170906041000b009892631e251si1399709eja.770.2023.07.18.09.12.42; Tue, 18 Jul 2023 09:13:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Rg0d5kKS; dkim=neutral (no key) header.i=@linutronix.de header.b=C2Dd1Csr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233798AbjGRP4s (ORCPT + 99 others); Tue, 18 Jul 2023 11:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjGRP4o (ORCPT ); Tue, 18 Jul 2023 11:56:44 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 085821996 for ; Tue, 18 Jul 2023 08:56:39 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1689695797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ad66UUVO3pSvlvkox2MT7k2+8Ed+6IONyfoOpiaiMsQ=; b=Rg0d5kKSCd43BjEkyMdTFN67J6jqWri0AVjjiUS6uNMKi04ud9ZpOg8CGEcd2+ikOj43Pu Vlhx+rlZXZDGTv2Y+HN6kIbxTx093nsrdC2VDI0xXubcp3uceOx15bHLo31EpU7OcWghIb aEchJXAN9uxjujSd4RkSs0Ox1g/309du9E8GGufcDCZ+B0bOcC66YrAltE948H334dOSXx 3ATRRs/4nTOP4N9aqPxmaN0HRxs3YOT86lw5uGkqf9DtETeNsqBr6aqdFfxFhh/o7Vc89P l0NY0DYI+vlap8o48TXIb5vRen1ISN84mv7CExQXszp1flCCWrKudBUXcKN81w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1689695797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ad66UUVO3pSvlvkox2MT7k2+8Ed+6IONyfoOpiaiMsQ=; b=C2Dd1CsruzP9g3plb51s2N3XB3xjiOkINkIAtHSksmc3925NKlZ+72cSNp6YC4/EqSKMAZ ZG9xWXtVTEc+CGBg== To: Juergen Gross , LKML Cc: x86@kernel.org, Linus Torvalds , Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven Subject: Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after_init In-Reply-To: References: <20230717223049.327865981@linutronix.de> <20230717223226.297124390@linutronix.de> Date: Tue, 18 Jul 2023 17:56:37 +0200 Message-ID: <875y6hxlfu.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18 2023 at 17:31, Juergen Gross wrote: > On 18.07.23 01:15, Thomas Gleixner wrote: >> + .get_apic_id = xen_get_apic_id, >> + .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */ > > While changing this line, could you please drop the comment here? > > 32-bit is irrelevant, as Xen PV is 64-bit only these days. Sure.