Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7044d6b3-a5d1-572d-a755-74f8d4fd31c5@amd.com>
Date:   Tue, 18 Jul 2023 10:37:23 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] blk-iocost: fix seq_printf compile type mismatch error
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        amd <amd@localhost.localdomain>
References: <20230717141852.153965-1-carlos.bilbao@amd.com>
 <ZLWNHuTGk0fy8pjE@slm.duckdns.org>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <ZLWNHuTGk0fy8pjE@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTVoTEJKUGplcHJXRkRUTTdOVUdtS3I1L2E2MjZnUGJ5TSt1Mjg1OFlCMHN5?=
 =?utf-8?B?dnNrRUNjd3lFL3JUQ2RNVWZxdlRPbDc1TEpXSkFFd0JYYWxzbE9tZEFRa2tS?=
 =?utf-8?B?WktUamdqVlc1d3lrSGQ5b3JjVVhIdEtScTdKVVBpRVpiamo4UVNkWGpGaHVh?=
 =?utf-8?B?L0ZsRVhJajBCTlNJSUluaUpmZnVmdEJSdCtiTWcyTng3RHVPRDNKczdNU1hD?=
 =?utf-8?B?bXRxdW9qdDNEeVRJVXNDZmpldmNIR1Z5YXBmYTYrN0R0MjhzRkh6emRKczJr?=
 =?utf-8?B?Y3Z5Wk03eU50Sk5JRzJQSEtzY3J2M2o0ak1UTHpMeEI4WXZBZldHVUVWT3dU?=
 =?utf-8?B?SzRtSUhoTTM3eVlrd2pmZXZkSVpkbVNQMXRzemlBSkpPZEJWeUNWRzV6QmFr?=
 =?utf-8?B?SkN6NW1UV1AybUNBV1dVclo1RFZGcDJvb3hYcjV1L2o4RU5iSWEyTmFXcWN3?=
 =?utf-8?B?c1JuTHU1UU1KMlhLWUtlMU52VUZBRVBPMzNzb3gxTWxPejVmdE4ydXJ0UDZa?=
 =?utf-8?B?M3RaQlBoaEs5TlpFWFk5dW9UdjlxZDUwd3g1UDZqTGxCK05DUHNzbUxjK0Rl?=
 =?utf-8?B?K04vT0lENzd5SGRJQm0xUDErWTZZbUI4T0E4OElDcTMzTFdQRS90ZFJhTHdD?=
 =?utf-8?B?aHZjY0J5K3JZZGJWZ1dVVGVPUFlDUnJjOC9FTjQ4TExSb3NkYXI2RVFwb2hm?=
 =?utf-8?B?dXRmTkk5OElzQzJJTUU4TTQzL1FRRzBabUVNRWZoYVNiRGFZRjdxOUhaZ2dU?=
 =?utf-8?B?YkEzWlpNaEJkQ3FXVjcxaUNPMGIybllkQlZMNDNvWUNWTWVoT3pZb0FBMGlY?=
 =?utf-8?B?WCt5eit1ZmNLK2xITk40bU5mRTM1L1VjNmpvVUl2OGhVSkdzMFV0Zk55dnpa?=
 =?utf-8?B?UUtmeTh2UjA0bmlySXJEOGM3elhiR3N1dU14VFpWSzFTbDR2QmtEamF3T0ls?=
 =?utf-8?B?bExmTEJ2QmJBODZ5UGVQMERLQXdQTmVSN2IyY3FpK2JNaDRNZjBQVWxyT2d5?=
 =?utf-8?B?UHQwTnRyY3Z5MDBobW5YdGxFTXBtS29kc29RRXVHRG9MenE4RTEwZzFGK3hu?=
 =?utf-8?B?SjBGRjUvMkdvbFhLdlZoWGU4MnZ0K3hsMm9YRnlIbXAycWlMN2NCaFk2N0ox?=
 =?utf-8?B?UU1MamNoczZ3RHFvemZKTjdjalA3SXJzSmxjVjY2N3o3eDMxTnNHdlhHZy9p?=
 =?utf-8?B?cmtIUkFHc0hFRFk4ZERSNmRLZ1BJLzhOZjdxeXNTdm5JUFNYdytGcDczOG5V?=
 =?utf-8?B?SWsrREZ3U0xsc29sMURCUW5qMGNFc05tM2p4YWhFemdLczRPRUpwWkJlVWZn?=
 =?utf-8?B?SFl1VE5ZbGRtazZGUE5DK0VSbm1tRVFIbWNYZU55VmR5bXg0YUNDSTV6STdJ?=
 =?utf-8?B?RmFkSnRnQUJFbkZDNExjaWF4ekxxYS95Q0s0N3VMWERLQ0pYVjBjUUozYVdh?=
 =?utf-8?B?SkFuanpZT1BwRUdpeFlxNU9zaHdOOEhoUnlKSGVidFUxbGtLOUFpbkhxQ1g2?=
 =?utf-8?B?WGFFRktvUC9vTTZoNEQzeEJtZFIzQXR2NEJrbnJ5K2JBS3dGdUE0bUhGMW4r?=
 =?utf-8?B?TFJLOUZZZDBFMDl6WXBESngxbjFvY3dDUmJxR2hMVmdlZEw1aXF1TkJ1RGo4?=
 =?utf-8?B?YUVnTEhYQmRGWHBNNGJKczdFZHlGWDF1QWZXbWZySmRHdFhPeEJZQUwvbGFG?=
 =?utf-8?B?TllobFUzQUxCSWExN0R3aVA2eVlCcmt6YmhVbWlONG80OUNtR3J1UEt0OHNB?=
 =?utf-8?B?ZVU3T1Y5ejZUSGd5UzNBMTFRZ0kyTEVFUElvMEZRSnBUK2VMUjVjbU9IVTlZ?=
 =?utf-8?B?ZnZ5cXBmUVViS1huYjFWTjJaSG0vYm5xT0Zobm9wSlFVSi91OUVGMmM4dytv?=
 =?utf-8?B?dGlIellNdVBQN1g0Wno4cE1uYXBFZUNTOG9qWThjTnQ0SjhSOXhGanZkbDdH?=
 =?utf-8?B?aWc3NUE3TFhFNlUzS0V5Mk0zTzc4dlBsUGxZV0hYVFNQSVpjeFVxdjR0VGpq?=
 =?utf-8?B?QXQvWkszWitTOEpWdm5xdlFLNVBSVWRlUjQwTDRYVHE5ajQyNXUvbHYzWDJY?=
 =?utf-8?B?R3FTVXRRR0RjYnZtT3JGSVFPbVE1STJxa1Bob0poWFl5VkF6VDNMYlBQSmY3?=
 =?utf-8?Q?EkOHPt+vlMmDNrotLaY+BNEFQ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e1bc97-5345-4c8b-6ec0-08db87a4e318
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 15:37:25.9464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6tPX7fDNnLaF91q1NvPO161OCtpj7bWVytPs9Ce6yV1l83EG7fS1wLF5QMXJ6WNWAHxlRNS7U+6CE/o1MVs95A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8038
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/17/23 13:49, Tejun Heo wrote:
> On Mon, Jul 17, 2023 at 09:18:52AM -0500, Carlos Bilbao wrote:
>> From: amd <amd@localhost.localdomain>
>>
>> Fix two type mismatch errors encountered while compiling blk-iocost.c with
>> GCC version 13.1.1 that involved constant operator WEIGHT_ONE. Cast the
>> result of the division operation to (unsigned int) to match the expected
>> format specifier %u in two seq_printf invocations.
> 
> Can you detail the warnings? Was that on 32bit compiles?

The concrete error was: "format ‘%u’ expects argument of type ‘unsigned
int’, but argument 3 has type ‘long unsigned int’". If I run:

$ echo | cpp -dM | grep __LP64__
#define __LP64__ 1

which makes me believe it is not 32 bits.

> 
> Thanks.
> 

Thanks,
Carlos