Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <03d7c703-81cb-20f9-aaf8-2ab8ca3e7138@nxp.com>
Date:   Tue, 18 Jul 2023 18:40:53 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory
 find_loaded_rsc_table op
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
Cc:     "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Mpuaudiosw <Mpuaudiosw@nxp.com>, linux-imx <linux-imx@nxp.com>,
        linux-remoteproc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        LnxRevLi <LnxRevLi@nxp.com>
References: <20230712224220.26430-1-iuliana.prodan@oss.nxp.com>
 <ZLV9gAmiDldlvIUR@p14s> <474c0241-a58e-b435-8ac1-82a5a458d79a@nxp.com>
 <ZLauY85b9SRC3z0x@p14s>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <ZLauY85b9SRC3z0x@p14s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm9PRVhvZWJsVFg5S2ZPNWhTR1MxUUJUWXZNL1FOdnh4R0JvNjlHQjVLOFFG?=
 =?utf-8?B?VEZZMHhRT2VMMjE1OHAyYkhvL2tqV2gvMjhzR1hyTm1rck8wTEM5SDZsRldF?=
 =?utf-8?B?ZTZWTmd1N1B2QVhOOTJ3ekpnNlN4Tkpid0ZuVHRyUVlzZXgvL0VUTjBTZ0x6?=
 =?utf-8?B?Z0N6NDBVNmxIVzdadklmcmhYcFRNWGpSek9QMEYrSjQ5ZnFIRWVNNitZai8x?=
 =?utf-8?B?ZFczWldOMkFoblExbFVkSmVWdW5SSk1tZWgyVDRJYWlJa01JSDAvdGN3V3Er?=
 =?utf-8?B?S01jSno0cHh3SDRVekhPMURrbjNHNVBJdmZ2WDB4U0trUjZwUk56eFZDOFBa?=
 =?utf-8?B?L0Z0eUNLUFNWeTk3WGUwM1ZDems1TW52dzZEUEdyQkJZUVNHQmxRQy9HaFpG?=
 =?utf-8?B?KzNSUFBUczM0MVJpZXZGdHY2TFUvUXozN0x2Z0VpS252MDJGenBEcytPa0dq?=
 =?utf-8?B?WkRmZ1gyZkh5ZE0ybWFxNlhYUjhVZmdaaHZVQ0hqSFFVVWI1ckZsUmg1M09x?=
 =?utf-8?B?SjRJUTRDdDFIZlFhejJHaDk5MHRSK204dk9jTFJqWWlLTytBZ0F6R1pTV25u?=
 =?utf-8?B?Q2wwcXBZbTZXS2U5bmVBbUF6NCs3bDlYSWM0RzFTUzgreWhYdUlheXFsYUVB?=
 =?utf-8?B?dzA5V2tQd2ovTlViT2ZGWGtBMVR0LzhKR1FKQ1pTZEF1ME9oNHpGVXNNenZt?=
 =?utf-8?B?K2FGcHNCcmxSclBhWVJhUzluNE9uaVJBNW9CdzRnZkMzaFhaSW8rbFRXODBm?=
 =?utf-8?B?RW9HVk83Q2hyMUVPTHZVb2xsT3NEMkhNdlVvQmk2c29Ba2o0TDVsRjBMbEo5?=
 =?utf-8?B?QXorenBvKzNvTHdFbjlSc081WVRRNGI3ejNYQzYrdzJkY2tyU2Zya3AyQ3Ro?=
 =?utf-8?B?VExCazIvTDQwVTZHRE0yMVZQQUZXQ09sS1Nha2YvZ3FYeXg2MWdFeUNlT3N5?=
 =?utf-8?B?KzRMYTRKL2FwTE5HbmFibnB6V0dDb3FFTUR1MGwwTnU5OTFITTJaV01HZlRx?=
 =?utf-8?B?Rm5EOEtWSnBXNHBwZFE1dWY3cUpzWVpYUk5iNkZXVW1oZUtRc1dOcXF3RTVa?=
 =?utf-8?B?RlFTemxGSmF5NzN2YmhTUGUrZlp4QnNIYWo4WExTeXdDQkl0bWdmWHR0WVRO?=
 =?utf-8?B?VGVac2FodG5HSUJvSkFGRnI5dlgvYUNuRi9hWkU3VW1pOGl5a3hSek5BbTVl?=
 =?utf-8?B?UG1HZUNlQVRveEVIcEJXZ3VEek9kT0VCZDVFbkF4eHlYbWY0ZWJrck0raWl4?=
 =?utf-8?B?NWNqdElsMHhOTmlFaHl6YUFueUlwcDIzUUdzdFFzc2YwNTB5Tkd4eDZYN09s?=
 =?utf-8?B?Mm12cnRDazRRUzNDcGNNWEE4elpUWFp1aTJmeDJXc2hqSjcwY2lLT0ZXQVk3?=
 =?utf-8?B?bVB4WUZBQXFVUEdUUFZTQU4ybmJTekpyeWxoR0FIcVpCaTFja1c2Z21mS1Rv?=
 =?utf-8?B?dnFUWUlKSUZXWFZzYlVSUzZYY2s4czNIYlJuYlRTdDV3SWd3Tnk0a01ZcEU2?=
 =?utf-8?B?OXlNQ0RsVjFRclNmTnRMclNUZlpJTi9PNnRwU1NGamJUTmIwOU5GZkM1a2ND?=
 =?utf-8?B?QlhsNjdEZkpQRGcyaThEWmZPK3ZzbjFhdDd3RnFibllPbk1ZbkJrbEdYQVg3?=
 =?utf-8?B?YVZHWHZFOWsrRmFicG1LcmJra3g2NFl2bEJ3aVJkdE1IWmlXNVN3bkNMS1FG?=
 =?utf-8?B?MkpOdDR5cVVtOWNzUHlzY2hmZWg4ck5yQUxZNE9xcWN0Z21oRDdtVmxzNHJ2?=
 =?utf-8?B?WDlYMWlZbnVpTW0yeU1sMDRNbkZpTnFVNUtpSE04dWdoVFNsY2MrazlUMU1U?=
 =?utf-8?B?ME9VeHRuNSsrVEdHUy9EUTFjR3RIOXI2WGppZlFaMmptT0NuL0J6UlNERnFL?=
 =?utf-8?B?L2p1UWdKVlprcWNtWmllc3hTOEpCaHFVNE82SFpCUlFuVTR5QUNDZHdFMEYv?=
 =?utf-8?B?V2x6T0h3Q21rMHVFakw5R2ZoanlxS1lIdE9DVVFveU5wYjYvd09QWlJFMnF6?=
 =?utf-8?B?OFpaL0x1SVd1ckhoZUUwTDRHZC9oQWFwTGhBRHRXZ1BYZkppa3F4Q29BajRM?=
 =?utf-8?B?a1lkT3hDWHRnSWdrNXozUDZ3UDM1UDFYVUdtNEpOMWI1bTRySFVjVlRRL3da?=
 =?utf-8?B?Ni9sWjZxYVowdk43UU0xa0Fwbkt1TTFtdmNLcVlrUW1GcnY0cDd0RFJGT0hV?=
 =?utf-8?B?a1E9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0376dcea-3068-4a8f-7979-08db87a56032
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 15:40:55.9128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2sbOgcP6To/F7hmKP0OCqQ3mLfHj0XNbA9iw2fLGFu4BaqFhWM8SFegqY+odvKCa+ihy+tTt8MGh7XOnY7NwVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7155
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/18/2023 6:23 PM, Mathieu Poirier wrote:
> On Tue, Jul 18, 2023 at 11:25:03AM +0300, Iuliana Prodan wrote:
>> On 7/17/2023 8:42 PM, Mathieu Poirier wrote:
>>> On Thu, Jul 13, 2023 at 01:42:20AM +0300, Iuliana Prodan (OSS) wrote:
>>>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>>>
>>>> Add the .find_loaded_rsc_table operation for i.MX DSP.
>>>> We need it for inter-process communication between DSP
>>>> and main core.
>>>>
>>>> This callback is used to find the resource table (defined
>>>> in remote processor linker script) where the address of the
>>>> vrings along with the other allocated resources (carveouts etc)
>>>> are stored.
>>>> If this is not found, the vrings are not allocated and
>>>> the IPC between cores will not work.
>>> Is there a constraint on the system memory the M4 can address?  If so there
>>> will be a need to declare address ranges for vrings and buffers in reserved
>>> memory in the DT.
>>>
>>> Thanks,
>>> Mathieu
>> Hi Mathieu,
>>
>> No, there is no constraint on memory.
>>
>> We want the Cortex A core to communicate with the HiFi4 DSP.
>> The Cortex A is in charge of starting the DSP and loading the firmware in
>> HiFi4's memory.
>> When using rpmsg for IPC, the Cortex A needs to find the resource table
>> (defined in the DSP linker script) and this is done using
>> .find_loaded_rsc_table callback.
>>
>> For the DT, we are using a (not upstream) device tree where we have the
>> reserved-memory for dsp_vdev0vring0, dsp_vdev0vring1 and dsp_vdev0buffer.
> That is the part I'm interested in.  Don't we need the reserved-memory entries?
> Otherwise the M4 may not be able to access the memory chosen by the application
> processor, most likely leading to a crash.

This kernel module (imx_dsp_rproc) is used only for DSP.
For M4 core we use imx_rproc.

Iulia

>> Iulia
>>
>>
>>>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>>>> ---
>>>>    drivers/remoteproc/imx_dsp_rproc.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
>>>> index d95fa5586189..b5634507d953 100644
>>>> --- a/drivers/remoteproc/imx_dsp_rproc.c
>>>> +++ b/drivers/remoteproc/imx_dsp_rproc.c
>>>> @@ -941,6 +941,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = {
>>>>    	.kick		= imx_dsp_rproc_kick,
>>>>    	.load		= imx_dsp_rproc_elf_load_segments,
>>>>    	.parse_fw	= imx_dsp_rproc_parse_fw,
>>>> +	.find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table,
>>>>    	.sanity_check	= rproc_elf_sanity_check,
>>>>    	.get_boot_addr	= rproc_elf_get_boot_addr,
>>>>    };
>>>> -- 
>>>> 2.17.1
>>>>