Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Michael Riesch <michael.riesch@wolfvision.net>
Date:   Tue, 18 Jul 2023 17:31:52 +0200
Subject: [PATCH 3/4] drm/panel: sitronix-st7789v: add support for partial
 mode
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20230718-feature-lcd-panel-v1-3-e9a85d5374fd@wolfvision.net>
References: <20230718-feature-lcd-panel-v1-0-e9a85d5374fd@wolfvision.net>
In-Reply-To: <20230718-feature-lcd-panel-v1-0-e9a85d5374fd@wolfvision.net>
To:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Ripard <mripard@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Sebastian Reichel <sre@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Michael Riesch <michael.riesch@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cG9aSUExbmVQMk9oZ3JQRmhaTkNsQ25pRmNPYnVrVm16UmdMK2pXbGFBTVFi?=
 =?utf-8?B?WHlCY3VoeE95bzFPRXJzUVBMR25qNXNTMDg3UmpKVTJrVUk4bGNyN1c0eW00?=
 =?utf-8?B?dVRiMldxMWtERm9sQi93TFh1S0szYjJoN2w4U3BDL0txaEhjOHpwKzZBdEpG?=
 =?utf-8?B?LzhCVkp6ZmMrOElEL2x0ekZPYmllc0R0L0c3R2dzTmkxU2VXY0tjb0xjTEFS?=
 =?utf-8?B?ZTVXd1ZsY1JKbGU5MkFBMEFGYmgvWFVqVXUvZnV2UmcwNGV2OXVNYVdseHV6?=
 =?utf-8?B?NUdqa2ZjUEFOeEdpMGhya20wdHoxV1VQYVJUOUxRKzBqbGZ2ODJmclNCZXNu?=
 =?utf-8?B?VG4xbnhzT2w0Q3h4cHRveitvOGlqVCs3U3pDc3ZtS2tTZ0ZGazJZU00rb0dT?=
 =?utf-8?B?MjBoQjd6TmpXaXFWWE1pWTFRRWcrOFhGVDJ5Y3R5VVJrSFpkOGpEcFhMd3Va?=
 =?utf-8?B?MmoyelJBRnd1M251SWU1SzlVRkw1OFNHaSt2RFcvN01ROGVEd2JFamN2WDB0?=
 =?utf-8?B?MExPbDA0aWgzNHZoU29waXJMRDdrRVdpaWR6UWdxMU5ublBnUDNMc1hOdGMy?=
 =?utf-8?B?L2RLU29JNDQ2NUhHWXVlYVZNTU1WU3p3ZG5jWC9HWllwc3dJa2hCR2xnemF0?=
 =?utf-8?B?THpRV0pMbzNsUGlkQ2xGWGNoeEdZUmJ3Njhlem8xNEN5aHg5ZTRtd2lPNUdl?=
 =?utf-8?B?RTNqSzZzR213VlMxWkxmVk5PMjhUbnlpUlFqVzV5eEtOalhnREMxOERwWHhh?=
 =?utf-8?B?cDRnOUdsZzlZdll2WGpJeHVaZTJ2aHh2MlBwelVLWmdHbURYeWxpaFFIbTN2?=
 =?utf-8?B?K3ZTckhPYkhWUlpZZnRaaVpvYndZM0pzUG5wNTZYQXAyNUc0OEtTUVM0ZlFI?=
 =?utf-8?B?NDlnN1YxUGJ2dHA4RU1mTWNaOHd1Mk1YSTJjdS95Y2xlUU5XMlhBUHRMNmJC?=
 =?utf-8?B?VHRqRWNXelJiaWZCZEhnUVB3Y211bk81cGJDM2V4aTVRUktidjVFV0RKWGZ1?=
 =?utf-8?B?M0JXcllKcEk0elhRNW5lZWxDZXVpbkQ2clVNV29aYVV0M3FuekhSQUtpdyth?=
 =?utf-8?B?Uk5tYzRsOEJ5VVlmbmJ0MmNzZWdTYWg1cmxKTXFLRWk3RW4zTTNqUU54VHQz?=
 =?utf-8?B?MHprTjlxNWNxS1ZQQWNET2RySVJRZXFmOHp5cXRHb3hJeGFPVU92UkxOZzhS?=
 =?utf-8?B?VGRDNTFQRDdoazBRSk9UNnNBeEdiQ0xCM1RsRzZkclBXc3MxVExoRzlSakhJ?=
 =?utf-8?B?RngwMzBBZlBOVnRzL1BtQTVYdnhIdHV3R1FoNzBiallncUJWaW1FNnZrWFZE?=
 =?utf-8?B?ZHNWN3IzR1Axa3NTWGI2dVZjN1pXb2tDcGlRTHBQdGRvT2RBZ2twTzlSTjFX?=
 =?utf-8?B?dWdRMTEvTStIbGxKVFArYUFPNEJJNHRUdFFSTjJBdzNSNFc0RXR5N0xLUklp?=
 =?utf-8?B?UDI5aU9CWXVSc3grenB3RGlGWWRqMnpGUFl4eDJ4ZFJJaVJzNE05TzAxVWF2?=
 =?utf-8?B?L29wTSttclprTWtOSG00cFdWcTBHWnVnL0Z0M2ZRY3ZLb2tyY05OTUlNdkN6?=
 =?utf-8?B?ZkxzNlNkVktlb3ZqQjUvTnFHeENlUUtnSnlLZlV5WFNIZkkrR1VmRUNJREl5?=
 =?utf-8?B?dHJldUtGV1BqQldUQUF5NDk0M2dUNEVDYVBkdWtiWXkxRjNGeXIya1llandn?=
 =?utf-8?B?VmVXcHNKUm9nR0hyVUhJamF3ZU9pS0VzMURxMEV0a3NHUXM1OFc2Qyt3NlVq?=
 =?utf-8?B?SUgzWGplUWJoU0l1SFNMSDBlYnFvcFdoOWdmNTdxcTBvYlppd1p2a1dRVDRP?=
 =?utf-8?B?WUUvbzVkUFViR0xUb0RjWnBQNGcrRGg2US9YVHhqRTkrNURnWGRiMlpWY3ht?=
 =?utf-8?B?eUcvWEVPQldwbGdkZFRtZVhFZnZBZlVnWUYrdWpReEQxa1BWb1VPTDlKeTRK?=
 =?utf-8?B?aTM3a3BGbmgyQVgwamZVTVlhL3BlbnRxeXNVTkp3S3RxdXRqcG4rMGlKcUVQ?=
 =?utf-8?B?MW1Sc1dxaHRRbGhoREx4YU5sRU0vZzlYR1R2UlVrUFdibDdCQTA1UVhqSTdv?=
 =?utf-8?B?TUR6ZzllL1A4TThBWmJBenlqc3U4czF2WjBlTGg2eU5ERVB6NnVYdEwrMnFn?=
 =?utf-8?B?cEV0aWhnZ1JwYjNIaG5EbUlHandzWmREWktycFFNNUpHOElsSUQ3MytrZ0tr?=
 =?utf-8?B?U3c9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2a0475-97d0-40ac-2246-08db87a41e9b
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 15:31:56.1902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dC8lpJQzRT6+atZm38LmsJEpK1Gw7Wvr3CrN6FVGxZq/x1Q07NlxSmXnkrLIMCn4c3pfVLICqg2UxbemBCJElZKJmgzVb3WETzwyGdPlBMw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10201
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The ST7789V controller features support for the partial mode. Here,
the area to be displayed can be restricted in one direction (by default,
in vertical direction). This is useful for panels that are partially
occluded by design. Add support for the partial mode.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 38 ++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
index d16d17f21d92..729d8d7dbf7f 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
@@ -118,6 +118,9 @@ struct st7789_panel_info {
 	u32 bus_format;
 	u32 bus_flags;
 	bool invert_mode;
+	bool partial_mode;
+	u16 partial_start;
+	u16 partial_end;
 };
 
 struct st7789v {
@@ -330,9 +333,14 @@ static int st7789v_get_modes(struct drm_panel *panel,
 static int st7789v_prepare(struct drm_panel *panel)
 {
 	struct st7789v *ctx = panel_to_st7789v(panel);
-	u8 pixel_fmt, polarity;
+	u8 mode, pixel_fmt, polarity;
 	int ret;
 
+	if (!ctx->info->partial_mode)
+		mode = ST7789V_RGBCTRL_WO;
+	else
+		mode = 0;
+
 	switch (ctx->info->bus_format) {
 	case MEDIA_BUS_FMT_RGB666_1X18:
 		pixel_fmt = MIPI_DCS_PIXEL_FMT_18BIT;
@@ -472,6 +480,32 @@ static int st7789v_prepare(struct drm_panel *panel)
 						MIPI_DCS_EXIT_INVERT_MODE));
 	}
 
+	if (ctx->info->partial_mode) {
+		u8 area_data[4] = {
+			(ctx->info->partial_start >> 8) & 0xff,
+			(ctx->info->partial_start >> 0) & 0xff,
+			((ctx->info->partial_end - 1) >> 8) & 0xff,
+			((ctx->info->partial_end - 1) >> 0) & 0xff,
+		};
+
+		ST7789V_TEST(ret, st7789v_write_command(
+					  ctx, MIPI_DCS_ENTER_PARTIAL_MODE));
+
+		ST7789V_TEST(ret, st7789v_write_command(
+					  ctx, MIPI_DCS_SET_PAGE_ADDRESS));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[0]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[1]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[2]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[3]));
+
+		ST7789V_TEST(ret, st7789v_write_command(
+					  ctx, MIPI_DCS_SET_PARTIAL_ROWS));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[0]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[1]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[2]));
+		ST7789V_TEST(ret, st7789v_write_data(ctx, area_data[3]));
+	}
+
 	ST7789V_TEST(ret, st7789v_write_command(ctx, ST7789V_RAMCTRL_CMD));
 	ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RAMCTRL_DM_RGB |
 					     ST7789V_RAMCTRL_RM_RGB));
@@ -479,7 +513,7 @@ static int st7789v_prepare(struct drm_panel *panel)
 					     ST7789V_RAMCTRL_MAGIC));
 
 	ST7789V_TEST(ret, st7789v_write_command(ctx, ST7789V_RGBCTRL_CMD));
-	ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RGBCTRL_WO |
+	ST7789V_TEST(ret, st7789v_write_data(ctx, mode |
 					     ST7789V_RGBCTRL_RCM(2) |
 					     polarity));
 	ST7789V_TEST(ret, st7789v_write_data(ctx, ST7789V_RGBCTRL_VBP(8)));

-- 
2.30.2