Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8ed402ba1afb88e9e90925333b2e593ba42900e.camel@ndufresne.ca>
Subject: Re: [EXT] Re: [PATCH] media: amphion: fix some issues reported by
 coverity
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Ming Qian <ming.qian@nxp.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>
Cc:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "X.H. Bao" <xiahong.bao@nxp.com>, Eagle Zhou <eagle.zhou@nxp.com>,
        Tao Jiang <tao.jiang_2@nxp.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Date:   Tue, 18 Jul 2023 12:17:19 -0400
In-Reply-To: <DB8PR04MB6346BDF7F2E00FC8DBB32CB7E738A@DB8PR04MB6346.eurprd04.prod.outlook.com>
References: <20230717074006.22372-1-ming.qian@nxp.com>
         <a40c81a39de214c756a36fde535bfc775d82b922.camel@ndufresne.ca>
         <DB8PR04MB6346BDF7F2E00FC8DBB32CB7E738A@DB8PR04MB6346.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Le mardi 18 juillet 2023 =C3=A0 01:50 +0000, Ming Qian a =C3=A9crit=C2=A0:
> > > diff --git a/drivers/media/platform/amphion/venc.c
> > > b/drivers/media/platform/amphion/venc.c
> > > index 58480e2755ec..4eb57d793a9c 100644
> > > --- a/drivers/media/platform/amphion/venc.c
> > > +++ b/drivers/media/platform/amphion/venc.c
> > > @@ -268,7 +268,7 @@ static int venc_g_parm(struct file *file, void
> > > *fh, struct v4l2_streamparm *parm=C2=A0 {
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vpu_inst *inst =3D to_ins=
t(file);
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct venc_t *venc =3D inst->pr=
iv;
> > > -=C2=A0=C2=A0=C2=A0=C2=A0 struct v4l2_fract *timeperframe =3D &parm->=
parm.capture.timeperframe;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0 struct v4l2_fract *timeperframe;
> >=20
> > Could be just me, but I feel I'm missing some context to understand why=
 this
> > change. Perhaps the commit message could be improved ?
> >=20
> > All other changes looks like improvement to me, so with a good explanat=
ion
> > on this one (and the change seems to be equivalent), you can add:
> >=20
> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> >=20
>=20
> Hi Nicolas,
> =C2=A0=C2=A0=C2=A0 The Coverity scan report a REVERSE_INULL issue here, t=
hat directly dereferencing pointer "param", before Null-checking "parm".=
=20
> =C2=A0=C2=A0=C2=A0 I'll split this patch into several patches, one topic =
one patch.
>=20
> Ming

Make sense now, looking forward a split version with more explanation.

regards,
Nicolas