Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "chuck.lever@oracle.com" <chuck.lever@oracle.com>
Subject: RE: [PATCH net-next 1/2 v2] tools: ynl-gen: fix enum index in
 _decode_enum(..)
Thread-Topic: [PATCH net-next 1/2 v2] tools: ynl-gen: fix enum index in
 _decode_enum(..)
Thread-Index: AQHZtWmJfuKrBYUvlkKIn1akadqWPq+33AwAgAfiO4A=
Date:   Tue, 18 Jul 2023 16:30:02 +0000
Message-ID: <DM6PR11MB4657721B8CB36AEB67F1A8809B38A@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230713090550.132858-1-arkadiusz.kubalewski@intel.com>
        <20230713090550.132858-2-arkadiusz.kubalewski@intel.com>
 <20230713090234.28b04145@kernel.org>
In-Reply-To: <20230713090234.28b04145@kernel.org>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tFGgzJlwBP7xisxqjalhbBnq4ErWOayagHRdVReRstNMcZp634a0TnL1yEeb?=
 =?us-ascii?Q?jaoAJ+weXsPefjgDI3INCo9fNytFFiNEHdJrxGZgzY42xajGrHxudtcZYIgY?=
 =?us-ascii?Q?z9biidmt0pNOQGz4329vJbW77Gap5+ulrMt+fe48h5u2G8ZDRlc7IgXKVXV8?=
 =?us-ascii?Q?gQPFHpQ9LNsIc8aqo+Y9zjUBfMSqN6/Yy2CXoyGZi2S+OP0xMY5LKyo25ahC?=
 =?us-ascii?Q?jJSxqWYTJ1X01ubQfMGoicmY13+sBzzRDKQWEmDp0y+A2pXF6jZWviCtT5OA?=
 =?us-ascii?Q?sIAFXWXAypKLQZv52xBBCuDd6Qs3ppyQyDD5dEBn9uhTB9gdXnir4ckk34Y8?=
 =?us-ascii?Q?CoJiGjQxG0lI8uzllCW4v2ifSpgtXri6Ay+p6lC0d7d7MzpiLbzHSqNu2iK3?=
 =?us-ascii?Q?q4ENAbjbhye0oSnZ6Z17l6k/l/oBz6mR11oHKA2BorUTk41vH/jU0W0OgNJi?=
 =?us-ascii?Q?vO5TOwIDr8pdc55tfQq/xDu9HbbLCSRJBZQGqYYlS9TautbLyiH+j+zrYoKY?=
 =?us-ascii?Q?t+ECteRl1gjgVOm9OatM7qSTqhjWM+wQKgd3lw0fH2X9hPIlnNqAT8s99JEa?=
 =?us-ascii?Q?skapbaHUT/J9Vte7xahdVYQTWPnF/kPVlN4uDKiGS015GY013q9POdXnVNmY?=
 =?us-ascii?Q?iSn54Gc4PVTStkxe2VMvPjITxrFB2V6aVnfwJXjJWcUDBQYCGLl+wOGFBrQ/?=
 =?us-ascii?Q?ma0pbIXdebaoSW1TeECCGBR+SiI9/yzEXKOmjYhltr/qocZg7QCO/wQ7pF15?=
 =?us-ascii?Q?25aJ8OPrliCFFsQoGAWvNViXwKeCoS/LZpAQO9lAkViG9GB66kZz8O/UI+94?=
 =?us-ascii?Q?5ybcJ/qL6/wQh7r0zRpJV2ZlQARDCt4TyEBHN6Mkhlm+hA8bpib4h0eQfSRA?=
 =?us-ascii?Q?fENwKUDL7KNVFo9kCJwO1G3CV7fTNdKf90xZYxw4PhM9UarpEbvl/cY08M2+?=
 =?us-ascii?Q?lHN2clU6Zm0jFfSylNyA+OXg1AGINmRTJqBPBiwqq8xUaFAOEDPZ2TDtIqqO?=
 =?us-ascii?Q?zK1bx8w5oKIhjXvoB+B/wNqIt3hKtsE3Ca6O8WtZqPJfmZw+/nieR6uzp+lp?=
 =?us-ascii?Q?kOfVKoK1mq8yfqrHu81mcrvBIm6QsAX1RT0hPk3AlZf7MjWhttKC6DVS4BwL?=
 =?us-ascii?Q?oaEfJoaO0xOAVvYMJKCFOzTRAfRGHEgthJSZ67xk2fYsE4KadWtpAjx2Fb36?=
 =?us-ascii?Q?6sI3fOfzjEA82Gpn6kX+uJYnztyKpIYj1upVTRCHIu3IhtrUjwGTPkusM4MF?=
 =?us-ascii?Q?h60SDzEt1XCJEy/DYkx7dH7kZzDnIUPP4IVC+cvqponZtQ9mD/VPAB696g7n?=
 =?us-ascii?Q?32Tc2aIekZ9jWW6rZRdTxqs6fkCe5FEgsZm2oD+jrQd8WzxWrPRbpjJyB91X?=
 =?us-ascii?Q?cHsu6hImx9EMf+7L19bW+cOGnqmMuE4WFNZGWlptVqwlBeo+zlOXGw7wxQCw?=
 =?us-ascii?Q?X3mO9ufQoNYsNpDcd+4VVoTP6yvE4LhMt8wx5FIyJ3LAg4AZ+cpk6M8aEEft?=
 =?us-ascii?Q?6o9o4evStPRm5PtAyTZ+5e8DRG47UHt5kWvgAK1XzzUoS1p64smWVMN1lDHZ?=
 =?us-ascii?Q?G+hwxcrMp7Z/7RG2s+Ml41kqqpn2NefZ/zpyYq/wZzKlF27xWyCzsHiSpOva?=
 =?us-ascii?Q?RQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bfd8968-ff4f-4c5e-f870-08db87ac3cf6
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 16:30:02.9875
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +L0JT3/5Nar4VTbR8Hn7LQY8/WBr2PBXcdRgjYvn/PN67JHLo/wAiGMAGe1zol5En881DYNktHY1atE7l8Nbi1nUQtALJLXa+u7hZlZZKO0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Thursday, July 13, 2023 6:03 PM
>
>On Thu, 13 Jul 2023 11:05:49 +0200 Arkadiusz Kubalewski wrote:
>> -        i =3D attr_spec.get('value-start', 0)
>>          if 'enum-as-flags' in attr_spec and attr_spec['enum-as-flags']:
>>              value =3D set()
>>              while raw:
>>                  if raw & 1:
>> -                    value.add(enum.entries_by_val[i].name)
>> +                    value.add(enum.entries_by_val[raw & 1].name)
>>                  raw >>=3D 1
>> -                i +=3D 1
>
>This doesn't make sense, as I suggested you need to keep i for this
>loop. Move it to the inside of the if 'enum-as-fla... and init to 0.
>
>i is tracking which bit number we are at as we consume / shift out
>bits from raw.
>

Yeah, you are right, I don't think I had clear mind when created those..

>Have you ever used ChatGPT? No shame, just curious.

I have used it, but I am not using it to prepare code, this was my fault,
chat would probably do better..

Anyway just sent v3 with this part fixed.

Thank you!
Arkadiusz
=20
>--
>pw-bot: cr