Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 19:54:49 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
Subject: Re: ANNOUNCE: thunderbolt-utils-v0.1-rc1
Message-ID: <2023071834-audibly-proton-6a3a@gregkh>
References: <2dab15ba-efd0-97cb-dfde-fa6f9d05f5fb@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2dab15ba-efd0-97cb-dfde-fa6f9d05f5fb@linux.intel.com>
Precedence: bulk

On Tue, Jul 18, 2023 at 10:02:57PM +0530, Rajat Khandelwal wrote:
> Hi,
> 
> This is an official announcement that 'thunderbolt-utils', a collection of
> user-space utilities for the TBT/USB4 subsystem is now made public for its first
> release candidate.
> 
> # What is it?
> 
> The utilities comprise 'lstbt', similar in lines with 'lspci' and 'lsusb',
> which polls the TBT/USB4 subsystem's information including enumerated
> retimers.
> 
> The secondary component of the utilities is the goal towards providing
> a collection of available wrappers to provide the abstraction of configuring
> the subsystem in user-space. This is made possible via porting the DMA layer
> from kernel-space to user-space for the subsystem in an IOMMU-protected
> environment.

Cool, but it doesn't build as a normal user:

/usr/bin/ld: cannot open output file /usr/bin/lstbt: Permission denied

Why aren't you using autotools to properly be able to integrate into
everyone's build systems?

Also, you are shelling out to bash a lot, and as root, in this program,
are you sure that's ok?

And finally, why not add some of the USB4 stuff to usbutils?  Wouldn't
that be a bit more relevant for people who use those tools already?

thanks,

greg k-h