Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7180340rwp; Tue, 18 Jul 2023 11:11:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHEMogkw5fa82SGBi4Fh1uaLI11aOiKGfqv9AYYdVeFyEiNIAokI2lfTTur8GKht/ru0R0V X-Received: by 2002:a17:906:190:b0:993:d5e7:80f6 with SMTP id 16-20020a170906019000b00993d5e780f6mr457034ejb.5.1689703874788; Tue, 18 Jul 2023 11:11:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689703874; cv=none; d=google.com; s=arc-20160816; b=YiGL/XuInGgMC3OMVQkQiZmN3opkdVYEtIRM1cJBEtcAy69deptXtEV5DJNOQK06Dy ZxL3jmR0P9afYVVGIFw8yFxOGnuUAC3OeqSEMmbAs/RLhVDwIogiSEuEZ6rDKQ63Be+D wc7SXJjB7U27e17OBjDivzR+vM1DXhMnM35689Q+emTfbTAqHbZB0Nnrc3KNTwKXXjHI nfMzRqjFpW7NDNkZ0kfGJJUYYQdAmCCh/aI6HzfkYW3c4FDtavXjdxF1Dpx52ATchOkp xxXnDeujygWlp64v3isEx6MCnn1AGQFOEE7C9+mwlPKFnm6q/8RpSlC6AVVYvV/NxSi/ cmBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zfYlVwMS7Et8yaT5OVN/2j8VFtpsP1EgygCJigxCyfU=; fh=tPr9MoyxpR89E5t2QGOVAjuAThQBhi6NEUOstJDBxLw=; b=hiHQS0IDy8hIafETCLdz7pO/cm0pPotRxwpsfU1cPUyG0xYULC26VpSYYn//pVrd0S QaemMRlhpNrv73u3k0dEa/dUYXZ1hjI/1kKKufVmvbdX0K3sInWu7QgGOUBOzYOX5WMf WzYmB+Jr9P2yiTlyatBF5aGEVd0GJfUmg+Pj3qydq0U6k0d2uiWz461vIfQRbSFjRQUg +p3G2lOdQYJS0ZLbjQcj1bbS7gba8AchBba2DsVs3/OL89bhFgJW8dTety5goWfV4B2d htaERH4lra70RbtUgUmxjwbw0/wBA/gf1Xh2SYxvu1pvpKgWpAeEu5j3j1Of5wm0L3rr zdkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R1LzwR5a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020a1709064a8700b0098871664f55si1509277eju.800.2023.07.18.11.10.51; Tue, 18 Jul 2023 11:11:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R1LzwR5a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232413AbjGRRhe (ORCPT + 99 others); Tue, 18 Jul 2023 13:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbjGRRhc (ORCPT ); Tue, 18 Jul 2023 13:37:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90790E6F; Tue, 18 Jul 2023 10:37:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1CFD3616A8; Tue, 18 Jul 2023 17:37:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC501C433C7; Tue, 18 Jul 2023 17:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689701844; bh=J43/S4lutq118/A5V7YO0P4DU+erOplZ6RTbTJcyXXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R1LzwR5aDD8TXdJqJdZSkB7/GA6wxpVZ6fnubikPocdmnJ5tem7vZpnYowJFNbdIi B1YKxGR2ON9JVPgHbhs6Nft5EBG33UVV1yPBgVCT7qoqW4ude4jxxQovdxRjZeiFYp v+Mtz00ppX7ZIVi3E12AW8rwY5jgUivU7D4xW2Pw= Date: Tue, 18 Jul 2023 19:37:21 +0200 From: Greg KH To: Yogesh Hegde Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2] arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards Message-ID: <2023071850-festival-illusion-6399@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 10:09:41PM +0530, Yogesh Hegde wrote: > This patch fixes an issue affecting the Wifi/Bluetooth connectivity on > ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth > on ROCK Pi 4 boards") introduced a problem with the clock configuration. > Specifically, the clock-names property of the sdio-pwrseq node was not > updated to 'lpo', causing the driver to wait indefinitely for the wrong clock > signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper > initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards. > > To address this, this patch updates the clock-names property of the > sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node. > > This patch has been tested on ROCK Pi 4B. > > Fixes: f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth on ROCK Pi 4 boards") > Signed-off-by: Yogesh Hegde Why are you saying this fixes a specific old commit and not also properly cc: the stable@vger.kernel.org alias? Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.