Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9dc9674c-9aea-6e57-a7ec-2de954e12a90@intel.com>
Date:   Tue, 18 Jul 2023 20:28:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 RFC 1/6] page_pool: frag API support for 32-bit arch
 with 64-bit DMA
Content-Language: en-US
To:     Yunsheng Lin <linyunsheng@huawei.com>
CC:     Jakub Kicinski <kuba@kernel.org>,
        Yunsheng Lin <yunshenglin0825@gmail.com>,
        <davem@davemloft.net>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        Liang Chen <liangchen.linux@gmail.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        "Leon Romanovsky" <leon@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>
References: <20230629120226.14854-1-linyunsheng@huawei.com>
 <20230629120226.14854-2-linyunsheng@huawei.com>
 <20230707170157.12727e44@kernel.org>
 <3d973088-4881-0863-0207-36d61b4505ec@gmail.com>
 <20230710113841.482cbeac@kernel.org>
 <8639b838-8284-05a2-dbc3-7e4cb45f163a@intel.com>
 <20230711093705.45454e41@kernel.org>
 <1bec23ff-d38b-3fdf-1bb3-89658c1d465a@intel.com>
 <46ad09d9-6596-cf07-5cab-d6ceb1e36f3c@huawei.com>
 <20230712102603.5038980e@kernel.org>
 <9a5b4c50-2401-b3e7-79aa-33d3ccee41c5@huawei.com>
 <20230714105214.39ad4e4d@kernel.org>
 <6c94f7b8-f553-1fce-f3f1-66cdead9e056@huawei.com>
 <20230718111621.35a64a0b@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230718111621.35a64a0b@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXUwYjZTR25US1RPaXF4ZlpQaCtnQ3JrZmdOeFR1ZFdEWkVNd3hldXl0WVEr?=
 =?utf-8?B?bkFsNmNGYTVESW5jWFlaeEozaStFL2FtRjRCTmFIc2paYkZJUzQxb2JKR2cx?=
 =?utf-8?B?dFRuQzVvQW1CclJCZXFBR0VLRDZkSGlOSW5CYStUZENqY05MWGYwSVRhUm53?=
 =?utf-8?B?ZStHNGVsRU55SVJScFpQTHY2MVRxT2NNaXlXTXZOYUszVHRZMzJOYkpTM2tj?=
 =?utf-8?B?REw2My9MMGIrZ1lRMGZDSFhIdWxiVmR0RWJWY0NwWFJFYTlhRTkxSThMZEkv?=
 =?utf-8?B?UWZwY1BOWFpybzNVWUlTUG1iN0FLcjZReE1hZ1JqTnBzZEgxNkh6WmQzV3N6?=
 =?utf-8?B?ZTh1b3dkdVVvMXAyZ3ZoM1ZXYkEzaTkzK0ZyYzNaSkp3Y3lzSDFNNmIzSm82?=
 =?utf-8?B?TVg3UWswc0V2NEEyTHBzTW9sd0dQVXdMZHRRSWlldlJvWlF3TDV3YUJiY2RP?=
 =?utf-8?B?THhGOXNDRTEzQVZndjdKQVF4c2UxZWlDa1ZBN0o4U290OUNPbngyMEdLa1px?=
 =?utf-8?B?WlNwWlFBMDltTWx6cEd3SUgrNnB6TWpJOU1BQ2NrekhyaFFheDBxd0tDalJu?=
 =?utf-8?B?VU9YaloyMUlOT1c5d3RJQ0hPZUdtKy95eDN1WVhKb0k3RVFPZjV2dkRKN2ZK?=
 =?utf-8?B?U1FwWndsT1JGWWMwWjBnTEZQaS9TalIraHdDV2pBOVZ5RThKMVVVVm9QQkx1?=
 =?utf-8?B?MGl3Rk1ncytFMTFVcE1hSGlLQ2FmaUo0ajlPQzk1YXZlNkV1VHQvdm5tQ0dN?=
 =?utf-8?B?TTBORXlOVFhQdklxY2FKS2xqdUZRM1gxeExvRGdweUJyZHpuUzdGbWU2eWtN?=
 =?utf-8?B?ZUtob0VmNnB6RDVxc1VPNjVrQkVlNys5YVFDNVJPZ3cveStUUTc5YTJHdWs3?=
 =?utf-8?B?RXEyNEtseXdIR05ONHBtYk52Uzc4ZTdFWFFJYVRWb3paUGcyNXBySnE0blJO?=
 =?utf-8?B?bitidm9aa1VvMCtHdU42OGphQXBZaGp5eGREZ1cwUHphQXNFbGFqVm1lMTYw?=
 =?utf-8?B?N0NwVkt2SXh1NEVYblZoeTlBY3oxY0dvcHBnanVjTDFsbnFtWWFxNDVNMHZw?=
 =?utf-8?B?dVU2L0pXdCsxZzdNT0JPdkU0NUd2R3ZpZXRQcEo5ZWMxaTlka2lFWjR6R0pF?=
 =?utf-8?B?eGtyVWlDaVhwcFAvMC9vUC9vVGJ0RlBFOUJNMmVJNnd6dCtpZ0pkeU82clpV?=
 =?utf-8?B?TjZiN1RXSUNycitVZ04rZGpYaWxYd2RBQlhwYTY5ZXFyQ0RhUVV2RmtiWnI4?=
 =?utf-8?B?Z0tTSkRBN3E4amVUSTB4RnJ0Ty9rc2RSdG5ZNW9vVTBLcWFEb2c5cUlubHJU?=
 =?utf-8?B?QnE4OEdwUjdBRFZoQXlrWnZxRU56R1NDOHVTL0ZWWUhSQ0hrd0xSSzJ1SU1O?=
 =?utf-8?B?Q3QydjY2blJFNFpGM1BtZmowMmJXdjNremhRVmx3bFJGNmNYZDlGMkpkajVD?=
 =?utf-8?B?S2ZURTJ4M2RTTHc4cHRTNjVDa0F4NURkN0crekNrVnplcEZYS0h1amc0eVVa?=
 =?utf-8?B?bEplOFdjaVI2MDB4ODg2K1BYaUkvMndUWXg2TE1WQ3EyelJXV2IxM0dPb3Ar?=
 =?utf-8?B?eGJRWkN3WXBvZnNQNmFZeXlFaUE1YmlPNW1nK3ovTUFEZGFFeFU4NDlIZFd2?=
 =?utf-8?B?ZE56cHd0N0VJTkthRk0zZkJRUEZ2dzUrclZ2S2JKamJveW5CenJ6Sm9OSHZB?=
 =?utf-8?B?ZDUrY1JHMTc4TU53N2dXa3dTQVJ1aGw2dS9mR3VMdkpVRllNbjNtZC9IbHA4?=
 =?utf-8?B?TU1LNVJlalZwbDhsSzZKQ3I3bnJ1dW93NHpuVHJRS3N4SlRoeVR0OGVlZHlo?=
 =?utf-8?B?RDJFTjFRclpDOGtWMzd2TVB3U3IwNHlxeDJ5a1JFTVludHAxZlVGS0lJdm1Z?=
 =?utf-8?B?eXJIaWdDd2JUSVFVUnRHaFJIOWtmMmtPWEI0cEJPOUE4eWY2eFRxM0hTSUFw?=
 =?utf-8?B?T255UXNmTUFvK3k0Rm1CcnJnTnNpYStBK1ZneE8zSmh5OWpaVXNwVk1SYmh0?=
 =?utf-8?B?ZkV1OW1BUkJDR3RJeHVsTjRhSG4yZnpLNU53bXVUSFN4RHVDOTJvaU4vUWNi?=
 =?utf-8?B?cGpyQjVZYW8vK0dlSTh3K1d0MmVNSGpRaVEzT2JSeFBINGdiU1ZZbFowT0tU?=
 =?utf-8?B?eWpvR291OHplZzNTWFJEbnlWSXdmdS9JMWxqbFNmYjMzZE1nOHIwOE5Nb1BZ?=
 =?utf-8?B?TVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1324b9a2-3f22-44ec-82ae-08db87bcf694
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 18:29:46.6063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M+b/zIthomf3DsEREialqdotkgYmDG/YWStYXLtwx3128d9JATuoBpfLVuwtuqg/ihqZVJATqaYPuXS+0jlFb5NHHVpcS57uJQKELJKC7io=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7733
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 18 Jul 2023 11:16:21 -0700

> On Mon, 17 Jul 2023 20:33:05 +0800 Yunsheng Lin wrote:
>>> Only those used in function prototypes. Pointers in structures 
>>> are somewhat special and don't require fwd declaration.  
>>
>> I gave it a try to split it, and something as below come out:
>>
>> https://github.com/gestionlin/linux/commit/11ac8c1959f7eda06a7b987903f37212b490b292
>>
>> As the 'helpers.h' is not really useful when splitting, so only
>> 'page_pool_types.h' is added, and include 'page_pool_types.h' in
>> 'page_pool.h', does it make sense?
>>
>> As Alexander is sending a new RFC for the similar problem, I think
>> we need to align on which is the better way to solve the problem.
> 
> LGTM, thanks!

Looks nice to me as well.
Re "which way is better" -- they can coexist actually. skbuff.h won't
lose anything if doesn't include any PP headers at all after my commit,
while yours also adds some future-proofing, as you never know when the
same story happens to some other header file.

(BTW it would be nice to inspect page_pool.h users whether each of them
 needs the full-blown header)

Thanks,
Olek