To: Zach Brown <zach.brown@oracle.com>
Cc: David Howells <dhowells@redhat.com>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co.	[try #5]
References: <20071025163352.5057.59344.stgit@warthog.procyon.org.uk>
	<20071025163357.5057.35399.stgit@warthog.procyon.org.uk>
	<47212215.8080003@oracle.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 25 Oct 2007 16:38:38 -0700
In-Reply-To: <47212215.8080003@oracle.com> (Zach Brown's message of "Thu, 25 Oct 2007 16:09:09 -0700")
Message-ID: <aday7dqzrwh.fsf@cisco.com>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.20 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 642
Lines: 16

 > > +static inline void *ERR_CAST(const void *ptr)
 > > +{
 > > +	return (void *) ptr;
 > > +}
 > 
 > Just to nit, surely you don't need the cast inside the function.  The
 > casting happens at the call site between the argument and returned pointer.

The way it's written you kinda do, since it takes a const void * and
returns a plain void *.  But I don't think that's the best way to
write it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/