Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7316557rwp; Tue, 18 Jul 2023 13:25:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlH/XsvRj6yoGl+vfVFwdGjRif8OC9lqpONGD9/MDGqyIrSLKG9oe9zo5e7aSJHfisUplIgg X-Received: by 2002:a05:6a21:3389:b0:125:6443:4eb8 with SMTP id yy9-20020a056a21338900b0012564434eb8mr474697pzb.5.1689711910851; Tue, 18 Jul 2023 13:25:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689711910; cv=none; d=google.com; s=arc-20160816; b=yG+/22XaAx3qV5VupmYgZ2GkuZOs2jCirYcBb2ApOm9rCGLaa9lSQBKzV3kQy6eD/5 7oJlnUMvc+mnkTi6SJ5Mzqhd5nmz/qc3u29GYvlEAc5S/fZFHzX9O5Xl1slruRXK5K+5 ViG9G5266lYirlP2umQ3G73BADt4uXskW6ZDKNIErb9wjg6WjM27aEhsU5WjRApFuCrj caRS2Ly0bXhE4+MGwyHtWTQ+A+ycFcE90tCPeSKdJh15EFjGAx8DEMf64nKllYWyG+/U 7x8fRCwoJ36ZBkJf7nKa2dkCEl8rrFwFr0v8y1LLJIPMBjfAZDBm6rMH4dBXAyenn6Yn JvlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JcHNL3a69uZIHkUdSEgchC92wu1+8vIvXIawZDtpUb4=; fh=4Na2BilZ6VF6dXmDywSyCbvCivJ2qeBXENM4KArNk/A=; b=ymqJC5ouQDSdxxORe1cHRWoJQpjPTaDwkxh1vk6SM5hY5CXw8IzI3NIH5uQGtjtHfQ l+8ea+An7yN6B1VSBarVNc4Lwo2FsyegSsjtnXHaH17GroV2qoiGiDQ9SKPO4BMdw2nK EYdKlAzuMWJCCrZgCQNn/ZdqDisZ7AfTY5kBjb+8kR+wH9yOHWqmFm+T00GBWZ7rUtCk 6GpAL5J2oyI45AuQwVkeBEh5LUuxPvsiQzJKG+5ASheHoOfrSXOMqtp+OE674YzrpkPo 19YvqQNL23zCYC1WVB407BA72bWP4x9cmnz7R2GGFfiEy6W9FTFnv5Jp5SzsJxAZ52P4 rlVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ifjb+2EV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cj22-20020a056a00299600b006819405e9d9si1995956pfb.145.2023.07.18.13.24.58; Tue, 18 Jul 2023 13:25:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ifjb+2EV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjGRUQz (ORCPT + 99 others); Tue, 18 Jul 2023 16:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbjGRUQy (ORCPT ); Tue, 18 Jul 2023 16:16:54 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 312DAF9; Tue, 18 Jul 2023 13:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JcHNL3a69uZIHkUdSEgchC92wu1+8vIvXIawZDtpUb4=; b=ifjb+2EVEa5UWdvG2Oi7hlfSD2 0gv9PHEmRfK71DBmFd+JtmT8JxzqmTdOaMIdpXif9oBeC/yIA85G+fEma7vkL2+y/ZhYUolIhjq3X u5e9j9mGlcrknJCU0pxRCog6h23PaSOe05MOk8Ccd4wWzysTWZWcNAGzfyqvPeHwh5vE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qLr7d-001efI-VJ; Tue, 18 Jul 2023 22:16:37 +0200 Date: Tue, 18 Jul 2023 22:16:37 +0200 From: Andrew Lunn To: Michael Walle Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Florian Fainelli , Broadcom internal kernel review list , Marek =?iso-8859-1?Q?Beh=FAn?= , Xu Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH net-next v3 03/11] net: phy: replace is_c45 with phy_accces_mode Message-ID: <16c19cff-cca7-43fa-97a8-c4e74f033b0b@lunn.ch> References: <20230620-feature-c45-over-c22-v3-0-9eb37edf7be0@kernel.org> <20230620-feature-c45-over-c22-v3-3-9eb37edf7be0@kernel.org> <509889a3-f633-40b0-8349-9ef378818cc7@lunn.ch> <66d9daa106d7840e972dba35914e6983@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66d9daa106d7840e972dba35914e6983@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Maybe we need to clarify what "has c22/c45 registers space" actually > means. Responds to MII c22/c45 access? No. That is not what it means to me. Bus transactions and register spaces are different. There are C22 registers, and there are C45 registers. The bus can do C22 transfers, and it can do C45 transfers. C22 registers can be access using C22 bus transfers. C45 registers can be accessed using either C45 bus transfers, or indirectly via C45 over C22 transfers. Currently, there is no C22 over C45, but given the oddball Realtek PHY Russell is talking about in an SFP, it might have a proprietary C22 over C45? Andrew