Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95e0287d-3211-3c0d-7a52-740acdb75f45@gmail.com>
Date:   Tue, 18 Jul 2023 21:56:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] staging: rtl8192e: Rename variable bCurrentHTSupport
Content-Language: en-US
To:     Tree Davies <tdavies@darkphysics.net>
Cc:     gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <ZKYgH/BvkE9bdcPm@kimchi.darkphysics>
 <6dee04ae-4129-cd7c-0d31-70d29b86c8ff@gmail.com> <ZLL+Q0tcW5S8Xjmj@basil>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <ZLL+Q0tcW5S8Xjmj@basil>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/23 22:14, Tree Davies wrote:
> Philipp,
> 
> I think I understand what I did wrong. Each of these original patches were
> created/based from the same commit hash. So it makes sense that only the
> first one applied would apply cleanly and the others would fail.
> 
> My apologies,
> Tree

Hi Tree,

you could work this way if you ensure that each patch does not modify 
code (and some lines above and below) a previous patch modified. But it 
is not a good way to do so. Existing tools assume that you create your 
commits onto each other and then make patches out of them.

Another issue right now is that approximately 18 patches send in and are 
possibly applied (for rtl8192e). Your patches need to fit onto those 
patches. Otherwise they cannot be applied and will be rejected.

Typically Greg applies all patches once a week. But it seems that he has 
a bunch of other more urgent tasks. So you need to focus on other kernel 
related task like educate yourself or prepare patches without sending 
them in.

Thanks for your support.

Bye Philipp