Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230718192453.543549-1-fabrizio.castro.jz@renesas.com> <20230718192453.543549-3-fabrizio.castro.jz@renesas.com>
In-Reply-To: <20230718192453.543549-3-fabrizio.castro.jz@renesas.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 18 Jul 2023 22:58:46 +0300
Message-ID: <CAHp75Vc9DG69pbCACB9o6=1pFDHYUkzwi6siXNOywQ-_Uzb4vA@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] spi: rzv2m-csi: Improve data types, casting and alignment
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das@bp.renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        linux-renesas-soc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 18, 2023 at 10:25=E2=80=AFPM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
>
> "unsigned int" is more appropriate than "int" for the members
> of "struct rzv2m_csi_priv".
> Using void* rather than u8* for txbuf and rxbuf allows for
> the removal of some type casting.
> Remove the unnecessary casting of "data" to "struct rzv2m_csi_priv*"
> in function "rzv2m_csi_irq_handler".
> Also, members "bytes_per_word" and "errors" introduce gaps
> in the structure.
> Adjust "struct rzv2m_csi_priv" and its members usage accordingly.

Hmm... A bit of fancy indentation. Why is each sentence separated?

...

>         wait_queue_head_t wait;
> -       u8 errors;
> +       u32 errors;
>         u32 status;

As far as I understand Geert he wanted something like

  u32 status;
  u8 errors;

...

> -               u16 *buf =3D (u16 *)csi->txbuf;
> +               const u16 *buf =3D csi->txbuf;

> -               u8 *buf =3D (u8 *)csi->txbuf;
> +               const u8 *buf =3D csi->txbuf;

> -               u16 *buf =3D (u16 *)csi->rxbuf;
> +               u16 *buf =3D csi->rxbuf;

> -               u8 *buf =3D (u8 *)csi->rxbuf;
> +               u8 *buf =3D csi->rxbuf;

Yep, these look much better now.

--=20
With Best Regards,
Andy Shevchenko