Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "Devale, Sindhu" <sindhu.devale@intel.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/irdma: fix building without IPv6
Thread-Topic: [PATCH] RDMA/irdma: fix building without IPv6
Thread-Index: AQHZua9+pH4mO804dUWGwvttR0llLq/ABrtw
Date:   Tue, 18 Jul 2023 21:17:18 +0000
Message-ID: <MWHPR11MB0029128131B076B77BA55078E938A@MWHPR11MB0029.namprd11.prod.outlook.com>
References: <20230718193835.3546684-1-arnd@kernel.org>
In-Reply-To: <20230718193835.3546684-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OlyoxaUw5mPmIEPvtyLfWiS1DZxxQxH6kuUQqpzuGj7Lv0qH4wFY16QD+sKC?=
 =?us-ascii?Q?+SpoUvPLBJvwnVzwNdZ+OSsO6FqTgUM3GQ2bJR2so395K/yhqwSE3nKmSPLR?=
 =?us-ascii?Q?msdMF6F5Sg6SVtOc/OU8vS/Rg0IULz2OXibuLZVJ/kekQIRMoEodfUmM1Uir?=
 =?us-ascii?Q?ZHGz25SeVqfP8zH2a7j2uCDMob19JcmHzRdazsQly7KkOEdGK9cu0pJ6Iqhq?=
 =?us-ascii?Q?QjRE7VpKqo1lR+V0HVPnKMWVmpBRA1uTvgsa9jvzr+3Q71uc6q/UCcJxokFD?=
 =?us-ascii?Q?K/VMbfNoWacQkO12opW0TbwGP1bGjIisL2RJ3kR5vjD71g7Sum3o4fbk/e5n?=
 =?us-ascii?Q?LAOuQoD4xZ6i2eD1YbZIqb1m3SOjec0pA2QVWo+Mqo2EePqyyAcGG//zaWeH?=
 =?us-ascii?Q?pi8BIsbZK/WvtTfjQOr8nLZsViLyk/T48PEDWOlklWJMPabb6qYxWoO87fIs?=
 =?us-ascii?Q?GQR9xtYZVHMCtQBggeeDZ2XILGSA8jDI/XPAqWRyw2/IQ4GI4cd4q+moZf3H?=
 =?us-ascii?Q?Qb3SvgR4NbXFPLaUo5EfwZEa4WT2k+EDEy+5Mge/LxBYVaU04kv3yOGdF45O?=
 =?us-ascii?Q?WKExQ7D+zmqEuvmxcLWDfVJUdCZQxnnM/PnZjnSEG12zdu/qR0wo4FKt+Etl?=
 =?us-ascii?Q?fxJRblRUb6sgQuiwZ5LNglL8nmSZJ4CmJRFY/FrtJM812s2JDAB/BKrMkk40?=
 =?us-ascii?Q?CeOYdulByjAoGibTLo07gjyvXOmk0TzUwG4UufHSct8QzcfkPFWWTtzouNi2?=
 =?us-ascii?Q?LDqvRWrtLkPAS9wezSxLtlPMhJjByGA+9zfnDc3tRWqxQJAyTmctm8D+867S?=
 =?us-ascii?Q?pEeS4hoDNIAzTOR7yIe0Oix0ZGaRbkppkhfcJeIeQq2ilkjw8LupzY9gkao1?=
 =?us-ascii?Q?rk7Nf0Z/0hERzgfSg3b1mJojUkQWuOFoHyU8dzD2t39Y8E3liaBnuW2SPQHQ?=
 =?us-ascii?Q?YkjEvle7PD4e8pnC1MSRyplgrmTldyu8+69355idnnElOFQ6+X9Ztzvc/O1U?=
 =?us-ascii?Q?RQfPhqdxG2l6o/zNrIf6mHfdOY2RBdck/O6t80pJQukjMKp/sSC0Jrnqjj/d?=
 =?us-ascii?Q?kXIj+tt/W/Bkx21jgvtS2Wd9Kmk//2/YHph5k2BYXsT7sfVI9QcToa5LjQw6?=
 =?us-ascii?Q?LFMhOSNg6/gpts1adz4rBO5FopR9pQq7Epi9+NNfucz9wQEuouL4E7yqoG7s?=
 =?us-ascii?Q?3+a62mLO72x7pFhFHGsJ0lxKPHSDVG0jbYjtLuTBSr+RU3rGOlCuE6kbHNNT?=
 =?us-ascii?Q?kkfjGQ0Vgv6i/7QIF7NYnfOs5gei1H6Xh+Hq6Mw6krH3dScmiJbObKWXgGip?=
 =?us-ascii?Q?salvFEquO8+KQKcBWOXL62WF9gOGQH21MwU4R9L+Q+gDljfrst7XDiJFFqxx?=
 =?us-ascii?Q?Bu6BFuMUjoG1YC0Sma+Q+nLGRngNHj0bKlj1PkzYT8ouuJ5eokI2ICVHgeWw?=
 =?us-ascii?Q?D1npL9PuVSSghYC8CKW+3Q4oyJcuJNswVj1/87eX0eCvEH3tRJZhzJCmHjBp?=
 =?us-ascii?Q?y+4Xa4XVSbQmO1LLO4VKLe9hotp7ClDCamUVuLXCqNjCa2GQ39fDt6yo/mVG?=
 =?us-ascii?Q?+nI+Cfc+OeSfVDk+bD2DO9OzSCVpra1nJ73j9zgs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0029.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76282bf0-eae0-4f48-c1a4-08db87d45e05
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 21:17:18.3303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mQSTbLb7nipcVTCW5/EqRXbDYoIdikdRda9XvGSLMofayvkrLr8M3rV9LTwlNzzBpycz1F8okDyCx76W5BVj2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6940
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] RDMA/irdma: fix building without IPv6
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The new irdma_iw_get_vlan_prio() function requires IPv6 support to build:
>=20
> x86_64-linux-ld: drivers/infiniband/hw/irdma/cm.o: in function
> `irdma_iw_get_vlan_prio':
> cm.c:(.text+0x2832): undefined reference to `ipv6_chk_addr'
>=20
> Add a compile-time check in the same way as elsewhere in this file to avo=
id this by
> conditionally leaving out the ipv6 specific bits.
>=20
> Fixes: f877f22ac1e9b ("RDMA/irdma: Implement egress VLAN priority")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/infiniband/hw/irdma/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/ird=
ma/cm.c
> index 6b71b67ce9ff0..8ea55c6a3fba5 100644
> --- a/drivers/infiniband/hw/irdma/cm.c
> +++ b/drivers/infiniband/hw/irdma/cm.c
> @@ -1562,7 +1562,7 @@ static u8 irdma_iw_get_vlan_prio(u32 *loc_addr, u8
> prio, bool ipv4)
>  	rcu_read_lock();
>  	if (ipv4) {
>  		ndev =3D ip_dev_find(&init_net, htonl(loc_addr[0]));
> -	} else {
> +	} else if (IS_ENABLED(CONFIG_IPV6)) {
>  		struct net_device *ip_dev;
>  		struct in6_addr laddr6;
>=20
> --
> 2.39.2

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>