Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Peter Keresztes Schmidt <peter@keresztesschmidt.de>
Cc:     x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wei Liu <wei.liu@kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>
Subject: Re: [patch 50/58] x86/apic: Provide common init infrastructure
In-Reply-To: <ffc889de-3181-791e-f985-ce461b992bfc@keresztesschmidt.de>
References: <20230717223049.327865981@linutronix.de>
 <20230717223226.058365439@linutronix.de>
 <ffc889de-3181-791e-f985-ce461b992bfc@keresztesschmidt.de>
Date:   Tue, 18 Jul 2023 23:51:34 +0200
Message-ID: <87zg3sx509.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Jul 18 2023 at 23:29, Peter Keresztes Schmidt wrote:

> Hi Thomas!
>
> On 18.07.23 01:15, Thomas Gleixner wrote:
>> --- a/arch/x86/kernel/apic/bigsmp_32.c
>> +++ b/arch/x86/kernel/apic/bigsmp_32.c
>> @@ -119,10 +119,8 @@ bool __init apic_bigsmp_possible(bool cm
>>  
>>  void __init apic_bigsmp_force(void)
>>  {
>> -	if (apic != &apic_bigsmp) {
>> -		apic = &apic_bigsmp;
>> -		pr_info("Overriding APIC driver with bigsmp\n");
>> -	}
>> +	if (apic != &apic_bigsmp)
>> +		apic_install_driver(&apic_noop);
>
> Could apic_noop be a typo? Shouldn't it be apic_bigsmp?

Indeed. Good catch!

Thanks,

        tglx