Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7419169rwp; Tue, 18 Jul 2023 15:16:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlET91D+8lPAYKFrsMTr/Y3RZwyiiuHnIYDfDXw6Dj588jWWCjMt+tpNKHAGHp6v74TDspF/ X-Received: by 2002:a50:ed87:0:b0:51f:e0f0:c634 with SMTP id h7-20020a50ed87000000b0051fe0f0c634mr463829edr.14.1689718604462; Tue, 18 Jul 2023 15:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689718604; cv=none; d=google.com; s=arc-20160816; b=Q+mDRBg8djjZjwk5xYGuY4ZvkTBRS+CtWGeiDQl06TLcmhxE89V1bRC+rQq4z+4xj/ WmSeAax4iYQAVpTziFRAmbuuwW6PZZib2N+ySXYDKWmJljgY4yNXIPURnpkbQNQ2cPSB fQZl5ukQcYwO4zzwrTNjeEL3r2Mmz0mO6fW8eBpRs+5kf+UX5UpiKXy87XE9KML88lhL ybu82J0/JRKR55IJv7p67AWTqCTR5E5iT+mwoM2KHFrRGz59V6j6Fhd0BSw7kOGTH9Se zwEgqBGMMhekHLTL6s8tl3ION33BMu+bZRuCj8MHUK59AB9egOtLhgGYt/PXVmWnfuhO ozIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:subject:cc:to:from :message-id:date:dkim-signature; bh=5u8rf6YcuhUx0bAV6M5NJKe6fFdJ31NMIG3OGKzC1iw=; fh=zOdTh2zTjJiNrBG1kFVcf98gVI/1jQma2FGYQ18uIgo=; b=h4gUWFsR7r9yurxfYDsc2Pxcy8guGsAO70o4nj9Et8r6zc/wOQfmehR1YOevujfmSL PbxJmzO+pmVgGMBrNCCMEz9+iWcVCAfThv3KrixcRPbN7tnnsYh1esgQgctesSNrB2if UWMaAdzivAH8am1XsIpSZ7jjvHXfmxyG/lXcBI3SRasZSPrhZK2vdZ/kf4Eu8tg8541D CIIMx5fglU/jamoW4An+OLh+lhZs6+ikzwJvtvJWARbKOe24Lso8dHRIK9qzzyyvriqN LbayzZuwlSQJ/yv9m0VDdlM/iwZktVkSN3a4Ge+ElasLFic2Zwr0AjCQ38pFYNGhZd1x Zx/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=MtC4IxPZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x1-20020aa7cd81000000b0051a5a6676dfsi1973861edv.23.2023.07.18.15.16.17; Tue, 18 Jul 2023 15:16:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=MtC4IxPZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbjGRWB2 (ORCPT + 99 others); Tue, 18 Jul 2023 18:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbjGRWBR (ORCPT ); Tue, 18 Jul 2023 18:01:17 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD0B6199A for ; Tue, 18 Jul 2023 15:01:16 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-63719ad32e7so36943116d6.1 for ; Tue, 18 Jul 2023 15:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1689717676; x=1692309676; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=5u8rf6YcuhUx0bAV6M5NJKe6fFdJ31NMIG3OGKzC1iw=; b=MtC4IxPZlQ5NdOu3NrmtRF0XJHMdQP5wjUTvI/pGec5UCKUdl5xGJ/OE3zycYrbwJm UW20uG4KmyHE87Qn43YqYXp8NlocGepmO2SPJekKWOGx1DjBpJsPx4+Ftnmhm0zIgLTj h8n+mxkrf2qQNWJxXttdqYmaPTp6rUR34pwyXTTFsovRihA9mCvh9Crr1BesBEWyEK+a Ln4b3ZOyYbNaSIaCHz7BYhztDlu2kKt6ylyQ0FAVuvn1xMgb5Ic4ZKl+RPGG2lHI8WUr nKPmxIScGYJaZR71u7+W5fRZKm9QxPe2TCvPXGxZSeKaPlB7MEUxO9idfPb1ppy38XxR QEHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689717676; x=1692309676; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5u8rf6YcuhUx0bAV6M5NJKe6fFdJ31NMIG3OGKzC1iw=; b=RuogoiKwwUqD8887iCDbTQAua3ywE0nqpKdACWAFy+r64wyuDM8RxZXHTYqjrUM86H WheJTCeypCX9v0LsOLJYDzsRQsuf5cSStezf1AEULOxp58O8fPE08mMrhFVJqUAq/jHv eXDeDLg4NydgpUksQxK1etSsjWI16rHwShPpMeEa6T3tSurSuWPtrrH5XSEemMTGG0dg 4K9q7E26N0mwNsULJjoouaVenVSKtwwvrjPp8wFQhct95aLiUu2yy7p/vpX8G75Rfzyo NX/BIkyiGbZ/HiOfVZ2C3q/NDyEGXdLum0rJdMh2MmvWuonzZQy1FK8VosnPU/Q+hC/O 87cw== X-Gm-Message-State: ABy/qLYRSmforgN2gzeYFKxyvOTjOVCNpAk8kq4s1xN5csrpNLRT/BN9 1gKl2NoeNFSkqeRmFFt6R3j5 X-Received: by 2002:a0c:e64c:0:b0:636:1bcf:7aa5 with SMTP id c12-20020a0ce64c000000b006361bcf7aa5mr14003670qvn.21.1689717675867; Tue, 18 Jul 2023 15:01:15 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id pz10-20020ad4550a000000b0062feb88e56fsm991901qvb.140.2023.07.18.15.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 15:01:15 -0700 (PDT) Date: Tue, 18 Jul 2023 18:01:15 -0400 Message-ID: <2f0958af087bcccd8b8f75fa641d9787.paul@paul-moore.com> From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , selinux@vger.kernel.org Cc: Stephen Smalley , Eric Paris , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 4/20] selinux: ebitmap: use u32 as bit type References: <20230706132337.15924-4-cgzones@googlemail.com> In-Reply-To: <20230706132337.15924-4-cgzones@googlemail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,PP_MIME_FAKE_ASCII_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 6, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > The extensible bitmap supports bit positions up to U32_MAX due to the > type of the member highbit being u32. Use u32 consistently as the type > for bit positions to announce to callers what range of values is > supported. > > Signed-off-by: Christian Göttsche > --- > security/selinux/ss/ebitmap.c | 32 ++++++++++++++++---------------- > security/selinux/ss/ebitmap.h | 32 ++++++++++++++++---------------- > 2 files changed, 32 insertions(+), 32 deletions(-) See my previous comment about loop iterators. -- paul-moore.com