Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac9bff47-8e2f-a6f3-8a59-e92fc7eb1199@linux.ibm.com>
Date:   Tue, 18 Jul 2023 16:57:01 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] fsi: Use of_property_read_reg() to parse "reg"
To:     Rob Herring <robh@kernel.org>, Jeremy Kerr <jk@ozlabs.org>,
        Joel Stanley <joel@jms.id.au>,
        Alistar Popple <alistair@popple.id.au>
Cc:     linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20230609183056.1765183-1-robh@kernel.org>
 <CAL_JsqLTc_9Yujp=wJjjn7P5YwAFZ9fn2SU6ey1q_gY3MFp9TA@mail.gmail.com>
 <CAL_JsqLNg00Z81cpSAOtwVWnfuQMoy2veBcHUHNby1Qh35mLTw@mail.gmail.com>
Content-Language: en-US
From:   Eddie James <eajames@linux.ibm.com>
In-Reply-To: <CAL_JsqLNg00Z81cpSAOtwVWnfuQMoy2veBcHUHNby1Qh35mLTw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/18/23 14:03, Rob Herring wrote:
> On Fri, Jun 30, 2023 at 3:02 PM Rob Herring <robh@kernel.org> wrote:
>> On Fri, Jun 9, 2023 at 12:31 PM Rob Herring <robh@kernel.org> wrote:
>>> Use the recently added of_property_read_reg() helper to get the
>>> untranslated "reg" address value.
>>>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>>   drivers/fsi/fsi-core.c | 39 +++++++++------------------------------
>>>   1 file changed, 9 insertions(+), 30 deletions(-)
>> Ping!
> Is FSI still maintained or should we just remove it?


Yes, it is.


Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
>>> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
>>> index 0b927c9f4267..19c4d5b3bde9 100644
>>> --- a/drivers/fsi/fsi-core.c
>>> +++ b/drivers/fsi/fsi-core.c
>>> @@ -16,6 +16,7 @@
>>>   #include <linux/idr.h>
>>>   #include <linux/module.h>
>>>   #include <linux/of.h>
>>> +#include <linux/of_address.h>
>>>   #include <linux/slab.h>
>>>   #include <linux/bitops.h>
>>>   #include <linux/cdev.h>
>>> @@ -415,28 +416,18 @@ EXPORT_SYMBOL_GPL(fsi_slave_release_range);
>>>   static bool fsi_device_node_matches(struct device *dev, struct device_node *np,
>>>                  uint32_t addr, uint32_t size)
>>>   {
>>> -       unsigned int len, na, ns;
>>> -       const __be32 *prop;
>>> -       uint32_t psize;
>>> +       u64 paddr, psize;
>>>
>>> -       na = of_n_addr_cells(np);
>>> -       ns = of_n_size_cells(np);
>>> -
>>> -       if (na != 1 || ns != 1)
>>> -               return false;
>>> -
>>> -       prop = of_get_property(np, "reg", &len);
>>> -       if (!prop || len != 8)
>>> +       if (of_property_read_reg(np, 0, &paddr, &psize))
>>>                  return false;
>>>
>>> -       if (of_read_number(prop, 1) != addr)
>>> +       if (paddr != addr)
>>>                  return false;
>>>
>>> -       psize = of_read_number(prop + 1, 1);
>>>          if (psize != size) {
>>>                  dev_warn(dev,
>>> -                       "node %s matches probed address, but not size (got 0x%x, expected 0x%x)",
>>> -                       of_node_full_name(np), psize, size);
>>> +                       "node %pOF matches probed address, but not size (got 0x%llx, expected 0x%x)",
>>> +                       np, psize, size);
>>>          }
>>>
>>>          return true;
>>> @@ -653,24 +644,12 @@ static void fsi_slave_release(struct device *dev)
>>>   static bool fsi_slave_node_matches(struct device_node *np,
>>>                  int link, uint8_t id)
>>>   {
>>> -       unsigned int len, na, ns;
>>> -       const __be32 *prop;
>>> -
>>> -       na = of_n_addr_cells(np);
>>> -       ns = of_n_size_cells(np);
>>> -
>>> -       /* Ensure we have the correct format for addresses and sizes in
>>> -        * reg properties
>>> -        */
>>> -       if (na != 2 || ns != 0)
>>> -               return false;
>>> +       u64 addr;
>>>
>>> -       prop = of_get_property(np, "reg", &len);
>>> -       if (!prop || len != 8)
>>> +       if (of_property_read_reg(np, 0, &addr, NULL))
>>>                  return false;
>>>
>>> -       return (of_read_number(prop, 1) == link) &&
>>> -               (of_read_number(prop + 1, 1) == id);
>>> +       return addr == (((u64)link << 32) | id);
>>>   }
>>>
>>>   /* Find a matching node for the slave at (link, id). Returns NULL if none
>>> --
>>> 2.39.2
>>>