Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7420648rwp; Tue, 18 Jul 2023 15:18:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlG0XI2+Fn1HEX7oiYSdmz2pI71n+9FvNdeETyKsyUJtYKsH4nUVVPNmIOdvyEfBUkHSI2TR X-Received: by 2002:a17:906:7698:b0:986:f586:b97 with SMTP id o24-20020a170906769800b00986f5860b97mr1049686ejm.59.1689718699318; Tue, 18 Jul 2023 15:18:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689718699; cv=none; d=google.com; s=arc-20160816; b=EYrjhuL/tEy0sC79Vo4BFXYvWLi7IOk/Rc6OqyG8MO5wOzIyYQs5Qt55KXDo53KDc1 fkHDluhLjBYXV7ECvTqdU8H5KmiUnQeYJZcWCCrl6zfHEDjTP3hcrHd47e8hxz450dHv aSEM6BMRckS06c12/1hoWXbzOFy9eUADzFY/hH8i5eTP7ueg2BN7sJX35MPe/so/zZKi JP27h8OlSCBclkHiRXckKRtwDrIj749TiYRRCR6FvlCwhce9dRn5GFxLi71ot6/Ev7x9 MOjl57GXdVoctrDEVGN4Us6mjK6yan31DXN4CeBlk3mq3DqBg8KDpYBd3hVVU5FD657a vkFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=w2BFWfZBUC6Ih6+4Q+w+8NAQgw0coXVqsWvzvDthYGA=; fh=hMV+mtlsJvcyjTJTUYSmxFecCKL83Lw/BTgebaFJrWU=; b=JIcjlvG5Z5+TdGcA2Wzcpnmvp2tPxeOzDqyrJgRxdgLGcXZUiFZAIVhv4FlB4qExiC sguC3n3VR+zpBD8r0VkL+/V8QP3LDkCY4wLGrrf07YU4GtJOm7yWeSe7sDr78BxhZ2dv iDU5NOvlXazwgTydQ2mBmkqrOpE9j7XwTgisrI8qYpIeWwZdlAa4NamT3PXijZ9la4Dt 4RqH8ngZpnwA69KO2KW98clWa90KqruLtiHyBs+KgIBWWCU9BZw1Oc6bgUiXySOEQqax QucWGP9XrAKE20TlxyZ9wIfglQ82iasdOQvSMq6OBAY2ozUXUQD7nR6VLZb2IHYMxuFZ cR4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aBJOcn2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lc17-20020a170906dff100b00992d2a0cd97si1914478ejc.932.2023.07.18.15.17.48; Tue, 18 Jul 2023 15:18:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aBJOcn2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbjGRWHT (ORCPT + 99 others); Tue, 18 Jul 2023 18:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbjGRWHH (ORCPT ); Tue, 18 Jul 2023 18:07:07 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D1A61FF7; Tue, 18 Jul 2023 15:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689718004; x=1721254004; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jCMjbnqIpbK5qtNyuKgUPxCbtUR678kZQh+zhMGb05o=; b=aBJOcn2trMxVN6cXitFYj5QCgA1HWbHOPDX9i+lj/qs/r7vsVEwYmva0 nSqNYi6DSA1tt5GXVt9T72a5VcGXGDG070PSwoEOeTKSaHj3syKYx5OLi cM5f1WvEq8y+fekK3WvpnfJuRvRGc8d4fXtI4OdBqd/xbIv3e1xr/EBCV w80nIlxC2QdYpprnIDVHb7pwzZ3FMqdN/7iACftbN8c+M1gRLAt5S78lr Xj2HhvJs03UmV06W2Hb/ZKC4kotQoeo5utwCjubmeQ1CFJwvv0zkdexhy VmolHJjqcCUJO6MIcQN0iei/ZcYF85YkY4X//33e9VEHoX8s9dTMA7uan A==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="368967359" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="368967359" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 15:06:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="789217133" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="789217133" Received: from unknown (HELO [10.209.37.195]) ([10.209.37.195]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 15:06:00 -0700 Message-ID: <891d530f-fa84-aed7-7465-b4722e983e92@intel.com> Date: Tue, 18 Jul 2023 15:05:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] x86/sgx: fix a NULL pointer Content-Language: en-US To: Haitao Huang , Jarkko Sakkinen , dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: kai.huang@intel.com, reinette.chatre@intel.com, kristen@linux.intel.com, seanjc@google.com, stable@vger.kernel.org References: <20230717202938.94989-1-haitao.huang@linux.intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/23 14:57, Haitao Huang wrote: > Okay, that explains. I would consider it still triggered by high > pressure blips ???? I'm talking about a "blip" being a single allocation. It's *LITERALLY* the smallest (aka. lowest) possible quantum of memory pressure. So go ahead and try to write the changelog without "high" or "low". But, sheesh, if you and are somehow using "high" and "low" to describe the exact same condition, I think that's a rather large communication or understanding problem somewhere. It doesn't bode well for this simple patch.