Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7497470rwp; Tue, 18 Jul 2023 16:49:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlFp4Z7wWeGF3oc76C6/8UUS5ELv0A0W0VLhZPuv5lBJ3iskJLVRTAw4xy7j+ELNFMrKApIo X-Received: by 2002:a17:90b:8f:b0:262:b22b:8ab5 with SMTP id bb15-20020a17090b008f00b00262b22b8ab5mr12266088pjb.17.1689724196718; Tue, 18 Jul 2023 16:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689724196; cv=none; d=google.com; s=arc-20160816; b=EY+6BNRh1Q7nomCxYkSmLKUmW8rmxy/QTYSAT5oKBC4liyjK+I8144cGxv7xKuI8vE 9Oz2fwI6F5GzL7GZxvss/8IeOh3G2JzCqoj1pjgfTyZQQW+dgQrFoPZ5aI1MgmINe3Q0 qUTdJ6bGTz5A4Sn4kqthqfbiTXXp3ueGfprhGluBHaBeky4IYZfL4Tx7m7SZjQ6rKgy8 r2Fpv1PoE3hbN5Jy1NGUWuEG4hYauJEASHI/qwXsOhq28ZCw+Jsw/07PS+AWmkOW+Cls gTvr+kWiZngQYLuGrauO4RSFHMfoNDwh+Rwept+1w19i7isAL/sVAzDru9eSoXzN1MOO sjdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2UlxAZqniI4ip8DXfGf2BifxDsqCdY4NgPzLqfXbVwE=; fh=PpkVdxOiqMdE3y2GW3QtJFkqficSSRWBmGOJYvd0Igw=; b=qTe3tQkXSj1cW+RrQjZxbW73f6N3wHarGt4n0gNVQ0sZ/mYTYQScz9oTY76S4DJ4ed aJaRMsRAF2EvwLl+4NM3t+/9ar15Y3mpY0kBu47+9/nnRpv8yBNpKauYZhZz3qOOQIU5 iF5nqx162+m/PFvDWaT7GvtoATu4JS+7c8VjjI+saO1JHID5YQIwLZQnIfpSR2idXq8+ 68EM2UW3HHkG7WPe6OCKvwM97Nt216Im3LLPP5d75IQXbA8BEnkLRWyiL08+s1sNhSye I5cwNvBUtSIMRzaTHZCTcrBC7qxF0MuW0ryr0WdV6xqQ8jvzRgpZoy/hQcM4Z+utvCxv S6NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jFXw8MwI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h14-20020a170902680e00b001b89ba798d2si2300329plk.498.2023.07.18.16.49.41; Tue, 18 Jul 2023 16:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jFXw8MwI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbjGRWnF (ORCPT + 99 others); Tue, 18 Jul 2023 18:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231279AbjGRWnB (ORCPT ); Tue, 18 Jul 2023 18:43:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D15FA198E; Tue, 18 Jul 2023 15:43:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 705C1612CE; Tue, 18 Jul 2023 22:43:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19AC6C433C7; Tue, 18 Jul 2023 22:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689720179; bh=KRMygVN5jZYm75AeHEbT7m8aCXoMDnLH4Nzw6q1KO5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jFXw8MwIG0ykGM5KJHXJgBUllUkcD41aJyN3dELWmyFoYDw6tL1MYPE+n+0mKG+ny RyDhw1jH9AM0iHvkKl/gDYNEnOEBvcMS+KAqgflt8lHOOShm9FoW+gfh2UdP9AS1Xe X41a6AD0IzY3cdfe67vvuWIprBu9EnWvG/WSXQW90ezfu7Qbyr0l/warnnmfYLc1z8 aVWpwofaN5QHO60JX0l10KBKIDg2JwjAGcAyiOLV/rWuLMThSd2td+2L+I8bRTasB+ txYEX7uUdlwCoL4U5mRL0v95rxNfaZoeiamPHgsGCcY5JeWJ7TcXGj7BI3LjmPFmZY 7yW4U6atL1fLw== Received: (nullmailer pid 2145837 invoked by uid 1000); Tue, 18 Jul 2023 22:42:57 -0000 Date: Tue, 18 Jul 2023 16:42:57 -0600 From: Rob Herring To: Andy Shevchenko Cc: Samuel Holland , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] of/irq: Export of_irq_count() Message-ID: <20230718224257.GA2144433-robh@kernel.org> References: <20230717205357.2779473-1-samuel.holland@sifive.com> <20230717205357.2779473-2-samuel.holland@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 12:40:53AM +0300, Andy Shevchenko wrote: > On Mon, Jul 17, 2023 at 11:54 PM Samuel Holland > wrote: > > > > This function is used by the SiFive GPIO driver. Export it so that > > driver can be built as a module. > > Can we rather reduce use of of_*() APIs? > For example, why not use platform_irq_count()? +1