Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7548974rwp; Tue, 18 Jul 2023 17:51:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlGsXEqqBUvCm1W+e84QFyIbpn2O6El3xMjRgpWZRFJjWY3unfDdH6WMUYq7cWo3qWSz3gc5 X-Received: by 2002:a05:6a20:7349:b0:124:eea9:6691 with SMTP id v9-20020a056a20734900b00124eea96691mr810166pzc.31.1689727880794; Tue, 18 Jul 2023 17:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689727880; cv=none; d=google.com; s=arc-20160816; b=vbsvZrbTDLmA5D984lzG+KgwpSgoweNXHjt10PLMAzC0yheLjN+N1CcB5YgIdQP7Vw UmCiPl9z9B+ILWRYy1EuZTFD5Aj7BTJKGM6UgNrLMhRG6JleiP95nH0QHJsaNurGniA6 iSudJhpsVZyr+pmgfyWAFyD1CNwVuboesshQuADRE7lSDnS8rDJbafB5NGFEZFyvMDVY KhNRYRtVvEzqAYUUrbEgzZgxU4r4MKU9oTfy45pmdiNvjP/qBloIHjCozPEywO5KFmlg BsX0nLulsGfjo/PYW1Z+9SpiIJdPoETdRTJXQ7JGhVkuSlaZMMfYpX2NG+gbMnulPTvm mBWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:message-id:organization :from:content-transfer-encoding:mime-version:date:references:subject :cc:to:dkim-signature; bh=vWVcxlyBH647sJqJAsi5R74tgVjdHZyQiz92n4K/UA8=; fh=TkVbJDo0Vvtz8LjoRiW/5MO289g6kUpB9sJckopOxXI=; b=t+WBjOJdpl3ltOMGfUVNLISXOhu4MQVJ3FmlFrqvt1HosQBkad4ACpwYXif5GehpUF 7vLkEgOgE358LS6C/L8oCOcfL/Hdw2+TZB6vVSyhTvXgGXQoYxyp5Xqz/o+eJ6ha3utJ JqTWqxcIF/KKcr9t9CMWIP1LmT96q5pv873OB5Ztso3uTJ1k2dvumy8JrWaUfbc34md1 t3YooiG+5foVTlsyeNJur4wAEBiY61iV2VPmJf295tzLoLvJ/liQfmUGUdpCbe47b9dw dps4TY22Rz8f7DAeQ88Px8z3SAr9steX3r2qdzoFJ2VQkD1VyYMQJKoD8L/pVlOhYNTh 7vGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=C2klXh6H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j27-20020a633c1b000000b005574bef6f54si2345043pga.486.2023.07.18.17.51.09; Tue, 18 Jul 2023 17:51:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=C2klXh6H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjGSAGs (ORCPT + 99 others); Tue, 18 Jul 2023 20:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjGSAGq (ORCPT ); Tue, 18 Jul 2023 20:06:46 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B97B3; Tue, 18 Jul 2023 17:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689725205; x=1721261205; h=to:cc:subject:references:date:mime-version: content-transfer-encoding:from:message-id:in-reply-to; bh=cVVByayn/bZnw82uquNHaQDWac1HyKeux0qRQyUY51g=; b=C2klXh6Hl5jMNBeSFcJt0hWmhmX/IPVJaM5CiMUZ0bnkOxYEzvtGat57 Xb5s8FQYhGrpoBTLSjqfyjdGthDu/lPxGyNGEjtdTa+Oa4T4eLpTLsP34 H/bhJ5pqymTDUibcXdPbR7A9UfUauFawADciV3yOwULaIqS3MYW9HezDq 7okH/KZ5E7WHd5IZkD/VrtayME2vxOD83AJZNFObi1sW+qqIgg/Ms4G1Q yXxTFuj5oT1BhYSGQkNP4cHuQpDxmslCWKMAPxoPPmY2P577hf2b+VKAw QUHqhi7NDHD7nylHmoq8zzy86WOdpXOWS11gOogXXE7kzS5lcZex3OM0a A==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="432521633" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="432521633" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 17:06:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="674099508" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="674099508" Received: from hhuan26-mobl.amr.corp.intel.com ([10.92.48.113]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Jul 2023 17:06:33 -0700 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Jarkko Sakkinen" , dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , x86@kernel.org, "H. Peter Anvin" , "Dave Hansen" Cc: kai.huang@intel.com, reinette.chatre@intel.com, kristen@linux.intel.com, seanjc@google.com, stable@vger.kernel.org Subject: Re: [PATCH] x86/sgx: fix a NULL pointer References: <20230717202938.94989-1-haitao.huang@linux.intel.com> <891d530f-fa84-aed7-7465-b4722e983e92@intel.com> Date: Tue, 18 Jul 2023 19:06:32 -0500 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Haitao Huang" Organization: Intel Message-ID: In-Reply-To: <891d530f-fa84-aed7-7465-b4722e983e92@intel.com> User-Agent: Opera Mail/1.0 (Win32) X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jul 2023 17:05:59 -0500, Dave Hansen = = wrote: > On 7/18/23 14:57, Haitao Huang wrote: >> Okay, that explains. I would consider it still triggered by high >> pressure blips =F0=9F=98=84 > I'm talking about a "blip" being a single allocation. It's *LITERALLY= * > the smallest (aka. lowest) possible quantum of memory pressure. > > So go ahead and try to write the changelog without "high" or "low". > But, sheesh, if you and are somehow using "high" and "low" to describe= > the exact same condition, I think that's a rather large communication = or > understanding problem somewhere. It doesn't bode well for this simple= > patch. Sorry that did not come across right. I'll send v3 (please skip v2) with= = the comments added as you suggested. Thanks a lot for your time and the review. BR Haitao