Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230718143045.1065100-1-robh@kernel.org>
In-Reply-To: <20230718143045.1065100-1-robh@kernel.org>
From:   Simon Glass <sjg@chromium.org>
Date:   Tue, 18 Jul 2023 19:08:01 -0600
Message-ID: <CAPnjgZ0H077Hdq2HoOyrYxjAmXLigRrj+6H3sPLidtDa2w=Wcw@mail.gmail.com>
Subject: Re: [PATCH v2] power: Explicitly include correct DT includes
To:     Rob Herring <robh@kernel.org>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Support Opensource <support.opensource@diasemi.com>,
        David Lechner <david@lechnology.com>,
        Iskren Chernev <me@iskren.info>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Matheus Castello <matheus@castello.eng.br>,
        devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-oxnas@groups.io
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 18 Jul 2023 at 08:31, Rob Herring <robh@kernel.org> wrote:
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Acked-by: David Lechner <david@lechnology.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix double include of of.h
> ---
>  drivers/power/reset/as3722-poweroff.c            | 1 -
>  drivers/power/reset/brcm-kona-reset.c            | 4 ++--
>  drivers/power/reset/gpio-poweroff.c              | 3 ++-
>  drivers/power/reset/gpio-restart.c               | 2 +-
>  drivers/power/reset/keystone-reset.c             | 3 ++-
>  drivers/power/reset/ocelot-reset.c               | 4 ++--
>  drivers/power/reset/odroid-go-ultra-poweroff.c   | 3 ++-
>  drivers/power/reset/oxnas-restart.c              | 2 --
>  drivers/power/reset/st-poweroff.c                | 2 +-
>  drivers/power/reset/syscon-poweroff.c            | 3 +--
>  drivers/power/reset/syscon-reboot.c              | 3 +--
>  drivers/power/reset/xgene-reboot.c               | 2 +-
>  drivers/power/supply/axp20x_ac_power.c           | 1 -
>  drivers/power/supply/axp20x_battery.c            | 1 -
>  drivers/power/supply/axp20x_usb_power.c          | 1 -
>  drivers/power/supply/cpcap-battery.c             | 2 +-
>  drivers/power/supply/da9150-charger.c            | 2 --
>  drivers/power/supply/da9150-fg.c                 | 1 -
>  drivers/power/supply/lego_ev3_battery.c          | 2 +-
>  drivers/power/supply/ltc2941-battery-gauge.c     | 2 +-
>  drivers/power/supply/ltc4162-l-charger.c         | 2 +-
>  drivers/power/supply/max14656_charger_detector.c | 2 +-
>  drivers/power/supply/max17040_battery.c          | 2 +-
>  drivers/power/supply/max8903_charger.c           | 1 -
>  drivers/power/supply/rn5t618_power.c             | 1 -
>  drivers/power/supply/rt5033_charger.c            | 2 +-
>  drivers/power/supply/rt9455_charger.c            | 3 +--
>  drivers/power/supply/sbs-battery.c               | 2 +-
>  drivers/power/supply/tps65090-charger.c          | 2 +-
>  drivers/power/supply/tps65217_charger.c          | 1 -
>  drivers/power/supply/twl4030_charger.c           | 1 +
>  31 files changed, 26 insertions(+), 37 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>