Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7632751rwp; Tue, 18 Jul 2023 19:56:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGQ6nWh/Alo2URm0tcfNulnIJaaJF7DbmRTzt5WRJ5LpEOY8m7fahr3Dh1i0n6JWFNC6YV1 X-Received: by 2002:a05:6870:d796:b0:1aa:192e:9f35 with SMTP id bd22-20020a056870d79600b001aa192e9f35mr4805222oab.26.1689735392930; Tue, 18 Jul 2023 19:56:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689735392; cv=none; d=google.com; s=arc-20160816; b=Dz+ONMsij3g4eVSgjCmqCSv+FAnH2FlStDAfYTD/2R+d8RWGhi6YLw1bV2Pj8YdF2b /wzOr1xCT0cV51216oFoObi4/viJw7qZBKjGE7ohENqX2L0EfC/3C+IjocH6fp2Yf8bB 4wNK2hytM4ohS0lCR43AODtflAItG0JCbTM4fO3UN1O8o81Vnam1F17rhW7ae8/bFsEx OUhFaaKIp4J10AddwKPEOxP46f/jpxDAHVM/BUcnj2rHnRfILQeLa2/56U8lRlBaMcsi 8lYeXfbf5PcPFUJra2WVYVWuKLjwMVEND32x+jLO4tESFP4+rt8DLLlBlqk//HNeLPAZ mq2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=g3LLhHhYMtWdhdqQaQ2M8PHk7PsBJv7mS00OVrDkecY=; fh=OkaKTlVdPNduaFo4Ma7bTAZqC6S6tK56uGHDhu3uG0A=; b=FOLjeTD3pR0qKG/G0040Rj9RuWj5RifL1LHNwMZlFnNuG37XzrO1iypyuSQbyU2jAt fs58n9Yx900dbkffbgJYrhkB4XZKvUSAtAyeI+V7GiDkvWpTQFd9GDk9prAkRnFlpXl7 XgHJgElJU8op0dpjpz/VJT97fElE557xzAfOE149vFpmkfznggfkstc1q06qAnloBIel TMXwoJ6/tUdy9qM4zDZ43ACDj+lZ8Iyu1Id/uGWc5PwVShQZ9MeH0wrtkqeDQPcGVdTX ZUdqqsmrHApWX6yP1LFebiDP2Qb0LS08hqeBT9Hw3kjudH3q8eUkopiPzAXLrwgKjhe3 OyMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=nOcqibcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw4-20020a056a00450400b006738dfbaf42si2570709pfb.374.2023.07.18.19.56.21; Tue, 18 Jul 2023 19:56:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=nOcqibcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjGSCrF (ORCPT + 99 others); Tue, 18 Jul 2023 22:47:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjGSCrE (ORCPT ); Tue, 18 Jul 2023 22:47:04 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08E37FC; Tue, 18 Jul 2023 19:47:03 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-668709767b1so4738394b3a.2; Tue, 18 Jul 2023 19:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689734822; x=1692326822; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=g3LLhHhYMtWdhdqQaQ2M8PHk7PsBJv7mS00OVrDkecY=; b=nOcqibcH3xHMnvTQntcJFBLENW8p81Amh29A0itJOBhcfyhthu2A3h60NGHtBSkgAZ 6mT+zwCFaWiUbpXME/Qut5ZVBzVZfepjFkLU/BZx70CO9QST8PtbrDfC0SwtI0KMWW6+ BozF4s0c7Kfv5O+LFkTtQv2fBinmc2kVBB5Eu8mrCyosSREW3Dv5yvROjjsE5WQw9+Eu oWknsSnG1CMPhNiqv6JhfsRXPJhObk0J/DMMm2RbdgO8/t5JBVYTuBdH86gsh5ohFIpu LYNuBQ3ETN1z0+5rdQBE1WD8mJHd184lWRCTZMVHFVQk/0yKdkh0sydqa8lERMnavvUt Y8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689734822; x=1692326822; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g3LLhHhYMtWdhdqQaQ2M8PHk7PsBJv7mS00OVrDkecY=; b=NxoY/IGUA8NlFqgJ7f6L3NfeW0xmRHNWyggD0uhbI5HjtjO9BZ6XXi0uldzo+7d1bn s1ySzCUQXLjPuMarnxZYwJsJjrvwxKiQaHL6eDB3+QdQCNqoyCIQwdsrxXDPM78xaPmv Rl3XJoJY1aDZVUhbJQD7N5KLL+Mno43/T675fHXj8Ss85LR1k+oyjQ3KUZXFVCmBuX64 4RXxRrH4MVI27QVge5DK7Nze8fclo/e+vG+Y5zbFY1azcQmjyX8c4WS296qijOJk2Xmu CipvkRCXr0GFcYM0cEXrncDa8tYqGbQ4uJxAGfJQR/2/7rCmStLiepr+lM+yY1L0QSUi Fpmw== X-Gm-Message-State: ABy/qLYZhMtCyHqV7ledFHvn7z4F/rLK2K2qg6dbERPA5S4UzoD9bebH hmeGKjPgDKKIJlmU6elW+Bc= X-Received: by 2002:a05:6a00:181d:b0:67d:b924:54ca with SMTP id y29-20020a056a00181d00b0067db92454camr4633331pfa.34.1689734822268; Tue, 18 Jul 2023 19:47:02 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d1-20020aa78e41000000b006826df9e295sm2162558pfr.113.2023.07.18.19.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 19:47:01 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 18 Jul 2023 19:47:00 -0700 From: Guenter Roeck To: =?iso-8859-1?Q?Joaqu=EDn_Ignacio_Aramend=EDa?= Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v2 2/2] hwmon: (oxp-sensors) Move board detection to the init function Message-ID: <1c5c62c1-a52c-4394-8c8c-db124452e14e@roeck-us.net> References: <20230717222526.229984-1-samsagax@gmail.com> <20230717222526.229984-3-samsagax@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230717222526.229984-3-samsagax@gmail.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 07:25:16PM -0300, Joaqu?n Ignacio Aramend?a wrote: > Move detection logic to the start of init() function so we won't > instantiate the driver if the board is not compatible. > > Signed-off-by: Joaqu?n Ignacio Aramend?a > Reviewed-by: Greg Kroah-Hartman Applied. Thanks, Guenter