Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 19:54:14 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     Kuniyuki Iwashima <kuniyu@amazon.com>, davem@davemloft.net,
        edumazet@google.com, linux-kernel@vger.kernel.org,
        mchan@broadcom.com, netdev@vger.kernel.org, pabeni@redhat.com,
        prashant@broadcom.com, siva.kallam@broadcom.com
Subject: Re: [PATCH] tg3: fix array subscript out of bounds compilation
 error
Message-ID: <20230718195414.4c6f359f@kernel.org>
In-Reply-To: <c196f8f9-3d2c-27c6-6807-75a6e6e4d5a5@amd.com>
References: <20230717143443.163732-1-carlos.bilbao@amd.com>
        <20230717192403.96187-1-kuniyu@amazon.com>
        <c196f8f9-3d2c-27c6-6807-75a6e6e4d5a5@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 18 Jul 2023 10:52:39 -0500 Carlos Bilbao wrote:
> >> Fix encountered compilation error in tg3.c where an array subscript wa=
s =20
> >=20
> > What is the error ? =20
>=20
> drivers/net/ethernet/broadcom/tg3.c: In function =E2=80=98tg3_init_one=E2=
=80=99:

What compiler are you using? Any extra flags?

I remember seeing this warning too, but I can't repro it now (gcc 13.1;
clang 16).

> >> above the array bounds of 'struct tg3_napi[5]'. Add an additional chec=
k in
> >> the for loop to ensure that it does not exceed the bounds of
> >> 'struct tg3_napi' (defined by TG3_IRQ_MAX_VECS).
> >>
> >> Reviewed-By: Carlos Bilbao <carlos.bilbao@amd.com>

We need a sign-off tag
--=20
pw-bot: cr