Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sandor Yu <sandor.yu@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     "andrzej.hajda@intel.com" <andrzej.hajda@intel.com>,
        "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
        "Laurent.pinchart@ideasonboard.com" 
        <Laurent.pinchart@ideasonboard.com>,
        "jonas@kwiboo.se" <jonas@kwiboo.se>,
        "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
        "airlied@gmail.com" <airlied@gmail.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Oliver Brown <oliver.brown@nxp.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "sam@ravnborg.org" <sam@ravnborg.org>
Subject: RE: [EXT] Re: [PATCH v7 3/7] dt-bindings: display: bridge: Add
 Cadence MHDP850
Thread-Topic: [EXT] Re: [PATCH v7 3/7] dt-bindings: display: bridge: Add
 Cadence MHDP850
Thread-Index: AQHZuIUePa/zOSPAXUe6/zQl/U27da/AHoWAgABCD1A=
Date:   Wed, 19 Jul 2023 02:32:39 +0000
Message-ID: <PAXPR04MB9448A6CD96FB6CE751E565A8F439A@PAXPR04MB9448.eurprd04.prod.outlook.com>
References: <cover.1689580812.git.Sandor.yu@nxp.com>
 <3646ea4d279838c78e00af1d746e3de34351b083.1689580812.git.Sandor.yu@nxp.com>
 <20230718223249.GB2112396-robh@kernel.org>
In-Reply-To: <20230718223249.GB2112396-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+spA5o/GlrFyIjSLi/FnVNjhBhe7RSNTABTIaINREysR73hBLKMlhg40VTbE?=
 =?us-ascii?Q?3tdnT6hrEXKROAaZqZ3Ba/tzdWVBiNoWqOchV7wmrEa+uu/m55GwO9Q7joef?=
 =?us-ascii?Q?Xkyoxr7DWImdrkW1Wd1Jb8YA2MGM7LMWNioovOPu0mrbwjQx8buVXfjxhX4V?=
 =?us-ascii?Q?QuBoOqxtcWiYe8rqNlfrn8m2eFO9qYSvRErKZLqLriGbGnZHGoa+hW8Jmhiu?=
 =?us-ascii?Q?GTGN5McGHPyVca9j9zSoQi3YkQ1xAwp4czt8HcuMexBJWeSBbWP6C9lHcTbR?=
 =?us-ascii?Q?7mzNiNPRxpo/9BxPRoZa4RtDj2/gynVB49BYAGydW4FjpograUQjyMF6z9SX?=
 =?us-ascii?Q?Oelo3ck38DZByyIatoGBgOkFbn7gjvVnpYVFH/lsgSLREHRV3X6yWEFSmnOm?=
 =?us-ascii?Q?/GLypEt7vrsDujC//dPBCHNYPB67Vrff/CKkiG3QF5axZ6YhhwjKkWbwifmM?=
 =?us-ascii?Q?cTB8Ulgg+iPuEVHxmQR4sfn4XIC+y0UewVBV9B5ggUwj8U1Fq6ksetPCYm8L?=
 =?us-ascii?Q?TeCres935VcJG8NqEau4r0Je1+Th4i5KGruZYGCiCfw7jzeU+RN8PR7v0h61?=
 =?us-ascii?Q?6+7sOHwcDE/mKXNwUgfm0huj/yUYZQxl4h6Y/igGA+7w9KiLmzg1lJAm/Mzj?=
 =?us-ascii?Q?ZkSTJFTPrH4eCceGX70WkuMhjaW80ttzRJh8ixXviPQgw1d0DLPzQXilwOeo?=
 =?us-ascii?Q?B9A90ihuqmBbFrd3sSM3NuZfETgARQ+wvCNAu2JopXwO07AZRK6Di6tX7c0i?=
 =?us-ascii?Q?0Mc81DKeTixAmtwImAUfYJR8MzSrD2EWBaWyIv+b662KsO6fZE8QfG7z4SZi?=
 =?us-ascii?Q?YUiWcI7imb1RHToGoqolX3otG/a87hx0WysM3ijNAYGlTO0JVp9WOuCtEajb?=
 =?us-ascii?Q?xfzVSdMf1yUKqU3dEPLfN4q4piTeUM3TKqyjfBYH90T4J4OFhI8kFPhZQ7V1?=
 =?us-ascii?Q?DJSQ2TIGL9zlhYPIKbDo62a8goIiodjlFGwbgk/rT3XxIpHFtZJolnp0DJZl?=
 =?us-ascii?Q?73LwwVFvWAXgsZQ1nLh8MoVfyaHdvSesr99LW16GQpB667mopvfuxwWD2IjI?=
 =?us-ascii?Q?m1xz6HZSgLFdHgPhZue8/nklVBd6/wd2jfD3oxor5HAMTbDshmRS2X8bYi3W?=
 =?us-ascii?Q?f7KaEJI+53CVTNlTVyTSGVm2nATW8KNb/N7QuSDG3rD+VWIEAGvVxhvX2mjb?=
 =?us-ascii?Q?f5WS/vtmoUeMvYgh44Bphccw7C9fi2GBAw2yWsgeAMOa7hAH3CwErSP5cwTY?=
 =?us-ascii?Q?leffvokhf+3k5VWA512bWV+L5PaXuFrP4P6Jte+EY0CE5VGRITEnMqY7YapI?=
 =?us-ascii?Q?OOHh98K1YYl8qK9gSqirJTQ4qbuZgFCFeG6l2ZRtJC8Hv0Wu4yFRQz12xTH9?=
 =?us-ascii?Q?P/e94an7iLYxG30PEnNr7FVPtUMxyqBbaE9zMXHf7sw6JP8btCSB7HAP6Q6U?=
 =?us-ascii?Q?TyKOQVskNQEakyQhY36I/9jQVngYf0sie2wywrRfwMTtYsaRxj3JcBbfWpoj?=
 =?us-ascii?Q?vPdMjhuDO/xM88xdN4fwPcASbqGAkoXYLE/OhguvXzcaL4ul0rKMOUd8KE86?=
 =?us-ascii?Q?8yhTRl4/S8gdItw/YLI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9448.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b74a330-700b-4b67-c44e-08db88006be4
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 02:32:39.4015
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E3vKok/J+lfJzCSYGXRkDiKIzHm3cGLtYN6/kCc5CWpYPAi/7xQoIU1ItU8BQAgPoikmhgukoodRsp6Cc6mbIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9792
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,=20

Thanks for your comments,

> > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge..
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> > ---
> >  .../display/bridge/cdns,mhdp8501.yaml         | 105
> ++++++++++++++++++
> >  1 file changed, 105 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> > b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> > new file mode 100644
> > index 000000000000..b983ee765f54
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.y
> > +++ aml
> > @@ -0,0 +1,105 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> >
> +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp8501.yaml%
> 23&dat
> >
> +a=3D05%7C01%7CSandor.yu%40nxp.com%7C7c33f38de4804df82ed108db87d
> eeeef%7C
> >
> +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63825316378283684
> 1%7CUnkno
> >
> +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwi
> >
> +LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DM0fImRvAyayYwQLSQsJVo
> OQF59Y47KI5
> > +XNnVzmuTHOc%3D&reserved=3D0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=3D05%7C01%7CSandor.
> yu%40n
> >
> +xp.com%7C7c33f38de4804df82ed108db87deeeef%7C686ea1d3bc2b4c6fa9
> 2cd99c5
> >
> +c301635%7C0%7C0%7C638253163782836841%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoi
> >
> +MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%
> >
> +7C%7C&sdata=3DiCjpKSNsRnQYhRlXz7%2FR46uot%2B3aYbFz1ecfy63dYaw%3
> D&reserv
> > +ed=3D0
> > +
> > +title: Cadence MHDP8501 DP/HDMI bridge
> > +
> > +maintainers:
> > +  - Sandor Yu <Sandor.yu@nxp.com>
> > +
> > +description:
> > +  Cadence MHDP8501 DisplayPort/HDMI interface.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - cdns,mhdp8501
>=20
> Drop this.
OK, " - cdns,mhdp8501" will be dropped.
B.R
Sandor
>=20
> > +      - fsl,imx8mq-mhdp8501
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description: MHDP8501 DP/HDMI APB clock.
> > +
> > +  phys:
> > +    maxItems: 1
> > +    description:
> > +      phandle to the DisplayPort or HDMI PHY
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Hotplug cable plugin.
> > +      - description: Hotplug cable plugout.
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: plug_in
> > +      - const: plug_out
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Input port from display controller output.
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Output port to DisplayPort or HDMI connector.
> > +
> > +    required:
> > +      - port@0
> > +      - port@1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - interrupts
> > +  - interrupt-names
> > +  - phys
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/imx8mq-clock.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    mhdp_dp: dp-bridge@32c00000 {
> > +        compatible =3D "fsl,imx8mq-mhdp8501";
> > +        reg =3D <0x32c00000 0x100000>;
> > +        interrupts =3D <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> > +                     <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > +        interrupt-names =3D "plug_in", "plug_out";
> > +        clocks =3D <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > +        phys =3D <&dp_phy>;
> > +
> > +        ports {
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +
> > +            port@0 {
> > +                reg =3D <0>;
> > +
> > +                mhdp_in: endpoint {
> > +                    remote-endpoint =3D <&dcss_out>;
> > +                };
> > +            };
> > +
> > +            port@1 {
> > +                reg =3D <1>;
> > +
> > +                mhdp_out: endpoint {
> > +                    remote-endpoint =3D <&dp_connector>;
> > +                };
> > +            };
> > +        };
> > +    };
> > --
> > 2.34.1
> >