Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7653761rwp; Tue, 18 Jul 2023 20:27:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlFlSvb+mhFpK9UrDj9oiCIfsu2Ri56l08N+fOu7Pfjy/Jdwi1xF1Te7kWHXYMN/6h7HDt2+ X-Received: by 2002:a05:6a00:2408:b0:678:5629:fd43 with SMTP id z8-20020a056a00240800b006785629fd43mr1508923pfh.9.1689737228159; Tue, 18 Jul 2023 20:27:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689737228; cv=none; d=google.com; s=arc-20160816; b=lCwMKFMXK6Fr6OvSq4EV36axkCRdnLflB8WYzB6TIvCxvqt2W+pLib/sLgSlQ/sGSd 5JsDlGBTPUEV0CohVEdypby415BcR8tDpYKxdrMQWuCmZUyHZnfBMcCSm8F8DuPsfQvv tXaFZhPXwV/9fBXaPHXBF41fRFBmourSpc1akVNVz+UZFPZTEJqgy/+8nzCq3hkU3J+1 9GMWrklGDR8ePg+kPkxV6xgBkl3OdUWKdFBmj+wHLMrh7YSY6uPFWfF5xSn7lUUhJkZj Okf+NTcPuQ4Gyn+IYw5kanUXd6H9PfJmbSHwEjcONMUtPbIgLhvBCwdD+OsqO6XkiUY7 1ZUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SQ2sfuRabNCRryyG0w0mWClv5rUZXBtwnAUtcGvJHD0=; fh=pCGM0XMLy2t7LDg+w2ZsrY+1MokiYe2RK0YBztoiaUw=; b=eT0tt/E+yUkKhRJN0QrL7Wac0E5pS+WqMdqhBV6CVgc0YUIr2qwY8DOjo5EBVdY3gQ txmYWet7GW1QMOZrCSXN1XGxQeT8rlPlty5h0YoP9u3BUxMc1objtncyVRgvMUM/w5av 4Ln/dlzF9r4/DCX+knaGImrSma8cvak+qtcQZlXdMkKn76cf9CZPMk/oHwKPBo3Fxdxo I1z7BlUi6pinYZ2RK+MKuQrcj544AbtzR1NUl0d/USm194BNMdGP5qxKioU3kSD9AcPk jlhI+C4VgkxNsUuxkh/PvhU9hSVE/D/RFfI7rkcb3qQFFIZdXdZVWcuACuYoypUu5BWD EbQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eg26-20020a056a00801a00b0066882062113si2556642pfb.9.2023.07.18.20.26.55; Tue, 18 Jul 2023 20:27:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjGSC7n (ORCPT + 99 others); Tue, 18 Jul 2023 22:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjGSC7l (ORCPT ); Tue, 18 Jul 2023 22:59:41 -0400 Received: from out28-51.mail.aliyun.com (out28-51.mail.aliyun.com [115.124.28.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08EF1130; Tue, 18 Jul 2023 19:59:39 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1746865|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_social|0.0353264-0.00181599-0.962858;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047193;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=26;RT=26;SR=0;TI=SMTPD_---.Tx3JJXh_1689735568; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.Tx3JJXh_1689735568) by smtp.aliyun-inc.com; Wed, 19 Jul 2023 10:59:31 +0800 From: wangweidong.a@awinic.com To: rdunlap@infradead.org Cc: alsa-devel@alsa-project.org, broonie@kernel.org, ckeepax@opensource.cirrus.com, colin.i.king@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, doug@schmorgal.com, fido_max@inbox.ru, flatmax@flatmax.com, herve.codina@bootlin.com, kiseok.jo@irondevice.com, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, rf@opensource.cirrus.com, robh+dt@kernel.org, shumingf@realtek.com, tiwai@suse.com, trix@redhat.com, wangweidong.a@awinic.com, yijiangtao@awinic.com, zhangjianming@awinic.com Subject: Re: [PATCH V1 4/5] ASoC: codecs: aw88261 chip register file, data type file and Kconfig Makefile Date: Wed, 19 Jul 2023 10:59:27 +0800 Message-ID: <20230719025928.41357-1-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <94068cfc-186a-1cac-0f76-77b3b46a85bd@infradead.org> References: <94068cfc-186a-1cac-0f76-77b3b46a85bd@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Randy Dunlap, Thank you very much for your advice > On 7/17/23 04:58, wangweidong.a@awinic.com wrote: >> +config SND_SOC_AW88261 >> + tristate "Soc Audio for awinic aw88261" > Awininc > (as below) I will modify it as suggested. >> + depends on I2C >> + select CRC8 >> + select REGMAP_I2C >> + select GPIOLIB >> + select SND_SOC_AW88261_LIB >> + help >> + this option enables support for aw88261 Smart PA. This >> + The Awinic AW88261 is an I2S/TDM input, high efficiency >> + digital Smart K audio amplifier with an integrated 10.25V >> + smart boost convert. > Less indentation on the last line (align it with the previous line). I will modify it as suggested. Best regards, Weidong Wang