Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7656235rwp; Tue, 18 Jul 2023 20:31:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlFTJG52FS7cKuV9IvzL3Ee21H3wG0fFsJxnjV4E368bjERyammwFL6Am7vm3m1PWgvYvJyI X-Received: by 2002:a05:6358:9907:b0:135:6793:62bf with SMTP id w7-20020a056358990700b00135679362bfmr1480455rwa.11.1689737460871; Tue, 18 Jul 2023 20:31:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689737460; cv=none; d=google.com; s=arc-20160816; b=rDyqEPEvVXjoD83OX2myQlUwAOMedXzqAiDBTBeUU7rj1JIunHX0UvbfkRt8AKzt/G m8XlI2ORam+aZfA9ulL92FqEfLD9QDS5EZFC0H0BYm4ag1CJFQRWBz8i7tK6fzh7IBRA 4EJBdDBbugjg7HtZS48uOEI/rba0lh7V7X3c4Q83EM7AcHStoa4cyJ1at2R2EDBaHo7Q Z/XCnsCIGLEKl8bwjsPZmukerdCuzjmgs6JhenkcLBajwKsqY4wZgq1Rbp/VAW3zBMg4 O3G7/O6DBVj7oWXHXprLcRui5jV50MBw100mf5bzcbVCKAQxg/sE5Cc5mTefqctg2Y/H PArg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/i2hn33XDVRaAxA4HmTOShUacDy3148UrmR09pCPGTI=; fh=X2PP891rDsgriezinHXPZWuoik5vILdpOxM0cJwGYlY=; b=rwZtQM7kw20cj1G95pN1zGr1rHDdkq6X0Uo0wjaOVo+BuRZD5fTDXPAJUWZj0Cq0Mj L1p1UkpXuvAK+5P30YVpTakC3Brt2h3sPg/k6bo+cC5v6EJUijT5eGaNg58UbrDROqZo XLTvreOUjkd5hjGajmbCy+MxdTT5AHCeNKKkNHXjVdgRfHJWRAQ+/kXhU0+mEaCflJBI uD+0hgS6s55j/euVqFRO/mxbWhwRzMT+s1W0nkO4X1FKzN2V8pTO+sgh92HAYujeYFTR Crle8RSIieh10erU5hadzoVzjKjcUJyvHCLLt6r60iXth7hOy6CujD/DPbCTe871Rzih S/fA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a63d809000000b0055337ca9cefsi2551957pgh.857.2023.07.18.20.30.49; Tue, 18 Jul 2023 20:31:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjGSDDK (ORCPT + 99 others); Tue, 18 Jul 2023 23:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjGSDDG (ORCPT ); Tue, 18 Jul 2023 23:03:06 -0400 Received: from out28-221.mail.aliyun.com (out28-221.mail.aliyun.com [115.124.28.221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17735130; Tue, 18 Jul 2023 20:03:04 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.09700525|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_social|0.00813514-0.000320179-0.991545;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047206;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=26;RT=26;SR=0;TI=SMTPD_---.Tx3STlc_1689735772; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.Tx3STlc_1689735772) by smtp.aliyun-inc.com; Wed, 19 Jul 2023 11:02:56 +0800 From: wangweidong.a@awinic.com To: krzysztof.kozlowski@linaro.org Cc: alsa-devel@alsa-project.org, broonie@kernel.org, ckeepax@opensource.cirrus.com, colin.i.king@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, doug@schmorgal.com, fido_max@inbox.ru, flatmax@flatmax.com, herve.codina@bootlin.com, kiseok.jo@irondevice.com, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, rf@opensource.cirrus.com, robh+dt@kernel.org, shumingf@realtek.com, tiwai@suse.com, trix@redhat.com, wangweidong.a@awinic.com, yijiangtao@awinic.com, zhangjianming@awinic.com Subject: Re: [PATCH V1 5/5] ASoC: dt-bindings: Add schema for "awinic,aw88261" Date: Wed, 19 Jul 2023 11:02:52 +0800 Message-ID: <20230719030252.41396-1-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <192fa604-5fe6-c5c2-7fca-10f3a271b640@linaro.org> References: <192fa604-5fe6-c5c2-7fca-10f3a271b640@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Krzysztof, Thank you very much for your advice. On 18/07/2023 16:24, krzysztof.kozlowski@linaro.org wrote: > On 17/07/2023 13:58, wangweidong.a@awinic.com wrote: >> From: Weidong Wang >> >> Add a DT schema for describing Awinic aw88261 audio amplifiers. They are >> controlled using I2C. >> >> Signed-off-by: Weidong Wang ... >> + compatible: >> + const: awinic,aw88261 >> + >> + reg: >> + maxItems: 1 >> + >> + '#sound-dai-cells': >> + const: 0 >> + >> + reset-gpios: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' >> + - reset-gpios > I don't see any differences against AW88395. Add the compatible to that > schema. I will add "awinic,aw88261" to the awinic,aw88395.yaml Best regards, Weidong Wang