Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230717143443.163732-1-carlos.bilbao@amd.com>
 <20230717192403.96187-1-kuniyu@amazon.com> <c196f8f9-3d2c-27c6-6807-75a6e6e4d5a5@amd.com>
 <20230718195414.4c6f359f@kernel.org>
In-Reply-To: <20230718195414.4c6f359f@kernel.org>
From:   Eric Dumazet <edumazet@google.com>
Date:   Wed, 19 Jul 2023 06:30:50 +0200
Message-ID: <CANn89i+wMUGHoMzeK9ZttJUeZj-acK4M6__tYL1_o4nEdPY5=g@mail.gmail.com>
Subject: Re: [PATCH] tg3: fix array subscript out of bounds compilation error
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Carlos Bilbao <carlos.bilbao@amd.com>,
        Kuniyuki Iwashima <kuniyu@amazon.com>, davem@davemloft.net,
        linux-kernel@vger.kernel.org, mchan@broadcom.com,
        netdev@vger.kernel.org, pabeni@redhat.com, prashant@broadcom.com,
        siva.kallam@broadcom.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 19, 2023 at 4:54=E2=80=AFAM Jakub Kicinski <kuba@kernel.org> wr=
ote:
>
> On Tue, 18 Jul 2023 10:52:39 -0500 Carlos Bilbao wrote:
> > >> Fix encountered compilation error in tg3.c where an array subscript =
was
> > >
> > > What is the error ?
> >
> > drivers/net/ethernet/broadcom/tg3.c: In function =E2=80=98tg3_init_one=
=E2=80=99:
>
> What compiler are you using? Any extra flags?
>
> I remember seeing this warning too, but I can't repro it now (gcc 13.1;
> clang 16).

Same here, I think I was seeing this 4 or 5 years ago.
I ignored the warning at that time because we were using an old compiler.

>
> > >> above the array bounds of 'struct tg3_napi[5]'. Add an additional ch=
eck in
> > >> the for loop to ensure that it does not exceed the bounds of
> > >> 'struct tg3_napi' (defined by TG3_IRQ_MAX_VECS).
> > >>
> > >> Reviewed-By: Carlos Bilbao <carlos.bilbao@amd.com>
>
> We need a sign-off tag
> --
> pw-bot: cr