Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c657304-7fb6-1f03-9fa6-7225fc14c28d@kernel.org>
Date:   Wed, 19 Jul 2023 14:37:09 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] m68k/pci: Drop useless pcibios_setup()
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-m68k@lists.linux-m68k.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
References: <20230718204229.493669-1-helgaas@kernel.org>
From:   Greg Ungerer <gerg@kernel.org>
In-Reply-To: <20230718204229.493669-1-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Bjorn,

On 19/7/23 06:42, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> The PCI core supplies a weak pcibios_setup() implementation that is
> identical to the m68k implementation.  Remove the m68k version since it is
> unnecessary.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Thanks. Seeing as this is related to the ColdFire parts I'll take this through
the m68knommu git tree. Applied to the for-next branch.

Regards
Greg


> ---
>   arch/m68k/kernel/pcibios.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
> index b0e110d3d2e6..9504eb19d73a 100644
> --- a/arch/m68k/kernel/pcibios.c
> +++ b/arch/m68k/kernel/pcibios.c
> @@ -92,9 +92,3 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>   		pci_write_config_byte(dev, PCI_LATENCY_TIMER, 32);
>   	}
>   }
> -
> -char *pcibios_setup(char *str)
> -{
> -	return str;
> -}
> -