Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5e71fa4-ad39-f958-4eca-887f60544f54@kernel.org>
Date:   Wed, 19 Jul 2023 07:37:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] serial: core: Fix serial core port id to not use
 port->line
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Tony Lindgren <tony@atomide.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dhruva Gole <d-gole@ti.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230719051235.46396-1-tony@atomide.com>
 <82c49602-8c6e-51c2-6f73-28fb9b458db8@kernel.org>
 <ZLd154hdaSG2lnue@smile.fi.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <ZLd154hdaSG2lnue@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19. 07. 23, 7:34, Andy Shevchenko wrote:
> On Wed, Jul 19, 2023 at 07:26:41AM +0200, Jiri Slaby wrote:
>> On 19. 07. 23, 7:12, Tony Lindgren wrote:
> 
> ...
> 
>>>    	int			ctrl_id;		/* optional serial core controller id */
>>> +	int			port_id;		/* optional serial core port id */
>>
>> Can the id be negative? If not, please use uint.
> 
> Does this suggestion apply to ctrl_id as well?

Sure, but he hasn't added it in this series ;). So it should go to 
someone's todo :P.

-- 
js
suse labs