Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c0061557-1dc7-0442-b5e0-3e528d0bebb1@kernel.org>
Date:   Wed, 19 Jul 2023 07:36:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] serial: core: Add support for dev_name:0.0 naming for
 kernel console
Content-Language: en-US
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dhruva Gole <d-gole@ti.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230719051525.46494-1-tony@atomide.com>
 <35758c24-1543-6f96-7957-b371dc94e59d@kernel.org>
 <20230719052811.GH5194@atomide.com>
 <87431096-e883-c90d-853e-44a463c0e8f2@kernel.org>
 <20230719053220.GI5194@atomide.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20230719053220.GI5194@atomide.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19. 07. 23, 7:32, Tony Lindgren wrote:
> * Jiri Slaby <jirislaby@kernel.org> [230719 05:29]:
>> On 19. 07. 23, 7:28, Tony Lindgren wrote:
>>> * Jiri Slaby <jirislaby@kernel.org> [230719 05:25]:
>>>> On 19. 07. 23, 7:15, Tony Lindgren wrote:
>>>>> +/*
>>>>> + * Add preferred console if configured on kernel command line with naming
>>>>> + * "console=dev_name:0.0".
>>>>> + */
>>>>> +static int serial_core_add_preferred_console(struct uart_driver *drv,
>>>>> +					     struct uart_port *port)
>>>>> +{
>>>>> +	char *port_match, *opt, *name;
>>>>> +	int len, ret = 0;
>>>>> +
>>>>> +	port_match = kasprintf(GFP_KERNEL, "console=%s:%i.%i",
>>>>> +			       dev_name(port->dev), port->ctrl_id,
>>>>> +			       port->port_id);
>>>>> +	if (!port_match)
>>>>> +		return -ENOMEM;
>>>>> +
>>>>> +	opt = strstr(saved_command_line, port_match);
>>>>> +	if (!opt)
>>>>> +		goto free_port_match;
>>>>> +
>>>>> +	len = strlen(port_match);
>>>>> +
>>>>> +	if (strlen(opt) > len + 1 && opt[len] == ',')
>>>>> +		opt += len + 1;
>>>>> +	else
>>>>> +		opt = NULL;
>>>>> +
>>>>> +	name = kstrdup(drv->dev_name, GFP_KERNEL);
>>>>
>>>> Why do you dup the name here?
>>>
>>> I was getting ignoring const warning, but maybe the right solution is
>>> to just use const char *name here.. Let me check.
>>
>> So fix add_preferred_console() instead ;).
> 
> Let's see what kind of trouble changing it to use const char *name
> might be.

I don't see any, the string is copied internally. So it should be 
straightforward. Actually all three parameters of 
__add_preferred_console() should be const, IMO. But that involves 
changing struct console_cmdline. But that should be straightforward too.


Aside from that, why do you parse saved_command_line on your own? 
Instead of using setup() or other commonly used mechanisms for command 
line handling?

thanks,
-- 
js
suse labs