Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 07:53:32 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Bill O'Donnell <billodo@redhat.com>,
        Rob Barnes <robbarnes@google.com>, bleung@chromium.org,
        linux-fsdevel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: export emergency_sync
Message-ID: <20230719-zwinkert-raddampfer-6f11fdc0cf8f@brauner>
References: <20230718214540.1.I763efc30c57dcc0284d81f704ef581cded8960c8@changeid>
 <ZLcOcr6N+Ty59rBD@redhat.com>
 <ad539fad-999b-46cd-9372-a196469b4631@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ad539fad-999b-46cd-9372-a196469b4631@roeck-us.net>
Precedence: bulk

On Tue, Jul 18, 2023 at 09:08:06PM -0700, Guenter Roeck wrote:
> On Tue, Jul 18, 2023 at 05:13:06PM -0500, Bill O'Donnell wrote:
> > On Tue, Jul 18, 2023 at 09:45:40PM +0000, Rob Barnes wrote:
> > > emergency_sync forces a filesystem sync in emergency situations.
> > > Export this function so it can be used by modules.
> > > 
> > > Signed-off-by: Rob Barnes <robbarnes@google.com>
> > 
> > Example of an emergency situation?
> 
> An example from existing code in
> drivers/firmware/arm_scmi/scmi_power_control.c:
> 
> static inline void
> scmi_request_forceful_transition(struct scmi_syspower_conf *sc)
> {
>         dev_dbg(sc->dev, "Serving forceful request:%d\n",
>                 sc->required_transition);
> 
> #ifndef MODULE
>         emergency_sync();
> #endif
> 
> Arguably emergency_sync() should also be called if the file is built
> as module.
> 
> Either case, I think it would make sense to add an example to the commit
> description.

On vacation until next. Please add a proper rationale why and who this
export is needed by in the commit message. As right now it looks like
someone thought it would be good to have which is not enough for
something to become an export.