Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7808175rwp; Wed, 19 Jul 2023 00:02:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlEgTcC53Nh1Ezxme3axpUXq7ddfdC6TmE75x/yGm08QrzvfIN3pMzGmIAgaKWROUIq6LGfZ X-Received: by 2002:a05:6a20:4407:b0:137:63fa:2a17 with SMTP id ce7-20020a056a20440700b0013763fa2a17mr118380pzb.12.1689750169198; Wed, 19 Jul 2023 00:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689750169; cv=none; d=google.com; s=arc-20160816; b=IDDndVz2uQC+RvdOGXzQCCd9YaJJiNFQx9tk50F2HhWplA48lzah/t4OINTo9ZWL6Y TP7u2gjpcwpZj805eJO6jnUbESPFvlvOg5xBfJ8J9D99nvwrZWlddBs9AO19nr+howzF 9QDJkXjdOIk8Cyj2dKGH17jIrF6BF75piFODDhEhD+ihI4fAhYNfDeLT+g9hU6zycO9h FT6JQ/JPDYWLz9wtbj6v08j9cdlOxjGMBKgKSXssLyuP4bLV6DGPeDV1SxDcbrAiNP8s TsIO06KcI1cGD9THNHNmeAqA9kCTczJFImLN5IGfgywiyRqhznMK1OFrhspXccQd2Czj NOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mkZLqHE3iVHOICOh6iAIAdodJXBEtzaLjqYAOg31flE=; fh=MfQq+N1yTB1dU02ZDkHHx2erBeKdxCPQlIw5lD+ukF8=; b=xVkR1gbyyXetSdtafBbaSN0JFIuMwduJIiXOARCqtTccXh7XP09N/w4+C7w/aHROkz jaPExB9h8HX3POvGW8i9aPqLy+hpQe4KamifJ4iTIksnQuQyWMpXHlNJp2lvwGWHKsDP pCDqwNnaUPY5vA4v4ZTz8cB+bcsnZUmUaX/A8/983Nl/wk4qCiUVdUuF949VfEQ3unSH WPtCNKUdF5BOkXknMIzGtD4X6wiZnYmvGndTK4LD/j0H4mzuRYtn7o+nVd86bu+TOZxU 4s0WXBADgScp8mJReaXzZjQx6oEoBoYIqmpirvkL+AbO7djf2SfmsGtCDfWj7eFxsltv hYRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shruggie-ro.20221208.gappssmtp.com header.s=20221208 header.b=yUCW3tkG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd16-20020a056a00279000b0064d28479818si2939225pfb.96.2023.07.19.00.02.36; Wed, 19 Jul 2023 00:02:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@shruggie-ro.20221208.gappssmtp.com header.s=20221208 header.b=yUCW3tkG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjGSGCR (ORCPT + 99 others); Wed, 19 Jul 2023 02:02:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjGSGCO (ORCPT ); Wed, 19 Jul 2023 02:02:14 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41FB11BF5 for ; Tue, 18 Jul 2023 23:02:13 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fbc5d5746cso65378465e9.2 for ; Tue, 18 Jul 2023 23:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shruggie-ro.20221208.gappssmtp.com; s=20221208; t=1689746531; x=1690351331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mkZLqHE3iVHOICOh6iAIAdodJXBEtzaLjqYAOg31flE=; b=yUCW3tkG/kSrvrobap4JiXMH8bgw20XFnode3DLpSUy/YVixR82w6c6+lRxBm4iEYF 6iBoT6Z2CIZhey3wj7kGeNAKmkonTtRpuCaeKXGBLSS1cS0kQB0+OG8SU3M8qdhB3TIv ripPSqSPZEQ+ztjs+G+1P3ZhyxY3hjw9IzBXbgUvLQdF6twnq56bgCVzVFyBfefEi+oV /povO4vBPvB9FFpaDMdbyV6sZQAA4l0hzVTXBcKlEPna4D4pftPBOhzfd2QOy5s/ETYO xR+/7iemVrRv0oLI7sLOX7xaV90JHETAixZ8o5W3SsNMlcV9cLFFhyiAdTBtSYvhJ3T2 R8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689746531; x=1690351331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mkZLqHE3iVHOICOh6iAIAdodJXBEtzaLjqYAOg31flE=; b=etsFfpLTz/tgzYLSoY8FHzWawGvbfHFZcrVq/qfzC4Uv8FEpLyT8Aaj7V1aB8EgZJw 01iey6H82rclu/ZwfZdVrSLA4N62TWEzTTOwzy50n2BYKayrLDRXQj5x4vgbh1hnik+T RXo8echCflVYAOdwyo0LM98zuvQP/mn9AWNGU72Q4cJbyU1QW75zkN2MlM5PVkPP8NWc vQXRGrQXAf5zlZwaC5I0s7JohucGrJKyXbCZ832L2VvXwfPMDEEJFeiRyounkGkUDszN y5mAABVNjeDrgkdnGmehPqjZWobPFkSHKveLp7AUzYXMzslNbUF+BzZ8KsUneTfkHrCf HX9g== X-Gm-Message-State: ABy/qLZ+Y4N1p6klBX0wc4cQ8c2vC+joSHbosbOh4KFeXsR5qXWOR9fc SNZXErhYAlFYsRAr5gjc0XuJEgl9qlnjvVW0u4E= X-Received: by 2002:a05:600c:2253:b0:3fb:a937:6024 with SMTP id a19-20020a05600c225300b003fba9376024mr3604367wmm.29.1689746531235; Tue, 18 Jul 2023 23:02:11 -0700 (PDT) Received: from localhost.localdomain ([188.27.129.168]) by smtp.gmail.com with ESMTPSA id q13-20020a1ce90d000000b003fa95890484sm810119wmc.20.2023.07.18.23.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 23:02:10 -0700 (PDT) From: Alexandru Ardelean To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: bogdan.togorean@analog.com, nuno.sa@analog.com, daniel@ffwll.ch, airlied@gmail.com, jonas@kwiboo.se, Laurent.pinchart@ideasonboard.com, rfoss@kernel.org, neil.armstrong@linaro.org, andrzej.hajda@intel.com, festevam@gmail.com, Alexandru Ardelean Subject: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5 Date: Wed, 19 Jul 2023 09:01:43 +0300 Message-ID: <20230719060143.63649-1-alex@shruggie.ro> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20190716131005.761-1-bogdan.togorean@analog.com> References: <20190716131005.761-1-bogdan.togorean@analog.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bogdan Togorean For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register. So depending on ADV model write 0xfb or 0x4a register. Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533") Reviewed-by: Robert Foss Reviewed-by: Nuno Sa Signed-off-by: Bogdan Togorean Signed-off-by: Alexandru Ardelean --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ddceafa7b637..8d6c93296503 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511, else low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE; - regmap_update_bits(adv7511->regmap, 0xfb, - 0x6, low_refresh_rate << 1); + if (adv7511->type == ADV7511) + regmap_update_bits(adv7511->regmap, 0xfb, + 0x6, low_refresh_rate << 1); + else + regmap_update_bits(adv7511->regmap, 0x4a, + 0xc, low_refresh_rate << 2); + regmap_update_bits(adv7511->regmap, 0x17, 0x60, (vsync_polarity << 6) | (hsync_polarity << 5)); -- 2.41.0