Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 23:22:26 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Artur Weber <aweber.kernel@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [RESEND PATCH 2/2] Input: mms114 - add support for touch keys
Message-ID: <ZLeBIma/CLcK++RF@google.com>
References: <20230714100424.29798-1-aweber.kernel@gmail.com>
 <20230714100424.29798-3-aweber.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230714100424.29798-3-aweber.kernel@gmail.com>
Precedence: bulk

On Fri, Jul 14, 2023 at 12:04:24PM +0200, Artur Weber wrote:
> +	} else if (data->num_keycodes > MMS114_MAX_TOUCHKEYS) {
> +		dev_warn(&client->dev,
> +			"Found %d linux,keycodes but max is %zd, ignoring the rest\n",
> +			 data->num_keycodes, MMS114_MAX_TOUCHKEYS);

This gives me the following warning:

drivers/input/touchscreen/mms114.c: In function ‘mms114_probe’:
drivers/input/touchscreen/mms114.c:520:25: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
  520 |                         "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I changed the format specifier to "%d" and applied.

Thanks.

-- 
Dmitry