Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5353872c-56a3-98f9-7f22-ec1f6c2ccdc8@linaro.org>
Date:   Wed, 19 Jul 2023 08:36:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] dt-bindings: reset: Updated binding for Versal-NET
 reset driver
Content-Language: en-US
To:     Michal Simek <michal.simek@amd.com>,
        Conor Dooley <conor@kernel.org>,
        Piyush Mehta <piyush.mehta@amd.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        git@amd.com
References: <20230717112348.1381367-1-piyush.mehta@amd.com>
 <20230717112348.1381367-2-piyush.mehta@amd.com>
 <20230717-explode-caucus-82c12e340e39@spud>
 <ee81e955-32be-66ea-377b-263ee60a2632@linaro.org>
 <e8f48a30-9aff-bc2f-d03f-793840a192c9@amd.com>
 <694a1314-0b25-ff5e-b19f-5a0efe07bf64@linaro.org>
 <cae162d0-843d-ca1f-80d3-5a0dfe1e3d0f@amd.com>
 <22e7dc73-2411-5cb1-6cef-daa5f2af8297@linaro.org>
 <5df3e976-9fc2-19af-e6b4-e2bea0d64623@amd.com>
 <4c932cbf-19db-2c88-2558-aa42c5338598@linaro.org>
 <ab0fb666-e370-cb07-367b-f3b88e18fba9@amd.com>
 <a12286d2-f929-ed6d-c0f2-4dad5ce6b388@linaro.org>
 <3f76ff03-963d-fff8-b512-abce447da7d0@amd.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <3f76ff03-963d-fff8-b512-abce447da7d0@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/07/2023 08:23, Michal Simek wrote:
>> Yes. If you want to store some constants (register values, firmware
>> magic numbers) and use in DTS, this is the way to go. Most (or all) of
>> examples above are for register values.
> 
> I did small grepping over Linux (reset only) and I found that all of these files 
> are not used by any driver/code. They are included in binding document or dt files.
> Based on your description above they all are candidates for removing from 
> include/dt-bindings/reset/.
> On the other hand that files could be used in different projects out of Linux 
> where that values could be used by a driver/code.

Yes, therefore this should be case-by-case decision.

> 
> What to do with it? Should we remove it, deprecate it or just keep it and not to 
> add new one? I just want to know how to properly handle it.

They cannot be removed. They could be copied to DTS and deprecated in
the bindings. But it is not that important that we clean it up... or it
is rather to the platform maintainer. I did it some time ago for Samsung
and recently TI is doing for serdes mux bindings.

Best regards,
Krzysztof