Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 09:20:19 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Lee Jones <lee@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Mark Gross <markgross@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Tobias Schaffner <tobias.schaffner@siemens.com>
Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver
 default on platform
Message-ID: <20230719092019.5545ee15@md1za8fc.ad001.siemens.net>
In-Reply-To: <0f38956f-8d23-4f50-8e76-85fc3e225fd6@roeck-us.net>
References: <20230718105213.1275-1-henning.schild@siemens.com>
        <20230718105213.1275-2-henning.schild@siemens.com>
        <0f38956f-8d23-4f50-8e76-85fc3e225fd6@roeck-us.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G98Hxha5fTP9HBFdgelwPCkrQdrGquNFxnIgFqDuw04qXd06egsGqOKbWWzm?=
 =?us-ascii?Q?KErxVFSdQWmAsSBay2v4MdCHa+ksX3UyEdMeIsxB+5W2qH8vMua8VXG93dgG?=
 =?us-ascii?Q?HRN6qyXhhUU1WPLphxNbFCIChbGjLZJ04/WTRywx34SrBsZHpxQB5aOgQ3M6?=
 =?us-ascii?Q?KkTvpgb5toeEEQwmUvlD5uvuZdwhHZPLu0yQPpG2yTpMXjE/itK8KzQL9C9F?=
 =?us-ascii?Q?rmiOPvbEQDC/WuR5bo2sv0yGpz/K4h2BOuwC+nyH4SKarghcOYBlWWpS+dXZ?=
 =?us-ascii?Q?BEO8jSbaBTZ3UQ+Ob7rKzchySOeqUbcOyHp3+pqy6ns0RupDluRHGyyDmCDF?=
 =?us-ascii?Q?ivLVbfm2BsIQ/G2In063NnOP9+XXsyloMEjXgjA7s6yKEsXd7YASRSM9ris9?=
 =?us-ascii?Q?lOp2gpMulGoiFH8ssk4AqNX4o3hRPcrP6a0cwzt5jGyiCdmRrab4UUyaurFk?=
 =?us-ascii?Q?dX2YOdc0qscyowRWTCTkRu4Xv25+MBZnk3a0VSt0Sg7f/nL6PdOi9VvY9a3Y?=
 =?us-ascii?Q?GIMHlT29dW26TU5r3pLJrA+0C0uiEWGAkWYnskT2A4NqjnGfS1zRfX9zeWaE?=
 =?us-ascii?Q?TmWpcP2HcjuKs85fhko1crHFzv8QLV/CIIuNEnJVwxYbtPMr6xLQYXDSJSOH?=
 =?us-ascii?Q?YhWqudHGupRWNDMpgXiKJN5wxlCtylBK97hB9WyXv9zAnFHkfPT8DBbk5RU6?=
 =?us-ascii?Q?zl/XcshfjKruY5Mh5El0uKFYcxMIQdrRdtf/ARRl2MySMoPHCf7c5bmJNk5c?=
 =?us-ascii?Q?wkAOda+BkXm34FBwC2/XyR1umkbo9LaBxFnuwmCk9gis+YVytaIz+TdL59Hc?=
 =?us-ascii?Q?dhJpgMxPtkkwKm6bK3//5y633d9x+rLaZBU1r1NKJB2xgQK4j9Qg6rgPNB8j?=
 =?us-ascii?Q?RaTLzVYB+IR75dxl2qayOrKVP2Hp5DfXEZ0WSQl3k9yx3A0+QUrIlXe9t53F?=
 =?us-ascii?Q?Srk61b3xvNl7iViGbicaFBCd3OYiZ39v3Ly400iw1kxw31C5/7Fou5vajI2L?=
 =?us-ascii?Q?lHndZF9xhAYmDyZXhvv9XyiwVVR0CPcCQoHMYhIfsjAGL0vRfxtyPpMo5OYI?=
 =?us-ascii?Q?ibTtZvwAQWUfwhfGzDQsb6VtkzrbP3MrBYLpmT5/uLoj/n9EF/iI9vjkYyrw?=
 =?us-ascii?Q?Xd3rLhwNqBjZrnHH4q21KTPDULy45BLsk22+0If3QvOQ77+Qq1PcOYztIO8H?=
 =?us-ascii?Q?G7NCQEtD6ovp4owjrDLLmDHr3jVgFp4v9XTPn7RBRjOhrSw+0eSYdBcgDp1L?=
 =?us-ascii?Q?ceBKBBcTNTJSytt0KnhSCSivTOMH9I4P5ClX5FKC/wDx8Dopjly90Oz14na5?=
 =?us-ascii?Q?0+u00Xf5LnpyuGum8Nbkl2UoBYYL9W0UGA5KAwVs67Cl+/Bin0JPFZbFUiG5?=
 =?us-ascii?Q?A9SZmpV3kTd6DqdZcKC+mVe6BwgMygZx0vVKvc0o2/X2CfXhen/9oXzbcFRb?=
 =?us-ascii?Q?MjhOslnB9iLY+sJiunV4T+wsGvdnovARRaeqsAIXculUn1KN2YaOioYKX4+7?=
 =?us-ascii?Q?HiyfsHrz1fAecg60UXuD0MhPMohTODRQhHZNPPf0zXSpHb/qZLwhyBh3BcF3?=
 =?us-ascii?Q?+X7xgltUk1sZKwGiOIyB7LUNfA09lzXI044OmsVS1iX71lYNGynonM8kKNCJ?=
 =?us-ascii?Q?jhXWjdo+bbNkNl7pQHF+IH7aWYhuahzQqIsxrfnyn9BG7td7MOt2kwb+Xgz+?=
 =?us-ascii?Q?gJEYkA=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07df36d0-1c09-4f1e-3433-08db88289e5b
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 07:20:24.1291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FX4AjymXxt+8JmUtW7a76DBYtfdSfgLLS+/+ijEuzXxssv6OMVgVAxLWAySZJEyv0jofA+fbkRZ9b4PsUgSGugdfNWzeJiJISFiFp0/mmCA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6560
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 18 Jul 2023 08:07:52 -0700
schrieb Guenter Roeck <linux@roeck-us.net>:

> On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> > If a user did choose to enable Siemens Simatic platform support they
> > likely want that driver to be enabled without having to flip more
> > config switches. So we make the watchdog driver config switch
> > default to the platform driver switches value.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  drivers/watchdog/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index ee97d89dfc11..ccdbd1109a32 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -1681,6 +1681,7 @@ config NIC7018_WDT
> >  config SIEMENS_SIMATIC_IPC_WDT
> >  	tristate "Siemens Simatic IPC Watchdog"
> >  	depends on SIEMENS_SIMATIC_IPC
> > +	default SIEMENS_SIMATIC_IPC  
> 
> Why not just "default y" ? That does the same (it will be set to m if
> SIEMENS_SIMATIC_IPC=m) without the complexity.

I see. Thanks! In that case i will go for "default y" and not "default
m" which i wrote about in the other mail.

Henning

> Guenter
> 
> >  	select WATCHDOG_CORE
> >  	select P2SB
> >  	help
> > -- 
> > 2.41.0
> >