Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 10:13:27 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM
 device
Message-ID: <20230719101327.25b9ee7a@xps-13>
In-Reply-To: <ZLavw9ZyXMWMqTu_@makrotopia.org>
References: <ZLaZ03PzkbPNJQ3b@makrotopia.org>
        <e155a4bf-46b7-c07a-f3e0-80fae8108f56@linaro.org>
        <ZLavw9ZyXMWMqTu_@makrotopia.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Daniel,

daniel@makrotopia.org wrote on Tue, 18 Jul 2023 16:29:07 +0100:

> On Tue, Jul 18, 2023 at 03:55:56PM +0100, Srinivas Kandagatla wrote:
> > HI Daniel,
> >=20
> > On 18/07/2023 14:55, Daniel Golle wrote: =20
> > > Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not
> > > having any cells in order to make sure sysfs attributes of a previous=
ly
> > > registered NVMEM device are not accidentally reused for a follow-up
> > > device which doesn't have any cells.
> > >=20
> > > Fixes: 757f8b3835c9 ("nvmem: core: Expose cells through sysfs") =20
> >=20
> > These patches are dropped out of nvmem next branch as it was breaking s=
ome
> > existing users. =20
>=20
> Ok. I've encountered those commits in linux-next and can confirm that
> they were definitely also breaking things here, hence my patches at
> least partially fixing that.
>=20
> I agree that reverting them for now and reworking them seems to be the
> better option in this case, hence my patches won't be needed as such.

Quite the opposite, on my setup I don't have any breakage but as you
already fixed the cell name issue (also reported by Chen-yu), if you
agree, I will include these fixes (or an improved version) in my next
proposal.

Thanks,
Miqu=C3=A8l